From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21680EB64D9 for ; Fri, 7 Jul 2023 11:56:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7DD268D0002; Fri, 7 Jul 2023 07:56:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 78D458D0001; Fri, 7 Jul 2023 07:56:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 658518D0002; Fri, 7 Jul 2023 07:56:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 52A268D0001 for ; Fri, 7 Jul 2023 07:56:22 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id DBF78A0D61 for ; Fri, 7 Jul 2023 11:56:21 +0000 (UTC) X-FDA: 80984662962.23.73C1DDE Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf14.hostedemail.com (Postfix) with ESMTP id 88C9F10001D for ; Fri, 7 Jul 2023 11:56:19 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=CuLL4eFq; spf=pass (imf14.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1688730979; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+zNBj9eYnDea9EN+o9qg7xJQFBC+d+IwoAvBLbNge90=; b=J+UckE2T3gtb5DRaiVZwTnn0z4iDU9u/HIWH/XLTe80bPckbmKUISE0/h1D/5NotYy9R9N mWnrQpnQnYUAEVuVqik8scocloFXNR+J6qcfDTyfy0/yBCrc56HwJAmDKd8oaTDGcdqHeh 1ZbUpFBYhE8yGr187ybuwcKRUGxfTls= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1688730979; a=rsa-sha256; cv=none; b=Ae8wYWbXmDVvtQ8V+A+DEsIbV8GiMdqug4pGkQUYtfcXezUAE1AqX09+ZEY2nnw8wEThOz ZctFWn+tJUtG1PYKhS/bSLeQurxqYBM57XJRFcULhrUzqZzI9LF3Ayn0+XhJ1FuJv9E/db yltXQ1JvtehmjKHm1SL3XTw4+dB+zfA= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=CuLL4eFq; spf=pass (imf14.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1688730978; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+zNBj9eYnDea9EN+o9qg7xJQFBC+d+IwoAvBLbNge90=; b=CuLL4eFqF5xqf+ijXnINIfyLNvhYCNOLH8KH8TEzaNaNBHUvhijAdV8GMXT8MLoDqfG8O3 1Iba8YOIola0xlZFRg4rRfvw2fdTp6UD/rFWVmxyI7PTVYuVKnnsN//AlmIVfQjNNids68 VG4Nl8v7pZV6VvljC1UNjHTsZShohcA= Received: from mail-lf1-f71.google.com (mail-lf1-f71.google.com [209.85.167.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-130-guJZtDWmOIuEc62lBofWgQ-1; Fri, 07 Jul 2023 07:56:17 -0400 X-MC-Unique: guJZtDWmOIuEc62lBofWgQ-1 Received: by mail-lf1-f71.google.com with SMTP id 2adb3069b0e04-4fb87c48aceso1749853e87.3 for ; Fri, 07 Jul 2023 04:56:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688730976; x=1691322976; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=+zNBj9eYnDea9EN+o9qg7xJQFBC+d+IwoAvBLbNge90=; b=D6MKHmN6Ul336o3qIUYuDScUr1p1lfpyqOuUCOSuERhd2hEbpTuVSmW6l3CVNBJNhp s3SJx/+bS4ZSOzyUKa3jfqApBPXvk5KJGbXF7MeeR7Aybwn5e/fjHxcXfs3Cx6dGxqWo g4T8uL7T+SGm8NNn5tRD2mt9YPI9V3f2adkzSiXSdzpW0XY/mC9xX8/R1aVBGkQC7g/C uz93gOIf/L+ln9Z4Gparbxqi5JXMWU9l8EbCRmAloc6aKtTe2892cJLTUELDyb2JZfkX 9j3C6ajZ8GTTQAkw122NmnXjcDjdzRjwSxRsSYrwAR2skUDMOGfBKzid9oTA+S8SRAkB Dndw== X-Gm-Message-State: ABy/qLbHkEfVb16IgiT04bQTAlT6oBroXHrNIvOzytl2h2L5AkummLeA FHgL29XmvYPSHUA5JyqTFZekrUAzTZDvunB5O43y4Zo5TL4twDK7HZ0si0oZ7x8GM+H5roFIQoq Zj4nAKSPbzQc= X-Received: by 2002:a19:3817:0:b0:4f8:6ac1:15a9 with SMTP id f23-20020a193817000000b004f86ac115a9mr3528064lfa.31.1688730976194; Fri, 07 Jul 2023 04:56:16 -0700 (PDT) X-Google-Smtp-Source: APBJJlH1NgRVc3OyU27DGp44pw0IZffZSzCCo4rAZ1Zy7J5nsJoOjuSMd5Nz/ESPaFv4Afa474lRAQ== X-Received: by 2002:a19:3817:0:b0:4f8:6ac1:15a9 with SMTP id f23-20020a193817000000b004f86ac115a9mr3528046lfa.31.1688730975779; Fri, 07 Jul 2023 04:56:15 -0700 (PDT) Received: from ?IPV6:2003:d8:2f04:3c00:248f:bf5b:b03e:aac7? (p200300d82f043c00248fbf5bb03eaac7.dip0.t-ipconnect.de. [2003:d8:2f04:3c00:248f:bf5b:b03e:aac7]) by smtp.gmail.com with ESMTPSA id k14-20020a7bc30e000000b003fbd2a9e94asm2257133wmj.31.2023.07.07.04.56.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 07 Jul 2023 04:56:15 -0700 (PDT) Message-ID: Date: Fri, 7 Jul 2023 13:56:14 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH 2/2] mm: compaction: skip the memory hole rapidly when isolating free pages To: Baolin Wang , akpm@linux-foundation.org Cc: mgorman@techsingularity.net, vbabka@suse.cz, ying.huang@intel.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: From: David Hildenbrand Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: ecn7m9kiq4bpdc13rxmt7rdf8gfds6s1 X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 88C9F10001D X-Rspam-User: X-HE-Tag: 1688730979-932170 X-HE-Meta: U2FsdGVkX18prK8GDeEfqJ6Jpol+CCmCXWKf7mosn/8iwFkg4RyhduyyCiQVFekVs10sN5WWHUsBi/NJsi84tpiNnG7m9gzZYP2LNvriR+TFKN75JZDsW3htfc5UZ3Zaix17RLEhsyzCDHhLo2qAqKlIiFSjJET3CIwkJDeF8j2QQRTYcL2ZwxcCeymgBIYdgSVz0NCi1HdHiiVRqBCoFJHARJkgaeIDA1bo3BMVOxtRcu6/+lQ+4/m41GRJr4EC9ktqKlp9kQ/wtUAX8EAfgBanzZnSd2PVu19T0AKoQFFBzzt9iW9Omzzx6mwJOLkyHwwG0k4cQ7iCx7XTgwD5qPUFP9R57aVLOK+rhV24dRh6pAqS90awETDmIF6KNy4GFvig9ucuHGKIPCBWHAEso5nQV+JvPXhmZcIErTaxDfFFvWLiSUfAQwkwdMchX6bKK10AeF/IWgBKHyGIWZoyF8HZACh7pO2zvp8fopSWsZSaKKcgMi7cDLWay3iCjH6ddyx6SEv11YWtOO6iuqapSWzS7YV3DXAv3ae+MQpbZP9EisDfbZUnDiznY09zNARx4swoXrf7n0leGbNh28HJuq96bjEl969NOFNab05Tj/TPTD5QBfU4cXTnn4ETk1gG/n59I0VIiFsenez95tTdBMtSHZgimNfv2Vp3L8DEf2hs0adE4H35Ofj6fo6KIHCEesaNpL9KrqvTv9EyV83N93viwpLlwQ+uBM10fvwqQ5ZSIGFl9bhTVYfW4T8763kBSvLm4AXDgiDPG726rzqy9d33n98Lm0nEKckTNyJk36vhz0dLtpnPVyxUHg9gnkvF6fXYtutJRrKoPB0OJy29/7LgaYwUj3qRnx8KArsi6eiZ+09iMz5Kcl8DZU3SgpAuLuiZw0bSvEujEXnxYRjHg8C4RHCtRQR4tMNdjtARHHMsRmbLCHjzN5FpsEbXSw8kTZUTaHP7EWCd8Pqe381 TQQDTXD2 PIVBr498WJl3B1SBCyfCR5n5uxHmRZpQSNrL97f0nLV7a0jnXV5zE/SVYC9R1k2KTvLQgaOR3nS8IxrQO3xrdzcRDvKrfBKXo770pwzK1TXdnp82PVGP1XvaEvlS53ODwO+guQtFLHpEm1JgngLf9+UXDbAUtCEe5cgZdWM2TsRFAZWAZYlMN6ldMITB/o80kLm87uKkZIZ2MDK7pSdg6loQborHPmYV/UBFNIgAgoN39GPbYXojLD2DAsyWXeCb4+0wz0a5BLfCfJy9E9KKBpCJ6bNZ0pYnEk5Y8hyfU/anT1/aIN7yfikfBdMHJw4kK39sa8lwWqPcK52eilla+2+iaeZysUMgE1bI7KyYMr932dD1SiWJ+T8flDngxcKv+qL4QRKfJWeAH8SOiPp7t7AWkPx4C7VPagWjc95PUdz2GleA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 07.07.23 10:51, Baolin Wang wrote: > On my machine with below memory layout, and I can see it will take more > time to skip the larger memory hole (range: 0x100000000 - 0x1800000000) > when isolating free pages. So adding a new helper to skip the memory > hole rapidly, which can reduce the time consumed from about 70us to less > than 1us. Can you clarify how this relates to the previous commit and mention that commit? > > [ 0.000000] Zone ranges: > [ 0.000000] DMA [mem 0x0000000040000000-0x00000000ffffffff] > [ 0.000000] DMA32 empty > [ 0.000000] Normal [mem 0x0000000100000000-0x0000001fa7ffffff] > [ 0.000000] Movable zone start for each node > [ 0.000000] Early memory node ranges > [ 0.000000] node 0: [mem 0x0000000040000000-0x0000000fffffffff] > [ 0.000000] node 0: [mem 0x0000001800000000-0x0000001fa3c7ffff] > [ 0.000000] node 0: [mem 0x0000001fa3c80000-0x0000001fa3ffffff] > [ 0.000000] node 0: [mem 0x0000001fa4000000-0x0000001fa402ffff] > [ 0.000000] node 0: [mem 0x0000001fa4030000-0x0000001fa40effff] > [ 0.000000] node 0: [mem 0x0000001fa40f0000-0x0000001fa73cffff] > [ 0.000000] node 0: [mem 0x0000001fa73d0000-0x0000001fa745ffff] > [ 0.000000] node 0: [mem 0x0000001fa7460000-0x0000001fa746ffff] > [ 0.000000] node 0: [mem 0x0000001fa7470000-0x0000001fa758ffff] > [ 0.000000] node 0: [mem 0x0000001fa7590000-0x0000001fa7ffffff] > > Signed-off-by: Baolin Wang > --- > mm/compaction.c | 30 +++++++++++++++++++++++++++++- > 1 file changed, 29 insertions(+), 1 deletion(-) > > diff --git a/mm/compaction.c b/mm/compaction.c > index 43358efdbdc2..9641e2131901 100644 > --- a/mm/compaction.c > +++ b/mm/compaction.c > @@ -249,11 +249,31 @@ static unsigned long skip_offline_sections(unsigned long start_pfn) > > return 0; > } > + > +static unsigned long skip_offline_sections_reverse(unsigned long start_pfn) > +{ > + unsigned long start_nr = pfn_to_section_nr(start_pfn); > + > + if (!start_nr || online_section_nr(start_nr)) > + return 0; > + > + while (start_nr-- > 0) { > + if (online_section_nr(start_nr)) > + return section_nr_to_pfn(start_nr) + PAGES_PER_SECTION - 1; > + } > + > + return 0; > +} > #else > static unsigned long skip_offline_sections(unsigned long start_pfn) > { > return 0; > } > + > +static unsigned long skip_offline_sections_reverse(unsigned long start_pfn) > +{ > + return 0; > +} > #endif > > /* > @@ -1668,8 +1688,16 @@ static void isolate_freepages(struct compact_control *cc) > > page = pageblock_pfn_to_page(block_start_pfn, block_end_pfn, > zone); > - if (!page) > + if (!page) { > + unsigned long next_pfn; > + > + next_pfn = skip_offline_sections_reverse(block_start_pfn); > + if (next_pfn) > + block_start_pfn = max(pageblock_start_pfn(next_pfn), > + low_pfn); > + > continue; > + } > > /* Check the block is suitable for migration */ > if (!suitable_migration_target(cc, page)) LGTM Acked-by: David Hildenbrand -- Cheers, David / dhildenb