From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf0-f198.google.com (mail-pf0-f198.google.com [209.85.192.198]) by kanga.kvack.org (Postfix) with ESMTP id 2B1CA6B0038 for ; Wed, 27 Sep 2017 18:12:10 -0400 (EDT) Received: by mail-pf0-f198.google.com with SMTP id x78so25337534pff.7 for ; Wed, 27 Sep 2017 15:12:10 -0700 (PDT) Received: from out4433.biz.mail.alibaba.com (out4433.biz.mail.alibaba.com. [47.88.44.33]) by mx.google.com with ESMTPS id y11si10501plg.98.2017.09.27.15.12.07 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 27 Sep 2017 15:12:09 -0700 (PDT) Subject: Re: [PATCH 2/3] mm: oom: show unreclaimable slab info when kernel panic References: <1506473616-88120-1-git-send-email-yang.s@alibaba-inc.com> <1506473616-88120-3-git-send-email-yang.s@alibaba-inc.com> From: "Yang Shi" Message-ID: Date: Thu, 28 Sep 2017 06:11:46 +0800 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Christopher Lameter Cc: Pekka Enberg , David Rientjes , Joonsoo Kim , akpm@linux-foundation.org, mhocko@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org On 9/27/17 2:59 PM, Christopher Lameter wrote: > On Thu, 28 Sep 2017, Yang Shi wrote: >>> CONFIG_SLABINFO? How does this relate to the oom info? /proc/slabinfo >>> support is optional. Oom info could be included even if CONFIG_SLABINFO >>> goes away. Remove the #ifdef? >> >> Because we want to dump the unreclaimable slab info in oom info. > > CONFIG_SLABINFO and /proc/slabinfo have nothing to do with the > unreclaimable slab info. The current design uses "struct slabinfo" and get_slabinfo() to retrieve some info, i.e. active objs, etc. They are protected by CONFIG_SLABINFO. We could replicate the logic in get_slabinfo without using struct slabinfo, but it sounds not that necessary and CONFIG_SLABINFO is typically enabled by default and it is not shown in menuconfig. Thanks, Yang > -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org