From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9082DC71157 for ; Wed, 18 Jun 2025 13:14:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2FA276B008A; Wed, 18 Jun 2025 09:14:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2D1A26B008C; Wed, 18 Jun 2025 09:14:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1C08E6B0092; Wed, 18 Jun 2025 09:14:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 0B9CF6B008A for ; Wed, 18 Jun 2025 09:14:02 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 660385FC0F for ; Wed, 18 Jun 2025 13:14:01 +0000 (UTC) X-FDA: 83568564282.13.BE247DE Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf05.hostedemail.com (Postfix) with ESMTP id C8A9D10000C for ; Wed, 18 Jun 2025 13:13:58 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=OC8p64ll; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf05.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750252439; a=rsa-sha256; cv=none; b=bPxs/tWOicaSM4mJNNwzLJTsV7qc9dTr+CyDlSyvCtX2970SfuS3+EnGgPuAvpyadEioz7 tQpwN1Zcn3k0c2TUP0gc90Zzwe27K059s0daFK6y/wcb83uRIDmVil4VUfiSBBtFlKqwgK BAWqlTPpQhGsLQefrCPoXlmv1DGLV3g= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=OC8p64ll; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf05.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750252439; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Ef97kz76Yw9Jt5ZZFpKUT1V1+HqkUXj4ehQiBa13hww=; b=2TofD3GKRgiKI9o6JlaprUwKDyu8Oq9q0PcFjgGB7Apiuf0iRU7Hh59n95sIsCDK5nV0qz ueNR5lx5rnVDtcn3zWXJ7k6PJtYZlHluy+eTqCzFEGrCDOS9AfrVSfCYLUk2qFx8PEfrID ceNsJ23uTbT7WEYn4UxCIp8Dgd/YMu4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1750252438; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Ef97kz76Yw9Jt5ZZFpKUT1V1+HqkUXj4ehQiBa13hww=; b=OC8p64llRyLIzYjFk/vr/r2ChgeXoPnuj17hjkGMP4CUb8kp4q7Xn0vh6aTmZ2TO9fhpSj Mk8410qJGVGHv/HI/jy1pMQv/P7IEQy2Foi5fGkbcUT7+oERY3rPJFN3Jfy6nS1IP1LnJT Tox+/Wx0Y9yN8W/EQAPeeFXuPCQGPhc= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-59-RC3InQFcMt-ZglzsUdN0gQ-1; Wed, 18 Jun 2025 09:13:56 -0400 X-MC-Unique: RC3InQFcMt-ZglzsUdN0gQ-1 X-Mimecast-MFC-AGG-ID: RC3InQFcMt-ZglzsUdN0gQ_1750252435 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-3a4e713e05bso3142911f8f.3 for ; Wed, 18 Jun 2025 06:13:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750252435; x=1750857235; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=Ef97kz76Yw9Jt5ZZFpKUT1V1+HqkUXj4ehQiBa13hww=; b=c8t8QfWfidCFZ/U+gzzA6Ril9E0bAeTwMlhTJpmmVKtT8yPdqWIE4M243TaGYrGdvo RqabSO0pHEWgULyKWhIzt3E9YYZ44Xkc5TpIEdHsbaKFyCHP7N2F4kCfHe+2RchJyXRb s0C9PteLOsx16WeH4a6Lq/NOw3kHU4oSi2mqpnRhcG63d+2S6ZIrL/g55kE3rf9vokiH 47VsmlB5uezhiN8drKP4X0pODK/G/pC/nvYhX8QWMYr13UMLjrLCVlSgCmqLM1mPMcFL /ZlymHwqpb2Q9vvLIq2IsfLELuT14q6jNo2SMDrx+06hcPXT2gqrGB3iiIOSBGDvSwZ4 lIsA== X-Forwarded-Encrypted: i=1; AJvYcCVWN+o+I8wWghu6hqRm8H6P6dTc8aEExSx/EW1Mu4cdymOoN2pe1uQ6SPqy/FYYPC5aMRVpKpwoLQ==@kvack.org X-Gm-Message-State: AOJu0Yz9uKtJyV6/ucHr69ptTSEXP5slSSg+luANulGV5kUy9jAVPdzb ZvyiGEL8CPBKubP+n8JYwlG80cUldh2OZuS1vO0zh4+z9v+HN5Xn1VQaVzYhVqoBy8GNn9DLp5e +SJ4WIz8bPDBNW7DZ/fSKFmfhivCf0FbS0IXSQ5WN3KiabKurxHRB X-Gm-Gg: ASbGncvl3Ymbd1dQ43KWCDIpFAfeWHkNZ5AVbGgXQm0jWFCZ7hT1WOhXvPBZFjWW9wD uwK6ICfuyiuOWkpdgH7ZsOnnsifQbPlQjaGslYWktDVtKiXIoX18nIUP9EkNxVVRkqetMzifeuG RFMQst0+fFsDlRJ44PZstekPi4RKhyUzIb+qKDL6k+PTl+7M+l1LJCgCe4OVgsO3FGoNh1Oajv7 bEuVXG7JJT9KIHRn0GDViB3TrA2Z2LyW5ox9/Tz8SblaKYzo5+I/NW95CMjhEo60GF9PYerVTOf Nb/bM3ddghC1XqOQmMBYUe98L7FeKbg5CxAZwBEzDwZ65p10H7Gv/Vge9KM1S42Dz5e56LqpfbH aubFVs5RBvBzDsBuo4k8F/1Cl7/5PYfr1SAbzbFtTXR7fwH4= X-Received: by 2002:a5d:5c84:0:b0:3a4:f7db:6ff7 with SMTP id ffacd0b85a97d-3a572e58792mr15395024f8f.52.1750252435428; Wed, 18 Jun 2025 06:13:55 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFyPOqWC+fIYY0jjSKYxhMePrlWdjpx8vPXshA1FnDDeRFHER8ChNGxHVBBmp44RK9t8q39ug== X-Received: by 2002:a5d:5c84:0:b0:3a4:f7db:6ff7 with SMTP id ffacd0b85a97d-3a572e58792mr15394981f8f.52.1750252434857; Wed, 18 Jun 2025 06:13:54 -0700 (PDT) Received: from ?IPV6:2003:d8:2f2d:2400:4052:3b5:fff9:4ed0? (p200300d82f2d2400405203b5fff94ed0.dip0.t-ipconnect.de. [2003:d8:2f2d:2400:4052:3b5:fff9:4ed0]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a568b79f45sm16872576f8f.101.2025.06.18.06.13.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 18 Jun 2025 06:13:54 -0700 (PDT) Message-ID: Date: Wed, 18 Jun 2025 15:13:53 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4] mm: use per_vma lock for MADV_DONTNEED To: Lance Yang , Barry Song <21cnbao@gmail.com> Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Barry Song , "Liam R. Howlett" , Vlastimil Babka , Jann Horn , Suren Baghdasaryan , Lokesh Gidra , Tangquan Zheng , Qi Zheng , Lance Yang , Lorenzo Stoakes , Zi Li References: <20250607220150.2980-1-21cnbao@gmail.com> <309d22ca-6cd9-4601-8402-d441a07d9443@lucifer.local> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: SiTcXTNbmZ82qnjfT73eoPKB69njg_H1QW5EQbrCp6Y_1750252435 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Queue-Id: C8A9D10000C X-Rspamd-Server: rspam10 X-Stat-Signature: 7zo9fk7za7ujhwu5ejhd57orqixej6o9 X-HE-Tag: 1750252438-619485 X-HE-Meta: U2FsdGVkX1/KbKxE+WrQjSCp7LQVuZUkT2i8RxOrDtrgmQxojxiz7MMB5j093JYDlUCTFr0115xWtZYg56ILMiUHe4zqxH+QtiygRs7V6MvNk7mMcGlVQLPrJySOP/WXsA5D2PcPF9dA1SGvHKoJNQM3YrwngEZDlXb54nThQuM5MBOQTuXqdtsA9SdaRRPihgkB4Kbi6/ftqcPged7C5wlze3le+s2lSr8CSbKWquNZuxrHaU9HHq9CA6f9aWLPMuVNWhFn3DoiP2Pmg481xCjOZyRq0tO94PBfFxjA2sijqrvI4kodxpSDXiQ2gZG17CWwgt6opmTljJG6Mm6juFRoADpQ5p0wTKFGBIGGtTHaCyJ0LeJyUgrNwcmMAhIyDn0wAm3HkjKz3AiMiNrrdG/O4V1h5s1DExHNGKzELjmUWCdmojPwhIkBzVmOkK5khymEn+VTWRVpS4ehNuEcrEmpB42zEzWErDU5jVOd2m6RxHfLuPHguLbXpW0LZDfqaS7fzRXSzmBO3OOgPUPEMrXq5EfCRcHcY4yhScanjHWAHJKAKCE/6IU8ON74zOjlaG69SpUgI2d+kWKKVsjm9nYMFjlQ0i0sQQruyB3B1zyJSfQNUOFj2Zw8J+FhHSu/fnyJf+cq2Krm1QEoJW0MLR8oQBV289BzqayxxJxCN+f1yDKWnOnYSqWAr95BIYm3FmLQb/8CTbVjs4Yf9WyKUTAU9hZuF+5Zml0JFRjAEGD+tCiOai2aSoIgz597UhmgiCSfELXAH5q90DIOcPlSVU0wV8oWHvW4DUbcpEvXZvMHTfoT/Y3h4GosE9qo46Ho08rGdty98GE4yniOQYUQx7Z7fUQJbAg+riSAABLCKkW9vGxlveeKg73fAUcejg0teUeE2kf+mhz3YBu+kOJahDUZLJQEV2ljWAkniwupQhoNPZbiz0gIIQof7bFaP3ZZfFE+tFoADPm8fZ6KILK SuQGjvm9 3cnczP5YDE8oq5nc6XUG+hDFaKEEbXTefRAMwT7VA3+nsfcAp4o2oydmO+CJb+YrOfS0HDrML3S+ITVRUPsapWZ1QYhPF9W2q8AFG88n7BDLI08KDzJnbX0eOMN65MDuguvkzqVvXzG0Xfah+8n8OJuwaJ7+KtEfkES/gU8RLGMmzfpTijYAsXji/enNb+XNDT+CZdRbaK9cGM4Jf8YA791WMxjLNa4fUO0fcb/D7Mau06qIgj6SIE+ztlJnsp4QQr3gm3Kz++IWfGVs0U8wGWZ+yoEh2LqwUXOQQJphsCpx/zPJNq3WPVsTMniXHzVYcp5u/1HH5jgveOXEGqDF6OUjcNFI1xdbENDizaLIGqrpP6snal1o0x+01nSkpDq/S/0V3stExbqa411j9I3aBBMyIjy7OPoaPoLIZNdhZp+xAUBclaWwGEpbjhf0dEkpeB70Tb9WpVAJXRTZfjflNUTeFhI2g4Hzc3Z4YIrDoCPtuMXkQxPgyHxcLzw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 18.06.25 15:05, Lance Yang wrote: > > > On 2025/6/18 18:18, David Hildenbrand wrote: >> On 18.06.25 11:52, Barry Song wrote: >>> On Wed, Jun 18, 2025 at 10:25 AM Lance Yang wrote: >>>> >>>> Hi all, >>>> >>>> Crazy, the per-VMA lock for madvise is an absolute game-changer ;) >>>> >>>> On 2025/6/17 21:38, Lorenzo Stoakes wrote: >>>> [...] >>>>> >>>>> On Sun, Jun 08, 2025 at 10:01:50AM +1200, Barry Song wrote: >>>>>> From: Barry Song >>>>>> >>>>>> Certain madvise operations, especially MADV_DONTNEED, occur far more >>>>>> frequently than other madvise options, particularly in native and Java >>>>>> heaps for dynamic memory management. >>>>>> >>>>>> Currently, the mmap_lock is always held during these operations, >>>>>> even when >>>>>> unnecessary. This causes lock contention and can lead to severe >>>>>> priority >>>>>> inversion, where low-priority threads—such as Android's >>>>>> HeapTaskDaemon— >>>>>> hold the lock and block higher-priority threads. >>>>>> >>>>>> This patch enables the use of per-VMA locks when the advised range >>>>>> lies >>>>>> entirely within a single VMA, avoiding the need for full VMA >>>>>> traversal. In >>>>>> practice, userspace heaps rarely issue MADV_DONTNEED across >>>>>> multiple VMAs. >>>>>> >>>>>> Tangquan’s testing shows that over 99.5% of memory reclaimed by >>>>>> Android >>>>>> benefits from this per-VMA lock optimization. After extended runtime, >>>>>> 217,735 madvise calls from HeapTaskDaemon used the per-VMA path, while >>>>>> only 1,231 fell back to mmap_lock. >>>>>> >>>>>> To simplify handling, the implementation falls back to the standard >>>>>> mmap_lock if userfaultfd is enabled on the VMA, avoiding the >>>>>> complexity of >>>>>> userfaultfd_remove(). >>>>>> >>>>>> Many thanks to Lorenzo's work[1] on: >>>>>> "Refactor the madvise() code to retain state about the locking mode >>>>>> utilised for traversing VMAs. >>>>>> >>>>>> Then use this mechanism to permit VMA locking to be done later in the >>>>>> madvise() logic and also to allow altering of the locking mode to >>>>>> permit >>>>>> falling back to an mmap read lock if required." >>>>>> >>>>>> One important point, as pointed out by Jann[2], is that >>>>>> untagged_addr_remote() requires holding mmap_lock. This is because >>>>>> address tagging on x86 and RISC-V is quite complex. >>>>>> >>>>>> Until untagged_addr_remote() becomes atomic—which seems unlikely in >>>>>> the near future—we cannot support per-VMA locks for remote processes. >>>>>> So for now, only local processes are supported. >>>> >>>> Just to put some numbers on it, I ran a micro-benchmark with 100 >>>> parallel threads, where each thread calls madvise() on its own 1GiB > > Correction: it uses 256MiB chunks per thread, not 1GiB ... > >>>> chunk of 64KiB mTHP-backed memory. The performance gain is huge: >>>> >>>> 1) MADV_DONTNEED saw its average time drop from 0.0508s to 0.0270s (~47% >>>> faster) >>>> 2) MADV_FREE     saw its average time drop from 0.3078s to 0.1095s (~64% >>>> faster) >>> >>> Thanks for the report, Lance. I assume your micro-benchmark includes some >>> explicit or implicit operations that may require mmap_write_lock(). >>> As  mmap_read_lock() only waits for writers and does not block other >>> mmap_read_lock() calls. >> >> The number rather indicate that one test was run with (m)THPs enabled >> and the other not? Just a thought. The locking overhead from my >> experience is not that significant. >> > > Both tests were run with 64KiB mTHP enabled on an Intel(R) Xeon(R) > Silver 4314 CPU. The micro-benchmark code is following: Ah, I missed the "100 threads" above. Yeah, there should be plenty of locking contention with all the mprotect() in there. -- Cheers, David / dhildenb