From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4B92C27C54 for ; Thu, 6 Jun 2024 18:04:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 33E3E6B00B2; Thu, 6 Jun 2024 14:04:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2ED046B00B3; Thu, 6 Jun 2024 14:04:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1DB966B00B7; Thu, 6 Jun 2024 14:04:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 010E06B00B2 for ; Thu, 6 Jun 2024 14:04:37 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 65E2A816F0 for ; Thu, 6 Jun 2024 18:04:37 +0000 (UTC) X-FDA: 82201238994.07.4061D7C Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf27.hostedemail.com (Postfix) with ESMTP id DE89340021 for ; Thu, 6 Jun 2024 18:04:34 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=nMgh7WM6; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf27.hostedemail.com: domain of "SRS0=54/E=NI=paulmck-ThinkPad-P17-Gen-1.home=paulmck@kernel.org" designates 145.40.73.55 as permitted sender) smtp.mailfrom="SRS0=54/E=NI=paulmck-ThinkPad-P17-Gen-1.home=paulmck@kernel.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717697075; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=6MXcm36X77+Hw8s4PJJbrxZEiV8rV2zfWmtyrZDGP0E=; b=JrAm2FX9W4SeDG54E9sHOv39wPEgZJhlFhPVBd4RLELp1WaoK+ih04sduhkJz/Y0PVxyAN S9PMKfEzP22Fi3ltaAtRRc7I45h4GM4YwEk4f6pgrbN/akYkYbfI3xJkHcVFtvUiAxSn9h VBYt4Wbv0Io+SsGIReeAlJXbpqNCwe8= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=nMgh7WM6; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf27.hostedemail.com: domain of "SRS0=54/E=NI=paulmck-ThinkPad-P17-Gen-1.home=paulmck@kernel.org" designates 145.40.73.55 as permitted sender) smtp.mailfrom="SRS0=54/E=NI=paulmck-ThinkPad-P17-Gen-1.home=paulmck@kernel.org" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717697075; a=rsa-sha256; cv=none; b=nHIazWUpmEllxXrlU8UXHYwjajriPOfLcqyjZH5B2VJYoGRXZzJMA4mnRVP0s4UyCDiSkz WIt5DzBYQZ/rb3PBJ1QWB+VZU0HS1fWqtI1jpvRVgb6qJBOkIE1dsLG6DkmIvM5WHxmTt3 +jsqdvGahk+27kKdrUZ7YVyTVqhwd1U= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 8244ACE1916; Thu, 6 Jun 2024 18:04:31 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C5D7BC2BD10; Thu, 6 Jun 2024 18:04:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1717697070; bh=HDd6OHePqDYE5PcHNs5uUuesJqWx2FNGOr7Pj6VmAxQ=; h=Date:From:To:Cc:Subject:Reply-To:References:In-Reply-To:From; b=nMgh7WM6GglV9bL4DSuANqJtT5P1tgI/lh3sVNg8ChLTC9tWCtZOVIkC83rdW+VFA qnEXnpx4+iLIs8tUdtXxkjEzWLpd2zLJbCbIXIat6yT9AnJZ7Yt2PEYXJL5N7w9Ryo M0EQhmRG2UYMCoFwdrYvt75GDP7LLq+JztY40t6yfMfmw0O6ff4vUgSvHjeFU+nFyt NXFz9UTXMSTzE7bXDEZwtx3QVux5z8yFl2n3h2i+0udiijoF54u4+VpHJpdY6YZCcT jNIEa47Mq/Bf64Zlm+ReFfcBXakWf1POVBcxgWxXEC6KmZsGbxls0kCvwPpQwiVgga OCW9VXD48/EcQ== Received: by paulmck-ThinkPad-P17-Gen-1.home (Postfix, from userid 1000) id 6F83DCE3F34; Thu, 6 Jun 2024 11:04:30 -0700 (PDT) Date: Thu, 6 Jun 2024 11:04:30 -0700 From: "Paul E. McKenney" To: Jan Beulich Cc: Naresh Kamboju , open list , linux-mm , lkft-triage@lists.linaro.org, Andrew Morton , Mike Rapoport , Dan Carpenter , Arnd Bergmann Subject: Re: x86: WARNING: at mm/memblock.c:1339 memblock_set_node - Usage of MAX_NUMNODES is deprecated. Use NUMA_NO_NODE instead Message-ID: Reply-To: paulmck@kernel.org References: <315d6873-d618-4126-b67a-de62502d7ee2@paulmck-laptop> <7d55b65e-331a-4ce2-8f72-d3c5c9e6eae0@suse.com> <20c484a5-d797-4782-b5b5-bea5fcae9284@paulmck-laptop> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20c484a5-d797-4782-b5b5-bea5fcae9284@paulmck-laptop> X-Rspamd-Queue-Id: DE89340021 X-Stat-Signature: hi6a68p7kq7ojmdocrq5ekmepi3nj957 X-Rspam-User: X-Rspamd-Server: rspam04 X-HE-Tag: 1717697074-789142 X-HE-Meta: U2FsdGVkX1/IQCSEZVh59Jm6vwFJtYWf9Et41JXg/9u3kqdUYH7CnQtlGWlxiXgGQA4mDR+nF0df93sqW1fhOIpOYLBl7CIz9O3lLPsC23yYgf7cZQYSLkLeWd/hNb82SYPvvfq59I9UqRRPj6qfiGbFSDLHm79/kUI36nZ2/m8g1yVoy4wAmhE3/tfNalB2SCT6PSrqQ3VFhX6qKLLwg29w4C15Jih2P/RrIMX/vlYozdsrqzqRqcRFL+iGIe7TaQXRIvBHY+k0WNVucy3tQgNePZMf0QJECfsGsC4kggZcLJFE/BnR+KZ73+P8OUnjj6QZ+49yQabpvN0+Eqee3FnS6syNsxJF7gtHknk16Q8iVil4vqZXQmPGoNGdNh5odiAXbvKb5b/XNjWviQQ3vlLiXfM0XLA8/x6KIvDmNCf22OP+oLoNvOFdIbW6JsQiqqqPlPsFE2qiC/a47MpRkF8CSsPc7wPbCrrfFhagVDT/0OQe+oT4CgKIEMWZ9nzSGQodYs/LCa73gCeVQN019OfN/t+yzh97LSrT6tBORtTQEADfun1tN4zZ9hFF/z0aBC8L+9e3uu0kuJK7CkhdQhdn1VmAlVNytt2AM/BejhAPh4kNT9oPO2/+zQEGs2Li8Tssi9HJZrmtPiq4D1d7QaDOrBbx4qIL0wIvyfC1giQQiJjYp3OjdcsY8/aATPFA3+gntfuZMm0xoD71gY1TZY/LrG0Orh6Qfr0IyLcWeOSg+JTicV8kOvqEaYtXszFwTVcDxLpxcTVaVW3fGMLZ6gIRxKLGiDAPOGc0Y2PDtyet0czqPqmkvf2FSC7a3omclnwFZN/X/jx3uy/vVb/5KdhBD1pgRaJ+wFHFYuDZT3ZB1wqx6C8OhCDki9DQpEnaF+4bcFjnLPR18ZOTZFY3QKjqxh8gGcVAw6p8X6WezVPkg1NUoDkPVzTBKSQdfrulCNW+zh24shXKYACRHDO j33b8qPp ilDTKalfaBeh0vzRLm/MHlT/Fralr5YHtAc75YVW7IENq6rfY5BT9ri4d2rcDbBsabAwrympPKtCBqsx2v3jIJUtOPAUOhcgo+xNT0j0QefNp/hwNNr+BJ8Au+TTDvxQTD9JPgbYTiUhX78CJjCSeYJrFa8QF6mM9Ahx2yRNRDO5hKWDkubngYxeAefDFS6ZQTUrgDrIR0jyB4nOLPpWrrvxv4CuEBnWNBXHBxMhsVWoUUWbOOR6Nrjetfjd2oyAGDOGJ6MjUclgxE1/Bl/wCc3HoCYQwIeON5ORUeyIuH5VUxRw2FXiooggCnl9SquTbPAJ2Ke2ybiUtXEFdigcf2SK8XxN2Q/LIGexpR3T6QCn1oCyeL2ui/mBjQaUlK/VeGyvCC+zqJSlYn45KCZsfGhbL8mq+aIYzw0r1mvt9XH658Khn/w76f/ryexICBtOjpQqFfAATarTonYMbfPBdqGgKf8JZunAqfSC+KXtUx3lsv3cxwNxXxauCfZXAe3XDjPfTOIRcmOB1+cDXAgLSsndOfp1rB7YgM5RYUVKLpNFb/Gao4NAi+PZEIdG7/0If1FVmO5cLLCFVnWVHmD5Q1w/0ghMQhKShEAy5mBIXqhMqWYLxy0B3EjIfOk/dGyDMKGUXbOOnN1Brm3scTeosHxbTVXetn7DoxiH3fqBDWeXoGI35ZKFLebhBw8bZ+NcRFj4K X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jun 06, 2024 at 07:19:40AM -0700, Paul E. McKenney wrote: > On Thu, Jun 06, 2024 at 08:13:17AM +0200, Jan Beulich wrote: > > On 05.06.2024 22:48, Paul E. McKenney wrote: > > > On Wed, Jun 05, 2024 at 09:46:37PM +0200, Jan Beulich wrote: > > >> On 05.06.2024 21:07, Paul E. McKenney wrote: > > >>> On Mon, Jun 03, 2024 at 07:19:21PM +0530, Naresh Kamboju wrote: > > >>>> The following kernel warnings are noticed on x86 devices while booting > > >>>> the Linux next-20240603 tag and looks like it is expected to warn users to > > >>>> use NUMA_NO_NODE instead. > > >>>> > > >>>> Usage of MAX_NUMNODES is deprecated. Use NUMA_NO_NODE instead > > >>>> > > >>>> The following config is enabled > > >>>> CONFIG_NUMA=y > > >>> > > >>> I am seeing this as well. Is the following commit premature? > > >>> > > >>> e0eec24e2e19 ("memblock: make memblock_set_node() also warn about use of MAX_NUMNODES") > > >>> > > >>> Maybe old ACPI tables and device trees need to catch up? > > >>> > > >>> Left to myself, I would simply remove the WARN_ON_ONCE() from the above > > >>> commit, but I would guess that there is a better way. > > >> > > >> Well, the warning is issued precisely to make clear that call > > >> sites need to change. A patch to do so for the two instances > > >> on x86 that I'm aware of is already pending maintainer approval. > > > > > > Could you please point me at that patch so that I can stop repeatedly > > > reproducing those two particular issues? > > > > https://lore.kernel.org/lkml/abadb736-a239-49e4-ab42-ace7acdd4278@suse.com/ > > Thank you, Jan! > > A quick initial test shows that this clears things up. I have started > a longer test to check for additional issues. But in the meantime > for the issues I was already seeing in the initial test: > > Tested-by: Paul E. McKenney And the longer test ran without errors as well, so again, thank you! Any chance of getting this into -next sooner rather than later? Thanx, Paul