From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1E6BC05027 for ; Thu, 2 Feb 2023 01:55:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3640A6B0087; Wed, 1 Feb 2023 20:55:21 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3141C6B0089; Wed, 1 Feb 2023 20:55:21 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 166936B008A; Wed, 1 Feb 2023 20:55:21 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 033CD6B0087 for ; Wed, 1 Feb 2023 20:55:21 -0500 (EST) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id A448E80E39 for ; Thu, 2 Feb 2023 01:55:20 +0000 (UTC) X-FDA: 80420684400.25.8D81691 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by imf06.hostedemail.com (Postfix) with ESMTP id C410E18000F for ; Thu, 2 Feb 2023 01:55:15 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=XkWJB1jh; spf=pass (imf06.hostedemail.com: domain of fengwei.yin@intel.com designates 134.134.136.100 as permitted sender) smtp.mailfrom=fengwei.yin@intel.com; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675302917; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Q0kURIEZNfbWZVUqzC7cqztubWymQWZRRmnh5Z8jZtA=; b=czNaXtUYY2+Fr6SblBQT1vftvLsJ5e+gDiF/G5C2+SiVl9YORZyaZN82rvlXTQy4aYYaKt RsySteQ8yEmz6F7vvhDZFBe2TowcMErb75YfryYSNUMBPeixhao+4cSfIUJs6GszR47VIA YtrREdSXe3quqhB4D7+sZh3znxCVQnU= ARC-Authentication-Results: i=2; imf06.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=XkWJB1jh; spf=pass (imf06.hostedemail.com: domain of fengwei.yin@intel.com designates 134.134.136.100 as permitted sender) smtp.mailfrom=fengwei.yin@intel.com; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1675302917; a=rsa-sha256; cv=fail; b=E3llBFCCAMR52aJPBZKYF8UPz8WGDlArkvw+CDtfYSsVgN2uduaWbZgb63Ia+OKgPUxLGd dzS+7ExZautAn763+KHTQKYwLYpqjOF8KHcsUKiPEYDC3zWZ85SbtO4ZjUHRGdrNyu4WBw SQ/GknJkrjqgX+bxbnMTcWwmUsVfN8s= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1675302915; x=1706838915; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=x6cd1Nkv5VfjQnXvBVlN4Ono0E5wc6Idvs3jVtNsViU=; b=XkWJB1jhuFQQ2YR7C6zziab8G2x19PChiV7mCprQc1dpm5aJGmv2KxNz uMy73mGYFURiNejwljdr/0dXgwPAtSNoG7mCEPxRewxp0f2mwGTH+Pwr+ ep+WBpSyhVobG1S0Eg2CGw2fOTfvKFUWY42YTetkj5jT/EzKYDbJbbXvi mJjs42E3sBamXC+Ij/wmq0VrT+Gj3bsY/UA48NhQjTEaoBgKTgCttgvTU eAda0KzOITVibDazhzMs1gb1xqKYyIc0Me1NxavZZ9OVNBRq++l5YGart F18faLorgjBA5RzlJLV93tcpeiMFvG4XXV6sbCUCatqiHM/NNLayCJdtF w==; X-IronPort-AV: E=McAfee;i="6500,9779,10608"; a="392906838" X-IronPort-AV: E=Sophos;i="5.97,266,1669104000"; d="scan'208";a="392906838" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Feb 2023 17:55:10 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10608"; a="728652722" X-IronPort-AV: E=Sophos;i="5.97,266,1669104000"; d="scan'208";a="728652722" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga008.fm.intel.com with ESMTP; 01 Feb 2023 17:55:10 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Wed, 1 Feb 2023 17:55:09 -0800 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Wed, 1 Feb 2023 17:55:09 -0800 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.47) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Wed, 1 Feb 2023 17:55:09 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LARlz4Mxg8sqmMxzfSBJ658PHVo4J5lOiCCEo+ZT7sqMZ/4ZVw5pGrS/lEig+5z0LgoWvbBRu2FxIxd5HNEEqDuJaFxsil+yZNnyBnenqxn9d2pXS13THGuTUCy0iPWqrlRGgdu9NDBCVmqdygtiPx4MNlz/4iZVSM+dmd0+EwWQVktnYXJAbXJPCZtjXCbGcUelj6Nqq33vb/ivjD9z73JbjjvsUs9rgOFcF8Fd0RtbBvWWKKN+g+6gFb1wPqhA+on+WKKskvV2bqucvwuFa0Wk2WbD29Gtm5YQBIm5Uw2XQANbqsMrv/31CW9MLqbs4rtOu7fr9JQUUSmuLwfjnA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Q0kURIEZNfbWZVUqzC7cqztubWymQWZRRmnh5Z8jZtA=; b=NIDTWELf1es+1+vud4vWQ9YtUr7LzJ9bv60Vnkdug0hXJNsd+Mj6lPL9yoYT8Syw17V3+ymwStsRZFeVLdWRwVM9MOu0KRBhTB2fLb/G6zi8x6VjDi2Eut86ZOWL3s3ZGJXuRlppgw9zBjjX/YvTVDeb8YqflXGln2qpIZyMG+m3LXEQNvpoGOr0DtURvmqoeBH8x8GLi+YN3wZ1xSAXUmW62PQ/ntg6AJlzwuprwj4JT38+q5SsdEsTM8FBZmGhoxc/GI6FsMswe/yJx/7hnxvMRN1L7HdqP+ay9VfZtncC0H0+wkZCJtgYkiy0Fy1g7gD1ZamrJxow5Up7oor7nA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from CO1PR11MB4820.namprd11.prod.outlook.com (2603:10b6:303:6f::8) by DM6PR11MB4593.namprd11.prod.outlook.com (2603:10b6:5:2a3::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.25; Thu, 2 Feb 2023 01:55:07 +0000 Received: from CO1PR11MB4820.namprd11.prod.outlook.com ([fe80::1531:707:dec4:68b4]) by CO1PR11MB4820.namprd11.prod.outlook.com ([fe80::1531:707:dec4:68b4%4]) with mapi id 15.20.6064.027; Thu, 2 Feb 2023 01:55:07 +0000 Message-ID: Date: Thu, 2 Feb 2023 09:54:58 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Firefox/102.0 Thunderbird/102.6.1 Subject: Re: [RFC PATCH v2 1/5] mm: Enable fault around for shared file page fault To: "Kirill A. Shutemov" CC: , , , , , References: <20230201081737.2330141-1-fengwei.yin@intel.com> <20230201081737.2330141-2-fengwei.yin@intel.com> <20230201143440.5mgy3x76wb32x3tr@box.shutemov.name> Content-Language: en-US From: "Yin, Fengwei" In-Reply-To: <20230201143440.5mgy3x76wb32x3tr@box.shutemov.name> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: SG2PR03CA0118.apcprd03.prod.outlook.com (2603:1096:4:91::22) To CO1PR11MB4820.namprd11.prod.outlook.com (2603:10b6:303:6f::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1PR11MB4820:EE_|DM6PR11MB4593:EE_ X-MS-Office365-Filtering-Correlation-Id: e97fed6f-fd70-4982-2a6f-08db04c08241 X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: mEqXpbuBYSJwv9DHK+jTKQd39vu5EaXsxhli3ApAnhX5utf1OJ0vzmiVl5ZEZmwvWIKLw+Q3mBVsdZrMrkaZwcg35hIcYnoedJq9Tu+/0P6u9bK9oUih8mWA3E0bWr47/cpv9Mey/slpDAL1s7/P19/zXvL9NsRfav4kw75sBtoRlLTx3kUmI02d3LFHp5fkDJF+GoyJHQEjgL7IYm7rko6xqRecZKGsr0FH7kvDe+2KcKzi8IAP3LXHOlDiu94BqwIy5ofquSvF/si+Vid6DhzKviNDR5ejNyMhoHF3NQvMqxJv/VAEYk1BClcyksl7NVc3FZGYheHKw3l6VdnM+bs9+hD8l13HvLUYgEBaQTws/NAdTrHXzm3Q/zFGsS8Gb/N5/1iQ/fHt1erHnA+hlYEFNUx1emQfgyqafIuxhdMMnjX60am/uPgs+maZTAhfcyxwCrkpQy10AQtuMxODsIDMuCxeqDBTY12UFdePWVMp7dkQ68F7ekTjAHzxLfj/z1mvugm697U5eb0sau6UrkPdIDf8RQ90zgqTicDZJJATNQ8qsuGFyDl8rpFr+JuQQkIp9meKohRutGV2XZXb5vAaq/Wg4a5JcOu373CoAh0EDmYsDjUyJl91pGmx7cydNkpuYGnchKfTUQVNr4l4akoy5XsEODm8n10GoAapmV3f27m2Ieh1OHtTrmCgDREm+mua0/QuVBDmxyQ2jXuXrPxMW00/fyzeqxmMz1CUJk4= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CO1PR11MB4820.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(366004)(396003)(136003)(39860400002)(376002)(346002)(451199018)(4326008)(66556008)(66946007)(66476007)(6916009)(82960400001)(41300700001)(8676002)(2616005)(8936002)(38100700002)(186003)(6512007)(26005)(53546011)(36756003)(6486002)(31696002)(478600001)(6506007)(107886003)(86362001)(31686004)(2906002)(316002)(6666004)(5660300002)(43740500002)(45980500001);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?STFwMUJNMjcvYmlOWGdjSk80b3NzNGRVRy9LcFpWOEVveWwwSGtTWitZbnpo?= =?utf-8?B?cGlmUDBoVUpWWTcrL3lYenM0Vk5qeUdWU2RaNU1UMTYxeDc4UDFRR1N5QjV6?= =?utf-8?B?akNFaE43cVp1Y0s2TlVKeGJ6OG9WNzhtM2xjR29wazJpdkdNMjdBTXZuSm1L?= =?utf-8?B?MlNhaUJNQllTWGJFa2lSOWtCSFhpTSs4VC8vZzdjazNqSng3Ny90ZS9KNjR2?= =?utf-8?B?dXN6QzlnYnRYMVFJWERjbXlYNmtiRFY2aXgxZUdXc0JlSTdLQ3NzU1RKQjhk?= =?utf-8?B?ZmxFY05wcEtTZFU4Y295TjJCZldEN05OdEF6OVJNQTlObVVwdTV1SWFxRDJB?= =?utf-8?B?OHhVUm9aalByM05Ec2RxV0I4WDJGdzFsdmVJaDdOdm5kM2trQlFmbzlwSWs4?= =?utf-8?B?U0lrQzVsSjc2UmV1anhJNjl6WXpJVmJuQ0QrSGljM1ljUEpyN004b2lBbDQz?= =?utf-8?B?ZkN1R2x1K3JPbkk2WkhpbjNpbEl1dGtnTlpCVHdJVk9JWnZpbXpVUGE3UXhy?= =?utf-8?B?SDdwNUxGTCt1Nms3Zk03MHpIdjJINGx2Yk92ZUtVM1dRSW9UWTdRV1VPRmRQ?= =?utf-8?B?Y2w0MkxuZ0F3MGp6OFc1N2F2S3V2ZVRpajdJVEhsS3FZaXRYR2Y0RXRIRFZU?= =?utf-8?B?RkgyTllLQjg2Ym94ZVpkZ1BwMW45WGVTOEFxOFdLdXRzOHRjVmxZMWhPc2cr?= =?utf-8?B?Q1NxbGYyMmt2Znp1VVNram9zcE9RVlJiSGlCR1cxQ054VldhbGFZU3JBQzVn?= =?utf-8?B?cjkxVGVXZEZhN0MwQ2FJY0psd2NBRGVjcEhleTVYZFlkSyszOU45NGtpZWUv?= =?utf-8?B?WjIxdkxjeXdmdWppOEY1RFZnYUUyOXBmendwU0FNblJiU0g0WEx3OElGWTN4?= =?utf-8?B?RTdwRlo3a0RhMk05cnZJUnhtRjFKcEZRdnFwNUk2aFdTRDVSeHZzNDliQ3RI?= =?utf-8?B?eHJjcWMzT0pJWXF5dWZBVE5vbnhBMWEvZkdPOUR5c05zZE9mVnZ0OTZNRmY5?= =?utf-8?B?YXRCazYzMEo2cEJaZHZ1Z3pMUkxUeVBRSFdsVyszS04wc2ZhL2VMSVQ2N0Q3?= =?utf-8?B?akRJNjBROEpDVTMwRlpwb3FqSzhxQXBHWUpwb2pvZnptdXk1K3ZYQ3cwU1Yz?= =?utf-8?B?N0JldGV2NnpTM3hpM2dlRVdmWFVjRk9aSWRMekU4VVJKUHdXOXU0bVNDV1N5?= =?utf-8?B?K09PbnBXajJvYmxDa3RQNklqWDVSSXJ1OG1lMDhNUVNncElRb3RjaDdpNzhM?= =?utf-8?B?bmJuS1lTaEdJNERRRDVuZUtUWFVJV1pYeUNiWGtGQ3UvT2R2USt2c2xWL2JC?= =?utf-8?B?dEUzQ25LYXVvTlRFYkIwazh0bXF1Ykl6b2xXWlpJUkkzbTUvRDlKeUcwdy8y?= =?utf-8?B?L2xLMEVMd3d5d1RnM2xoRGN3S1NEamZsaHl2T0dIZlUrL1hEeTkwQjc3TVBQ?= =?utf-8?B?MTRrY01uRUU0K3pQTkhMYzRIMUpYNHJKL2VLSi96VEFwVzlMVFM2Y3NUUHpN?= =?utf-8?B?Z3N5eWRQcHVtU0doMDBpV2dkZ3dGdXhkcmllSjJkKzlndlNkd09RR3lOQ05W?= =?utf-8?B?d3JGL3dqZjNCQlpaRGRJQWNubGZLcUZLU2J1VjNSY3k0eG5NNVM3VStMR1Na?= =?utf-8?B?WUw0WGpvd0hVRjlJVXNtb2pTNnVHUGwrT3hHellNNFl1ZmRlMmhuR1F3WkE0?= =?utf-8?B?UHFQaHRYSDFEQUp2VU5ad0lBN2M2WHlneUM4OGxHL2ZSSFBIWXpHWHRpNVdP?= =?utf-8?B?T2ZXdDVWWG42am5zS2x1NlVTRDhwWHYzM3pjME5QYWcwV2hRM1ZqVytFc3N1?= =?utf-8?B?amh5ZXIvYVVLUmFhb1lyYmtDUmtiQ1VHMzZrNytmT2F4Wkt5cWl0VmU0cXl5?= =?utf-8?B?OXdORStVTDJSOG5PalVJMmk0VHFlc1Z3UHA0TlFwcE1QNDN4bDJlUlg5cG5T?= =?utf-8?B?RU9TTjFibTl0NUN4eUt1dVpkdHBvTWpWSlBDYnNnTlplaFREcmVCUFJ5TUxu?= =?utf-8?B?V25PNXltYVBncnJkQjl1TngrZ1Ztb09RazZzeDFJV2dWUnhzMk9veVZSY3Vr?= =?utf-8?B?OXVBZVp3WHIzZ1FZRENjWVp3bE8xK0VaSFdicGNQVGtpMjRvRTk0d214SjRH?= =?utf-8?B?MC9YaUVyMUs3ekZqUmtMcXlFUXROT0hjTE4rOHJ6U0xja3JDRS9jc0h4S2tv?= =?utf-8?B?U3c9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: e97fed6f-fd70-4982-2a6f-08db04c08241 X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4820.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Feb 2023 01:55:07.2502 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: q8Dh2lPY/pqqNNTOZNSLnebq0v7D4Jh14jRz3N3q4R6rP8xP7E0C82nOaZg7vsATKkz3BkHpkR2Cp8sEa1Dzgg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4593 X-OriginatorOrg: intel.com X-Rspamd-Queue-Id: C410E18000F X-Stat-Signature: p4365iwdyic78qeayd7n3chhaxeymmow X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1675302915-92976 X-HE-Meta: U2FsdGVkX19pQNVRvs4ry3yXrpQ+mc1iImdsZzSiAF/3fTqMv+WY7/S/sBOoMCrU2W5w1/p369hBWFygNAsrn6rO2eBgwPJ6F7USi+wwi6Tv5QBzaStgQivFlxuGfzm2IP+QAiMrWUBakWwwWhL3pyAVQT8S5aai+UB1L0xw8EWtzV0M+5nQytFbkvid6YMAib2Zh0rSg/BZM/MRfqPrz60LFvFykXllgtVGvelt2/RSn/LZaz7k4rZvOZ9+1sZPl0iO6712gEgpKAy3SGN3KUzzFAmJatagBfbNTCpQDv+/wykIVvd7f8lNZa5NzEzEPxqnEhyj6DDK5GdXDx4T43M4GEkjvHa2UDZjscSCt4C9qA4OAIBSTAuhNqzCdcUewsx/iKhXyR9vb1AaMd8CElOBmXr7f1aFaKu/EA3Wrl1dmxEj/TYvpe3FAilgeJniA+EcZHZm5vSvT3rjw2QWPcvuoHaXbc2A3cbMJ6tmLCCVVpN6z5HFI0L/aaSXAYEeKmlyB5fjGtoQQMCa91lqcttoXF6eyxwnokOIqEBGfvcC0mSPQ4xKnHcxiYTD9iaoKKnwwzV6G7FKnU3z/MG7hRdbn7PTtYK/lHEF0xWoBvjhuCDOv8BZgdgvbeXNhm7xfoob6jxtB6m/w4DYTu0dT6el50SOxaYEmukCxdEOVfPXJH46S3wqjh0gJ6MknG+OWAnHs0RGJoh6pGO/QtLxmT8/PyR2Mq41pmaNCpmmpeOAS/HF0upqjbX0RvDxHnYelDfL37MLJ1D++Wt5Hf8/xC9hOWYnYw0UUT9Mvt05/7HPx2GUa1WGaYm22xJjXJ9ueuEgl8OZOS4ADB5VgRpJke768V5qfATs/g9xOVmhHnTe14urP5hPEgfJwOVWpQ13mOAeWRdqJWXaPnDbpgLJt6GXqfMHvUrU0WZB8rmYPHLdyhabltMuZ8XdKL8G/eGWHyGjRtiDiMke4z/sDzB wLYTzTIe YITcSELBEjEQZZSA0Q0c7ceyGxtPDhhAt5W6sQw73jV+GYZOa8FVapJ8Uc/pqEMP+V6wS0RGjJnGHAR7v7F/K8dwLOqd+fcO0pT6JLJPQQdrWqj9SSySPqSZWK3nLZP/Rk3JJPeNLVyT7w1I8N33antg13j8zG0mjBk2X2Srh3m80eLHZZ7jzF9Y2fO8jvs+S1SCywO1jollTrDCDZNtt8N7YyQpvgrp/nrPqPZoKvfaaUZtlDwoYod/Sx9PTqcAvexZtzfclQ93VWuO1fQ4Cd2zQ0i/1xF8+8/tWuYFy5I4TU7rqx4QietBKTh2eAPnV4bBhclrFLzhwZx5R5WMTtVdITkF13Fkdwp7pmM7ZetRAs9n2sXY9ayjZ6ej2e5x3FqjX X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2/1/2023 10:34 PM, Kirill A. Shutemov wrote: > On Wed, Feb 01, 2023 at 04:17:33PM +0800, Yin Fengwei wrote: >> The shared fault handler can also benefit from fault-around. While it >> is uncommon to write to MAP_SHARED files, applications that do will see >> a huge benefit with will-it-scale:page_fault3 (shared file write fault) >> improving by 375%. >> >> Signed-off-by: Yin Fengwei >> Reviewed-by: Matthew Wilcox (Oracle) >> --- >> mm/memory.c | 11 +++++++++++ >> 1 file changed, 11 insertions(+) >> >> diff --git a/mm/memory.c b/mm/memory.c >> index 7a04a1130ec1..51c04bb60724 100644 >> --- a/mm/memory.c >> +++ b/mm/memory.c >> @@ -4546,6 +4546,17 @@ static vm_fault_t do_shared_fault(struct vm_fault *vmf) >> struct vm_area_struct *vma = vmf->vma; >> vm_fault_t ret, tmp; >> >> + /* >> + * Let's call ->map_pages() first and use ->fault() as fallback >> + * if page by the offset is not ready to be mapped (cold cache or >> + * something). >> + */ >> + if (should_fault_around(vmf)) { >> + ret = do_fault_around(vmf); >> + if (ret) >> + return ret; >> + } >> + > > I believe it bypasses ->page_mkwrite() completely, no? > > So you get a writable PTEs without notifying the filesystem. Smells like a > data loss. Yes. You are right. This may be the reason why fault around is not enabled for shared file write fault? I will drop this patch. Thanks. Regards Yin, Fengwei > >> ret = __do_fault(vmf); >> if (unlikely(ret & (VM_FAULT_ERROR | VM_FAULT_NOPAGE | VM_FAULT_RETRY))) >> return ret; >> -- >> 2.30.2 >> >> >