From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A1FCEB64DD for ; Fri, 11 Aug 2023 15:32:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CA4DE6B0072; Fri, 11 Aug 2023 11:32:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C55896B0074; Fri, 11 Aug 2023 11:32:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B1CF36B0078; Fri, 11 Aug 2023 11:32:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 9FBD76B0072 for ; Fri, 11 Aug 2023 11:32:47 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 6AC6AC11E1 for ; Fri, 11 Aug 2023 15:32:47 +0000 (UTC) X-FDA: 81112216374.04.B6E8767 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf26.hostedemail.com (Postfix) with ESMTP id 2CEF1140024 for ; Fri, 11 Aug 2023 15:32:43 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=WKT2ASdz; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf26.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1691767964; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=KoDQPpSBax1LLhCBa7z0nPjBBUXe32UXUur+MUFne6M=; b=d5sST29U4SEy4jDf46KpoZKGg7E0EFyr19wsQvsPNBToodoAAXaRR2SjuQeOcWvLJ84VPU 4ElZDeFui+m9JOLxGT3aBVK6wO9vwQkd3WYGisMJhYJdCObV05u05nIp/yc/69w9/g+yUh oFMK3U3i3/fyWFdbF/wR/hREsFucinY= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=WKT2ASdz; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf26.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1691767964; a=rsa-sha256; cv=none; b=BBKbDhqWKO9irsTWxDxIUbUVQmozM5ayQNpzc2qkPWcerUTDH+mTUEy9KtVmGojR8jcDyl czYVTJYq51BwOhJX6padZj7CFp+uBxjt2UeRLjFLW+D1LEE6agXiFyKKpU8x6gmYylMh0C lwIZPXAI43aFvzVDQG/MvIEfen2nAt4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1691767963; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KoDQPpSBax1LLhCBa7z0nPjBBUXe32UXUur+MUFne6M=; b=WKT2ASdzgjYjIeSXEY9VvMLZNbJqHEpY/6/lID7AquyW2mSYTS6WQqnyazEKWgn0FJE7di wHzJw/TYHkX7lQzLsDPfnlLIiNKyFVvKOlhXew68AkBiVoRf1CgdWNywuXlz3wzscpYGEY YUS9eDt/A6OFZz7a0cKBWCn5O34mSIc= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-688-A0ezbBjxMUKt_3q_fftqJw-1; Fri, 11 Aug 2023 11:32:40 -0400 X-MC-Unique: A0ezbBjxMUKt_3q_fftqJw-1 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-3f42bcef2acso12849435e9.2 for ; Fri, 11 Aug 2023 08:32:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691767959; x=1692372759; h=content-transfer-encoding:in-reply-to:subject:organization:from :references:cc:to:content-language:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=KoDQPpSBax1LLhCBa7z0nPjBBUXe32UXUur+MUFne6M=; b=eVL9YuZ+n5A6o6cq1fpcW9XIjpDOGEltqOtPg9TdDMAETmLsq7FDqzDrDye5KoJtl7 aE5gbr0+bf1zuCowFDVeBrOc5HJPFR2e/gy2MCXrAgHfzY4ZWmq+a68wk43JlqN56DaR bwMlTgQarHzPYHYJ0FMuG5F3z2R2ouPUNEsDDcK7TN/Tk5gj4K8kMgsUrSgwAILeQSwq oLhYTJg5fkTHUAI+ck/KUwwzJWooOIKazd4GO+i1DYllxy0btHnR7jMClg4OrokbTzs8 tWHezHTg/xob3h+uQ07YAcDYefVhZeQvCwrP/nzqzOUqZ0KPQxqWBl1vEKg41Xzxa9sH 5Yvg== X-Gm-Message-State: AOJu0Yw+7qCNwyAlMSXeslggqolyIQsiDU505A3LxVCgiEx9KVb9eAOS Lc6QzxK1w92oOVwdYyJvGfSKPwb5IcH0G8uv5X/Q6GqKEhVaKdmbABzUQWI3YaCJGLSNqpZwdrT EkUq3SEVBDsg= X-Received: by 2002:a05:600c:218:b0:3fb:b5dc:dab1 with SMTP id 24-20020a05600c021800b003fbb5dcdab1mr1936907wmi.39.1691767959738; Fri, 11 Aug 2023 08:32:39 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF0EQWQte4L/bLxPKHwjW9vvzlkJLxja3udxYBIo62C9T+VFPb8pcxrqoMMS3wLa3JyEqeDNQ== X-Received: by 2002:a05:600c:218:b0:3fb:b5dc:dab1 with SMTP id 24-20020a05600c021800b003fbb5dcdab1mr1936889wmi.39.1691767959410; Fri, 11 Aug 2023 08:32:39 -0700 (PDT) Received: from ?IPV6:2003:cb:c71a:3000:973c:c367:3012:8b20? (p200300cbc71a3000973cc36730128b20.dip0.t-ipconnect.de. [2003:cb:c71a:3000:973c:c367:3012:8b20]) by smtp.gmail.com with ESMTPSA id f1-20020a5d6641000000b00314367cf43asm5762156wrw.106.2023.08.11.08.32.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 11 Aug 2023 08:32:38 -0700 (PDT) Message-ID: Date: Fri, 11 Aug 2023 17:32:37 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 To: Peter Xu Cc: Matthew Wilcox , Ryan Roberts , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-doc@vger.kernel.org, Andrew Morton , Jonathan Corbet , Mike Kravetz , Hugh Dickins , Yin Fengwei , Yang Shi , Zi Yan References: <20230809083256.699513-1-david@redhat.com> <155bd03e-b75c-4d2d-a89d-a12271ada71b@arm.com> <8222bf8f-6b99-58f4-92cc-44113b151d14@redhat.com> From: David Hildenbrand Organization: Red Hat Subject: Re: [PATCH mm-unstable v1] mm: add a total mapcount for large folios In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 2CEF1140024 X-Stat-Signature: 37pfuyyanbobkf9gi5isy35es6ua9sd7 X-HE-Tag: 1691767963-380210 X-HE-Meta: U2FsdGVkX1+FePhWBluf6A42/bf65u9EkTlbcaCY2qzW9FClP2HWLio5Ps4x+zo3LVSSt/EFdOGVbmjXFHbg52xYoBYlpXT3a+jZ4/bqIIAgbiTBBIOFQpAer0qLvYEZe4WYP08vnRLW6tNU16t4wrASqb3RVT2sjiQIMFifgTRDydFy8koBVg1UupnQ70EQa70/LfTf3vT/896xkEKzOX4m4ULCQLVTIw8O8NK1fsVKpulTFds+xbxeSYurq8CRdlA6r54ynsniNra2FKkBFpZjIVmIVTiL9s/tf4mkAsdWKWjkBUhp/5oKvluWOz1+GPrLKXZaHFkskb77TkiwrrQOrDIVxVCeSeqTWLc2Urwkvh0Uq+87h06mkPRpbhu3/y3bWDmQ+pB57uak11GeOkAOXlCPNcQECwWcaTKcsO6HhUlkoEPSz+nI5qe4JoykcaWAUsxrjb6+bVCGq/7elgtFoOxFGyESXQvDKThYAhV3sYMUIy7x42mRN9OUzND8Q02KFhuCLCQRqBnqPZB3FbsmtoO/XnBcrg17pjpttNLvyjphhHomW3oW6i6ZoGDxmgNLTuo5o4OchHuW2t59OIZKVkCi3+yi/rinCK8D/RDF777XDCqxdrT+5Np2bCopnd12oTi1gMW7CbvpFHjrsU/oi0s7l3ZtDtnSWPfsU4JQ+jNX6/l+oQc3b6E2sGua7Tb9SWE1U13Tx87O55wjKDu95epN+j9KD9oqRQ5+588TXZaWX/cZQoSxxd4YHecXQlBqObfxH/cElLdcmB4amyeE5/M/Ir4+cMsHiXBB+Jog8OU8XH7D4jj76CMIm/puY4vogf85MZ6EAx32qL+OaVolLH3Cb7cKwYZ7MpRspKNvReJcF34fh1I+9pUmZAPXS9VRO5Ybv1mSCgnZ6uP0j9kkirFwpwC33+DSF0gK1XmvSlR9yg0eB8q/3GME01RMbYkDJSRaKvkK2AfW8p/ b8kRkYle vJc9FzXywZTPU25D6UklC9REAR4oVx+4CaENPYYeb6x6FoGhp7T45gOr5N/OTNf2YMUFf0+CTxtGFMeMildI6AO/L5ggffBtDCQETSOie6hNmFt6iq7mRrJsZL1E1Bj3x2e6XHZKKbIjQ1qLIlpSa43QJwjWNTb50LlaNgypcoqQ/OwU2orhU32pMRpXTe3LDtb7889gF2x1DFbplk2gitSiEnDfvktYIDsLInH7Xp379CunBxyTKGnafRYh4sRpOKWZlzc94GV/JW5IVql6wr7Y9gbmrsIj5N6N/jkzein2wzuXrbUw/Ls8VQyW7XaeOGpOriHUcyikSgpmSIllFCWVR+BQLNSVJ9xeNSQhbB9kRkM8Qm5PDLgMOYVgXaKV2eJ5z X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 11.08.23 17:18, Peter Xu wrote: > On Fri, Aug 11, 2023 at 12:27:13AM +0200, David Hildenbrand wrote: >> On 10.08.23 23:48, Matthew Wilcox wrote: >>> On Thu, Aug 10, 2023 at 04:57:11PM -0400, Peter Xu wrote: >>>> AFAICS if that patch was all correct (while I'm not yet sure..), you can >>>> actually fit your new total mapcount field into page 1 so even avoid the >>>> extra cacheline access. You can have a look: the trick is refcount for >>>> tail page 1 is still seems to be free on 32 bits (if that was your worry >>>> before). Then it'll be very nice if to keep Hugh's counter all in tail 1. >>> >>> No, refcount must be 0 on all tail pages. We rely on this in many places >>> in the MM. >> >> Very right. > > Obviously I could have missed this in the past.. can I ask for an example > explaining why refcount will be referenced before knowing it's a head? I think the issue is, when coming from a PFN walker (or GUP-fast), you might see "oh, this is a folio, let's lookup the head page". And you do that. Then, you try taking a reference on that head page. (see try_get_folio()). But as you didn't hold a reference on the folio yet, it can happily get freed + repurposed in the meantime, so maybe it's not a head page anymore. So if the field would get reused for something else, grabbing a reference would corrupt whatever is now stored in there. -- Cheers, David / dhildenb