From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D512FE77184 for ; Fri, 20 Dec 2024 02:35:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 29AC16B007B; Thu, 19 Dec 2024 21:35:57 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 24BE26B0083; Thu, 19 Dec 2024 21:35:57 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 113806B0085; Thu, 19 Dec 2024 21:35:57 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id E71E76B007B for ; Thu, 19 Dec 2024 21:35:56 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 60E6843B6F for ; Fri, 20 Dec 2024 02:35:56 +0000 (UTC) X-FDA: 82913770926.27.4A838E9 Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189]) by imf16.hostedemail.com (Postfix) with ESMTP id 8283B180006 for ; Fri, 20 Dec 2024 02:35:18 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=none; spf=pass (imf16.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.189 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1734662132; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=P/0GUpHU9S+Xsn0Jsf2Mr4QLiKhAcd2g46S4KVfN0i0=; b=quTyTHZ58aywp7mmoLRpil2iNlwZTKGe2thG8urQeH7VHxNCJJNmF56oKrF2hcNpywmcDW tTco603SuxNF907TLAx+lj4faOTjn2jgq/1nufp48c3M5IOWAskkKXdzg7Za7eCASm77ER PK8HE3Hu+MBmi2Ctvq3BPCsO0MLjy2c= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1734662132; a=rsa-sha256; cv=none; b=DNmExg47nBvnvS9ebyOWDYW/Yp1p6OaZv0xzIJONVABCw6mTybt/hO6OcGkv4REjbgaEzL PALePebhgfeD+v9UdYPw0V8bY6e8Grft7BMF+q4XbPY6fOpBLgu61Ltk+LoDrSMuF4eUas FRLcVXA/jxaQYIRvP+lH4441riQJ6XE= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=none; spf=pass (imf16.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.189 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com Received: from mail.maildlp.com (unknown [172.19.163.174]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4YDs1G46LpzRjvS; Fri, 20 Dec 2024 10:33:54 +0800 (CST) Received: from kwepemd200019.china.huawei.com (unknown [7.221.188.193]) by mail.maildlp.com (Postfix) with ESMTPS id 01ABC1400DD; Fri, 20 Dec 2024 10:35:49 +0800 (CST) Received: from [10.173.127.72] (10.173.127.72) by kwepemd200019.china.huawei.com (7.221.188.193) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Fri, 20 Dec 2024 10:35:48 +0800 Subject: Re: [PATCH v2] mm/memory-failure: fix VM_BUG_ON_PAGE(PagePoisoned(page)) when unpoison memory To: David Hildenbrand , CC: , , , Dan Williams References: <20241219115209.574065-1-linmiaohe@huawei.com> <06a45f8a-0981-40a2-a12a-5964fcdace13@redhat.com> From: Miaohe Lin Message-ID: Date: Fri, 20 Dec 2024 10:35:47 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <06a45f8a-0981-40a2-a12a-5964fcdace13@redhat.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 8bit X-Originating-IP: [10.173.127.72] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To kwepemd200019.china.huawei.com (7.221.188.193) X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 8283B180006 X-Stat-Signature: zqn6zakx8z3d64jrjescuekwat5um3qy X-Rspam-User: X-HE-Tag: 1734662118-638247 X-HE-Meta: U2FsdGVkX18FiLu6MAyxkKGaR99RX0oCl7F6pwnUcFUdE2siv0qb6YcKk9yHad8TYbtMaHnvGQ1Wa7pDVrWDFuwyfR0+S54QtCstAvezTZ0a5x232ntsLBhVVzFWu3xVDUtyfkzEPIOukTfkfIpj6g69bZKwiSt7BmOANx/u5r2yFuGJ05B0THsjtcRTYp33UIbaq63QFRFmPftgd1lcmuSKI52f/USlEGJZnlLIh/Kb9ijvrYEDPqhKyPWWA3tTG9ifzrAGhvd0N9CEDTYLxII/my837y77nDl1WcnF8PGeytMaQjTxOeNPp/TP4RZq4gh016M6lCwrIPENR2LOebbkjyidRQ1NUGXXyOTYohDySVjScEo2wfuNyW5ik4mHAM/Pnq/7QKbEQbFuzU05elXOu6l//cfmXvULRHetBf76zZU+NC0UVf0gRz1zCFi7TRlkmzcGavoszWGCIE2NEkYTkDHunRpUGZiAEjKTtk1JPILwdbeQB+Q+Sqt5qRGKQcdhUZOIDkmTxEk6nKW7cPddWIBg/zniDZoB7uCqS7X/JApwCLLLMK4QHy5kfgufEy8FROi9JHUx6Q0klEC09hgjP65nCmU22M1TyaP2w2vOnYYwKZ/EswxYzN3kunKYRfqydPvb5g5xRg3Ggp3xgk02yGedQIp51Z2hwCP0n4v4cqT7Krj7gldJ2nDnxnvyLTcqYR6dY7SOPDILkGHPZ4VNNiaAgumoevP6wxwLMP5/oHmHB9ohRNxfDFGH0qhFBkvbfBnxyn2b1p5oSdaLZoOdG0sfdVEvVNtJUs1KoI4c5zCKABAHzJ4P/uv6kvh+F7SBE36ortZ8W48VHpbsP+Au4f93Fq8WuRMM5eMUhCocVUHTkp0MNkpgLKo5/52R+FF40SzA5NZ86oHDdueuMk/70SVR1OYkoczNE9m7RYXjdRNXbRmK66riZOWHpQ2B8fVNk/xse/PiglsvnYP PLaVBbiv F+/5yf/WFfUJP4p9E0IuKuh3Dkec3Gmlnjeh9hWulONy665fH7vXOhkemcOpn5Sox3pcMF21/4UfO3uj+YD5nYZl+NZiNGpSiq4jKixcVzzbEX7Bu7U4T1koIQFxMnmiweHMr7AwHBYXqxA2pp6uPx0a+BhfdLALownwxPY+V5y44SbA/41PQzU3ONcdxRfa2QTDNOUbCilaZ87o2e5GJNyYqX/vzsMO1QwTvosc45R1+L07S+L+UingKuCq/QYiTsPMuHbdCjWbihJvUyu0oahuOUB0dy5X3SufEurBzPPX/pJo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/12/19 20:18, David Hildenbrand wrote: > On 19.12.24 12:52, Miaohe Lin wrote: >> When I did memory failure tests recently, below panic occurs: >> >> page dumped because: VM_BUG_ON_PAGE(PagePoisoned(page)) >> kernel BUG at include/linux/page-flags.h:616! >> Oops: invalid opcode: 0000 [#1] PREEMPT SMP NOPTI >> CPU: 3 PID: 720 Comm: bash Not tainted 6.10.0-rc1-00195-g148743902568 #40 >> RIP: 0010:unpoison_memory+0x2f3/0x590 >> RSP: 0018:ffffa57fc8787d60 EFLAGS: 00000246 >> RAX: 0000000000000037 RBX: 0000000000000009 RCX: ffff9be25fcdc9c8 >> RDX: 0000000000000000 RSI: 0000000000000027 RDI: ffff9be25fcdc9c0 >> RBP: 0000000000300000 R08: ffffffffb4956f88 R09: 0000000000009ffb >> R10: 0000000000000284 R11: ffffffffb4926fa0 R12: ffffe6b00c000000 >> R13: ffff9bdb453dfd00 R14: 0000000000000000 R15: fffffffffffffffe >> FS:  00007f08f04e4740(0000) GS:ffff9be25fcc0000(0000) knlGS:0000000000000000 >> CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033 >> CR2: 0000564787a30410 CR3: 000000010d4e2000 CR4: 00000000000006f0 >> Call Trace: >>   >>   unpoison_memory+0x2f3/0x590 >>   simple_attr_write_xsigned.constprop.0.isra.0+0xb3/0x110 >>   debugfs_attr_write+0x42/0x60 >>   full_proxy_write+0x5b/0x80 >>   vfs_write+0xd5/0x540 >>   ksys_write+0x64/0xe0 >>   do_syscall_64+0xb9/0x1d0 >>   entry_SYSCALL_64_after_hwframe+0x77/0x7f >> RIP: 0033:0x7f08f0314887 >> RSP: 002b:00007ffece710078 EFLAGS: 00000246 ORIG_RAX: 0000000000000001 >> RAX: ffffffffffffffda RBX: 0000000000000009 RCX: 00007f08f0314887 >> RDX: 0000000000000009 RSI: 0000564787a30410 RDI: 0000000000000001 >> RBP: 0000564787a30410 R08: 000000000000fefe R09: 000000007fffffff >> R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000009 >> R13: 00007f08f041b780 R14: 00007f08f0417600 R15: 00007f08f0416a00 >>   >> Modules linked in: hwpoison_inject >> ---[ end trace 0000000000000000 ]--- >> RIP: 0010:unpoison_memory+0x2f3/0x590 >> RSP: 0018:ffffa57fc8787d60 EFLAGS: 00000246 >> RAX: 0000000000000037 RBX: 0000000000000009 RCX: ffff9be25fcdc9c8 >> RDX: 0000000000000000 RSI: 0000000000000027 RDI: ffff9be25fcdc9c0 >> RBP: 0000000000300000 R08: ffffffffb4956f88 R09: 0000000000009ffb >> R10: 0000000000000284 R11: ffffffffb4926fa0 R12: ffffe6b00c000000 >> R13: ffff9bdb453dfd00 R14: 0000000000000000 R15: fffffffffffffffe >> FS:  00007f08f04e4740(0000) GS:ffff9be25fcc0000(0000) knlGS:0000000000000000 >> CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033 >> CR2: 0000564787a30410 CR3: 000000010d4e2000 CR4: 00000000000006f0 >> Kernel panic - not syncing: Fatal exception >> Kernel Offset: 0x31c00000 from 0xffffffff81000000 (relocation range: 0xffffffff80000000-0xffffffffbfffffff) >> ---[ end Kernel panic - not syncing: Fatal exception ]--- >> >> The root cause is that unpoison_memory() tries to check the PG_HWPoison >> flags of an uninitialized page. So VM_BUG_ON_PAGE(PagePoisoned(page)) is >> triggered. This can be reproduced by below steps: >> 1.Offline memory block: >>   echo offline > /sys/devices/system/memory/memory12/state >> 2.Get offlined memory pfn: >>   page-types -b n -rlN >> 3.Write pfn to unpoison-pfn >>   echo > /sys/kernel/debug/hwpoison/unpoison-pfn >> >> Signed-off-by: Miaohe Lin >> --- >> v2: Use pfn_to_online_page per David. Thanks. >> --- >>   mm/memory-failure.c | 14 +++++++++++--- >>   1 file changed, 11 insertions(+), 3 deletions(-) >> >> diff --git a/mm/memory-failure.c b/mm/memory-failure.c >> index a7b8ccd29b6f..02be0596ce67 100644 >> --- a/mm/memory-failure.c >> +++ b/mm/memory-failure.c >> @@ -2556,10 +2556,18 @@ int unpoison_memory(unsigned long pfn) >>       static DEFINE_RATELIMIT_STATE(unpoison_rs, DEFAULT_RATELIMIT_INTERVAL, >>                       DEFAULT_RATELIMIT_BURST); >>   -    if (!pfn_valid(pfn)) >> -        return -ENXIO; >> +    p = pfn_to_online_page(pfn); >> +    if (!p) { >> +        struct dev_pagemap *pgmap; >>   -    p = pfn_to_page(pfn); >> +        if (!pfn_valid(pfn)) >> +            return -ENXIO; >> +        pgmap = get_dev_pagemap(pfn, NULL); >> +        if (!pgmap) >> +            return -ENXIO; >> +        put_dev_pagemap(pgmap); >> +        p = pfn_to_page(pfn); >> +    } > > Hm, I wonder if we can do anything reasonable with ZONE_DEVICE pages here? All I can see in unpoison_memory() is folio_test_clear_hwpoison() for ZONE_DEVICE pages. > > CCing Dan, maybe he knows if this interface used to do something reasonable with ZONE_DEVICE pages. > > Also, I'm not sure about using the page after doing the put_dev_pagemap(). Likely we would have to do that at the before exiting from this function. IMHO, the page can be used after doing put_dev_pagemap(). The page should still be available while it has HWPoison set. Or are you worrying about memory offline? That might not be the scope of this problem. But I might be miss something. Thanks. .