From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 975CCC4332F for ; Wed, 1 Nov 2023 09:41:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 22E598D0034; Wed, 1 Nov 2023 05:41:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1BAAA8D0001; Wed, 1 Nov 2023 05:41:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0319D8D0034; Wed, 1 Nov 2023 05:41:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id D59628D0001 for ; Wed, 1 Nov 2023 05:41:49 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id AF0B3B5A9F for ; Wed, 1 Nov 2023 09:41:49 +0000 (UTC) X-FDA: 81408893538.29.45631DB Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf09.hostedemail.com (Postfix) with ESMTP id CBB0F140012 for ; Wed, 1 Nov 2023 09:41:47 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=mATHxiyl; spf=pass (imf09.hostedemail.com: domain of mhocko@suse.com designates 195.135.220.28 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1698831708; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=gNzKW+x1c0UZzbPukaEOwSLPVJ3mDtKgT9KmOp+APUs=; b=pui45ySp394WdEeEchfNg1RRNnON1pDNYwjy01TFs6G4j4flXfjwCIdhk8YuxVQCz4Xvi4 gipdg6iDfPXyl83HU13vaZCAgndIMDWPB+UPQGIfKMjRTbl3pN0kUaZ4fmQoZze4Xjghhh l/SKja2zYzF+GJxYjQu7wAlt2Sy/vNg= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1698831708; a=rsa-sha256; cv=none; b=tuBQOuIGLgio8hrR3FpOB+b8dGFZ/rPMyuhZk7Ypj9M5VkJVriU5r/aBaIrAAxYfXnFyuV ATwpE9Xy7z2No8aS5HyuN0rF7fEPuHza6IZAagNtBXPpld+7AOeFuku/NrZC1OIbkroB25 OSAVQePLXB/waNdpU2nk3KOsPMJGhAQ= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=mATHxiyl; spf=pass (imf09.hostedemail.com: domain of mhocko@suse.com designates 195.135.220.28 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 35A9E21A34; Wed, 1 Nov 2023 09:41:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1698831706; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=gNzKW+x1c0UZzbPukaEOwSLPVJ3mDtKgT9KmOp+APUs=; b=mATHxiyl0jyzlQq1mEMQ1Vf9cG7e8R78/0Fg62j2oA5mxSItZFmh+/2+y/MO0xxPhK7If8 1NU2e1kMm0UsMXYdbehYvMYQa4Ugff/Vxvghqsv6zUabsZ929/4TUaOwcex51GQ9UbxOZO sJQlpgZZ6t7pvksUd25n1OoZLxCNkiM= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 0FB8013460; Wed, 1 Nov 2023 09:41:46 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id PRrnAFodQmU9DAAAMHmgww (envelope-from ); Wed, 01 Nov 2023 09:41:46 +0000 Date: Wed, 1 Nov 2023 10:41:45 +0100 From: Michal Hocko To: Charan Teja Kalla Cc: Pavan Kondeti , akpm@linux-foundation.org, mgorman@techsingularity.net, david@redhat.com, vbabka@suse.cz, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: page_alloc: unreserve highatomic page blocks before oom Message-ID: References: <1698669590-3193-1-git-send-email-quic_charante@quicinc.com> <2a0d2dd8-562c-fec7-e3ac-0bd955643e16@quicinc.com> <37c58833-1953-42c3-98c6-ee0ac75508ce@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Stat-Signature: kio3sijpsycoi59pxtxe4hg1nsddirpr X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: CBB0F140012 X-Rspam-User: X-HE-Tag: 1698831707-187819 X-HE-Meta: U2FsdGVkX1+BOY/LqYoxNVVIAJ8haaChqqjF2288zDXFAnnpocv9bTZH7ad1/KoAgoxSzWzm3OFsoDmy3A7c2ipmxFahdhNhjbueyZdrKm/nPBT5pR7PYhXPgam5IsXwDWNjO8IKg/QeO2qFzaJGMkbdW1Futtafosqp1E0/leDpcXH+prkJ4D1oqClZJO1BbT4NR0dh2RQ63rsAZmqQ+BwS1bj8CfyLy0JNBm2TRks/JWKOmL0SqNXKaBG84YvSw0fzqI92YXMc4INBpXKzubam5D4eqBYcc6oZr78BzrSjpgKMYo41Uw1yzA/5VREjlNfbC3RnLLV35H/m4DcesPw/P358wDxxXQrcmRq3r+IhFKo6sYNgCxA3M1HDFWA/pMg5LmA7BBCXbydHagus8pyT/MLYPCAm6o4YghfQ7NTTl5scOrL4UOEMx4i4jf2UYDKsfnZcJkM7lGWx1qp7RCKT/14973GPW9BAfd24UTOSehWwuST/lELfcaS2LTG6vrlQTPL4HB/3QzHe43gBs7WjHG4TD1e9N4BBNTVJpa5pPOXd1ToXZJTwXD/cWCOj2u/TPkuuRo2hhtadLUiJVzUazIMaFxLWhFM6vELgGPOvGrOWakWOXEhvDHEv7Kpo95pEha+X3/BGMqCfioKzj/s78UHC7akCsQ0tBLbMhJ3Nxsc50l0bmoMsRAMp0VvcEqYuldzbey4DdQJND2zV5ywj8EqoIR56bM+OYt/X+CiaeAw+yQAaLU/81RtMhWBxsCwGa9GOACa2lZAZT13RRYpbLiCPCgnkHBtUgJIvRODQDyZg6HCljdWDMc7pW8kolj3zjErDbtUxC+clXc7QMgLaoBTF0/rZUKvUzH0Uil6nnQ4jcN3THdDV60vCHxhnFesIxTOrUR+CJWJOFO8rIJY+GU0oTfcvKwe4SOL/LQ9BwXoiVC8+hsXdAfI6P2ExdXA3riwNKmOH1W9pq9R Dbf7iv8V +xZlz+3C2eJ/VDRyfKrKy7Yh9t716l/2KbH8jM5whdU/cOfdmp6DloC99c6EdwL7B6cmpEPW+BO9vBOsPGsUD/NSfMiBxKVKVObkeWfuf/2KuxcF0oRCMAYXiJBM3k7+8sbU7agaNLtYFEHnw2Nwiqpk684iV8HZtv9wsZPcCO6adhxlb/92HgkwESfOSlOa0HCTb0dVMyEC6IuZNXTUmS3MMSdJnIgqabWTBdOlMVUPy1a4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed 01-11-23 12:23:24, Charan Teja Kalla wrote: [...] > > Also, add below Fixes tag if it makes sense. > > > > Fixes: 04c8716f7b00 ("mm: try to exhaust highatomic reserve before the OOM") > I should be adding this. I do not think this Fixes tag is really correct. 04c8716f7b00 was rather an incomplete fix than something that has caused this situation. I think we would need to reference the commit which adds highatomic reserves. -- Michal Hocko SUSE Labs