From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85B6DD3C92D for ; Sun, 20 Oct 2024 19:16:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DB6C96B007B; Sun, 20 Oct 2024 15:16:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D66ED6B0082; Sun, 20 Oct 2024 15:16:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C55216B0083; Sun, 20 Oct 2024 15:16:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id AE3996B007B for ; Sun, 20 Oct 2024 15:16:18 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id AD509AC340 for ; Sun, 20 Oct 2024 19:15:49 +0000 (UTC) X-FDA: 82694936016.24.0762429 Received: from out-178.mta0.migadu.com (out-178.mta0.migadu.com [91.218.175.178]) by imf22.hostedemail.com (Postfix) with ESMTP id B0C48C000A for ; Sun, 20 Oct 2024 19:15:59 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=s0y8yF6A; spf=pass (imf22.hostedemail.com: domain of kent.overstreet@linux.dev designates 91.218.175.178 as permitted sender) smtp.mailfrom=kent.overstreet@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729451628; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=QsqXAYXQDUiVX9tYvJluW0Iklg/6NIBwGb+7FHIrNzg=; b=JGEe47oBDgua3BrvhDnM1q1pvvE0rEFzcFP0YJUKaQEyTqh/5dwdyb9VfmheRYvS856/7K 77DKHTIVXGzaVOXZc9oW3/BSjNVdWXfEEj/LNNA9HOKRTWnXl3qplAlWmz0HSc7uo505Md SD2R39iCODWr7oUjuG964ahHJSPLMFg= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729451628; a=rsa-sha256; cv=none; b=mQiJPfs+hbCKEvHF23eF+V+HFWZ9Dw2pfpDztrGjwAZZpvxbdaM9BY1UF5+uOsTkVgjfXL eXKNXDRcPQ4ZsiGigURNIvx7W/yuqV9FavJ7ms3hZ6VYJTFsGAJu20uMr6rXU/eYM1AGte MsThJgwXJ5nIDFhfTLXMgG7gm61twsI= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=s0y8yF6A; spf=pass (imf22.hostedemail.com: domain of kent.overstreet@linux.dev designates 91.218.175.178 as permitted sender) smtp.mailfrom=kent.overstreet@linux.dev; dmarc=pass (policy=none) header.from=linux.dev Date: Sun, 20 Oct 2024 15:16:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1729451774; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=QsqXAYXQDUiVX9tYvJluW0Iklg/6NIBwGb+7FHIrNzg=; b=s0y8yF6AgV6/HIHieLpA7WU+r5SpcjI8tHmg04ycg6b2hsp7R0njH5muHd9Wy7ray8mRa3 Efwilt9QovtEVbd0Zy31MJRiLA78lp0SHxNzBxmdBGTcKAZfBbVyq1YWQ47ZC33HWcl1ux 8I8u0C4Tg2phQruMQKiojkSG6NYwggg= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Kent Overstreet To: Linus Torvalds Cc: Lorenzo Stoakes , linux-bcachefs@vger.kernel.org, linux-mm@kvack.org, Vlastimil Babka , Andrew Morton , Uladzislau Rezki , Christoph Hellwig Subject: Re: [PATCH] mm: Drop INT_MAX limit from kvmalloc() Message-ID: References: <20241019210037.146825-1-kent.overstreet@linux.dev> <90bc0794-4cab-415f-a442-4af85a32eed8@lucifer.local> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Migadu-Flow: FLOW_OUT X-Rspamd-Queue-Id: B0C48C000A X-Stat-Signature: ju4b85u17rmcf71zrumh9a7pznxwf5zy X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1729451759-940693 X-HE-Meta: U2FsdGVkX1+1tnhEn1Q6oIaFWKBHuXHB4u5A+489+qFvVRf5oyaiQQ/C01hSRQbwlt8+rLmKnQEH9865rRy422RpBLQq90R2c8vjDC5bd8wlzfc9UspNDL0bvN5jxMzZ2f1Cl+64oLaulK+T3UCrYaLb3ShlWg3Ih3BTXxMD9BICbMQYZgKcTUMDdq2VgrLezks7TTnK7YCGie8IDRqSt7HogVjvzsjqsAQ+xHkP+yVo7zd6MVfE+727Lw2mU4MwfveZWfWWAHkn7C/0Uu5m8h/2aoJ0s5vPcDnPvbDD5M5t+SiJQcoFomoRIJso16kHse7qBYxJdq/CpYlIniVvuFWu/0LPHdcHpX7Slb42gt0qxYx6Nrg5dsQf+m6FL0CkRoZQL5Us/RfsAKnCQ9PBvMmYVViB6m0Ok9UBqiuhSTjDN2ewJd3LhNYkGiZp/BRj4w2CH7ZnJQC0NbS6FpS2TNKFIJPFO27nRdaqt3eHlHRVvTJ9HFnqH2mjdSagUu0M7ZCplGdF2eSGT10kf6ASHbuTZQh1nAgucd6ygcPxzrdBickp+u4axletVu4oYUjZ24YsrF8gQ78HfSxvJVB6m2Gk/3G9UbsZRZadZaSunN2xd6HAeQZAo6ys8LGST9nxoSwDq06C26lmgqwFbxy4Hib9CnzLx7cxXbJZWtVByovL+R4Z7eKGB0rwi3vJfH/kdjKiIG9g4ztWwM+/HX2qiWmuTMkdbTYecOfK1y3ue1l8hA5evLlkKvf+E1hLx8OIWlfQ9SuO0/mFE/hf88MP+c5zV11YUlO1/ynxI4GTGMaAWRRxvRRc9e9AUpJH4pX2E1awipfdrDrfeTlHR5jUXL19kotOJlfq1uTGgFL6uMW3G6JQvfdPyVCGKlWKaA3CHrPfUI+eGw98fe5SlVel5vFFb3sOd5ljuFW5+n8ckktF3MeAxouz/hyqWkwf+UZite/gR7l9uHUAv7SGf8K bRO+PoO6 dS+EmaDLUDaHgH+jIxlJWFUIkwmkpNgFNpR77sIV5xi0E2PlGhTXzQ2LEkBNAAni/oVjnMN1Igxfx3FJn3CNKCkl0a18RMNn1pdKFtlS4QrAv/iUiNgWM/TK/uNp8tHSyI2GPeWvQOWRiYqd3xB3brI41OF3IRzQ4nP/Klzq80t4bYllr25ubytSY7zm+L0Pxlxk1SiMsug8DhfI2VZ/CmbOHqzdGNqXh5eno64H/pQLbtHiFprU+wFcOrQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sun, Oct 20, 2024 at 12:09:58PM -0700, Linus Torvalds wrote: > On Sun, 20 Oct 2024 at 12:09, Linus Torvalds > wrote: > > > > How about you limit the amount of memory you use in the first place instead? > > .. and to clarify: we're not making other parts of the kernel less > robust because *you* are doing something stupid and odd. Except, vmalloc() already behaves this way - so it seems to me you already have. I've already added a stupid workaround to the darray code to switch to calling vmalloc() directly, when necessary; this patch was a courtesy because if bcachefs is hitting this limit no doubt other things will be soon as well.