From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 798FFC48BC4 for ; Fri, 16 Feb 2024 17:04:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E12918D0006; Fri, 16 Feb 2024 12:04:04 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id DC2168D0002; Fri, 16 Feb 2024 12:04:04 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CB11C8D0006; Fri, 16 Feb 2024 12:04:04 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id BA48F8D0002 for ; Fri, 16 Feb 2024 12:04:04 -0500 (EST) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 85D7A801E5 for ; Fri, 16 Feb 2024 17:04:04 +0000 (UTC) X-FDA: 81798289608.20.CCC053C Received: from out-176.mta0.migadu.com (out-176.mta0.migadu.com [91.218.175.176]) by imf15.hostedemail.com (Postfix) with ESMTP id AD7BDA0009 for ; Fri, 16 Feb 2024 17:04:01 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=Sfqp2+ZZ; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf15.hostedemail.com: domain of kent.overstreet@linux.dev designates 91.218.175.176 as permitted sender) smtp.mailfrom=kent.overstreet@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708103042; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=HmJQIqc4/OgO89xq5HkfBIYteF7nE9kIo+o5Vkmf1w0=; b=J/awHaUWGY0Ixph3QHvQFiB7OubGYgcrR61HWmNxN8r3xbp9BB8PRfkUPcQgAkUoiuuO+N ILBc+I53JTRSggVq3dxRlE6GaRWRiI6dS67itE0xx4IUOo99iPSss3K2iHW5aQWrzGL42j wH+ME7ZUoYLyAhwUS+jKj4i4g3I41j4= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=Sfqp2+ZZ; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf15.hostedemail.com: domain of kent.overstreet@linux.dev designates 91.218.175.176 as permitted sender) smtp.mailfrom=kent.overstreet@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708103042; a=rsa-sha256; cv=none; b=rYcigaOP/QK7qGQearOdeeXy1hYsrOElPyu0S6+aja1x4htaORfhBIb2sg3aT5rtSTRsy7 QqRsN+PYFNCAxkxckc9RbPBKEznoc5TZy2sEkJKc5uy7icoeRf4P3vdmJFNlF3u20FfS76 GIVQuzZZtQBwjolxF0KpE8trAiXOTEc= Date: Fri, 16 Feb 2024 12:03:49 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1708103039; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=HmJQIqc4/OgO89xq5HkfBIYteF7nE9kIo+o5Vkmf1w0=; b=Sfqp2+ZZDoruaTeHE15NGTvQrR4vxcPG9Isnojl94qpEL7wBG/AIUx9L8x2ZzdD04C4Xko QKE1GYS1wRReUz51hBdQZagUBBoyBvwAx04UnSHcQ28MYep/Re3HUavlqnV7CN74fW6Hzt L4hhIlJhg7UCheW4IzGJzoMdLrgkDvs= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Kent Overstreet To: Vlastimil Babka Cc: Suren Baghdasaryan , akpm@linux-foundation.org, mhocko@suse.com, hannes@cmpxchg.org, roman.gushchin@linux.dev, mgorman@suse.de, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, corbet@lwn.net, void@manifault.com, peterz@infradead.org, juri.lelli@redhat.com, catalin.marinas@arm.com, will@kernel.org, arnd@arndb.de, tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com, x86@kernel.org, peterx@redhat.com, david@redhat.com, axboe@kernel.dk, mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, dennis@kernel.org, tj@kernel.org, muchun.song@linux.dev, rppt@kernel.org, paulmck@kernel.org, pasha.tatashin@soleen.com, yosryahmed@google.com, yuzhao@google.com, dhowells@redhat.com, hughd@google.com, andreyknvl@gmail.com, keescook@chromium.org, ndesaulniers@google.com, vvvvvv@google.com, gregkh@linuxfoundation.org, ebiggers@google.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, 42.hyeyoo@gmail.com, glider@google.com, elver@google.com, dvyukov@google.com, shakeelb@google.com, songmuchun@bytedance.com, jbaron@akamai.com, rientjes@google.com, minchan@google.com, kaleshsingh@google.com, kernel-team@android.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux.dev, linux-arch@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, kasan-dev@googlegroups.com, cgroups@vger.kernel.org Subject: Re: [PATCH v3 22/35] mm/slab: enable slab allocation tagging for kmalloc and friends Message-ID: References: <20240212213922.783301-1-surenb@google.com> <20240212213922.783301-23-surenb@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Migadu-Flow: FLOW_OUT X-Rspamd-Queue-Id: AD7BDA0009 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: 86iw36rm6ibcuxcxjpr6p4oox59io4uj X-HE-Tag: 1708103041-929017 X-HE-Meta: U2FsdGVkX18Xb/ADFlu9EConHRexdwsomV2RSfGdFMuiHPcW6cAZiqe0fJRBtU9pKVNgvYstjMTg7FDpIPXUnpppEhwvEGQmbbxNTm3/wRe3+zsa8hb83052dEWYXz9vHPmRxgx9xT+JZEOHiupd1XABu1TRQ/PLsgp9fqovFoHgwjI6NKcdpLJ+GCmPe5KShQiFH0kIwZnbM6lfTo6AADiNVUmxQy/+QN2f2cMR6JZEW8pkxfATs6tc+ScF5blWSzgW/SkkMqX1PxMeSD8l0jBZZkrBvT23JvKz6pwg5c222CqeN2FbHYbwLVM1rPCsW2DphSCr1F1WkQDB/ufQSF9+o6lIJnIiQUtCt9pXXUmndH9EFeWo9EDcy4DeMStj9CiTvLvQWCWwboCeRX/vKggtFeIIWS/FvEMT89Gu1CckviLS4VWoJTAC6DWFqIfyr/P7GPP0Xn7qP389eaXvMo2FaTV+UEZp+QzQGzQ5ou252ax/QMUFSvkA1Tj7StKabjlMg8H9E0is8Uh/Jr6wAU5jsxpGg4ujOVg1zF2MLkv04xwcaV91Ywq1rgygGPmg5QSjKyp4BwWuzE5X2Zobcu6qKHlP/ihg/rJ6XgvjyslQigdFztXBojrYzknOld7VuJN9EHITjU7VyFWa7Qq9Z1Vinojazw+DnzapKYg4BhgtmaNHkXytx1Q/5b+FSe+cWKh0H9HQOSZmf3+wUwg3gPpEDcfJaDnlVxoplhuEFoRrVrfP2h2OZtPDf/nwuDMw98lBF9wUxm78E3zWxbKfcSj9wCgIMMM2ukm2PwBck87heO+ezPO1y+/rzxd1SlHWM+kVgktG1lp6px6tlcLGN8gz6U7eHc4K7Yz+z52o3U8LmyeLT38uYr0ZPg6D4G5K9agWu+FoaJS8k1hZhKBHUi7afjCrSUJpZL6JE0V+M5lzikywfDO/U+WKHUGXQaMo9/TL5As47AzRabXtcei bogaL6Ek SA+TKZAe+D+FQcTOuttjPeAb54eU/+SpDCegd8QMZrX9PBuPYWrYuQUEDjL1VkFi4Ek2j7oXnVR3Y90XTTIFc5sVn9ZUoxvOdocuEzlGtK25yUb01dqhVhM/dNd5jUjixweMDWae+36etDrkj5LcuQNmtcMhKVzPVEtRiv58cp2TbL3Bby4fLHHdyZg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Feb 16, 2024 at 05:52:34PM +0100, Vlastimil Babka wrote: > On 2/12/24 22:39, Suren Baghdasaryan wrote: > > Redefine kmalloc, krealloc, kzalloc, kcalloc, etc. to record allocations > > and deallocations done by these functions. > > > > Signed-off-by: Suren Baghdasaryan > > Co-developed-by: Kent Overstreet > > Signed-off-by: Kent Overstreet > > > > -} > > +#define kvmalloc(_size, _flags) kvmalloc_node(_size, _flags, NUMA_NO_NODE) > > +#define kvzalloc(_size, _flags) kvmalloc(_size, _flags|__GFP_ZERO) > > > > -static inline __alloc_size(1, 2) void *kvmalloc_array(size_t n, size_t size, gfp_t flags) > > This has __alloc_size(1, 2) > > > -{ > > - size_t bytes; > > - > > - if (unlikely(check_mul_overflow(n, size, &bytes))) > > - return NULL; > > +#define kvzalloc_node(_size, _flags, _node) kvmalloc_node(_size, _flags|__GFP_ZERO, _node) > > > > - return kvmalloc(bytes, flags); > > -} > > +#define kvmalloc_array(_n, _size, _flags) \ > > +({ \ > > + size_t _bytes; \ > > + \ > > + !check_mul_overflow(_n, _size, &_bytes) ? kvmalloc(_bytes, _flags) : NULL; \ > > +}) > > But with the calculation now done in a macro, that's gone? > > > -static inline __alloc_size(1, 2) void *kvcalloc(size_t n, size_t size, gfp_t flags) > > Same here... > > > -{ > > - return kvmalloc_array(n, size, flags | __GFP_ZERO); > > -} > > +#define kvcalloc(_n, _size, _flags) kvmalloc_array(_n, _size, _flags|__GFP_ZERO) > > ... transitively? > > But that's for Kees to review, I'm just not sure if he missed it or it's fine. I think this is something we want to keep - we'll fix it