From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03DCBC36010 for ; Mon, 7 Apr 2025 15:25:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 171CF280001; Mon, 7 Apr 2025 11:25:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 121BC6B0011; Mon, 7 Apr 2025 11:25:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F050F280001; Mon, 7 Apr 2025 11:25:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id D09046B000C for ; Mon, 7 Apr 2025 11:25:21 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id A9CFA59A6E for ; Mon, 7 Apr 2025 15:25:21 +0000 (UTC) X-FDA: 83307621642.15.D889682 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) by imf09.hostedemail.com (Postfix) with ESMTP id B068A140012 for ; Mon, 7 Apr 2025 15:25:19 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=MHuiMRgZ; spf=pass (imf09.hostedemail.com: domain of mkoutny@suse.com designates 209.85.128.41 as permitted sender) smtp.mailfrom=mkoutny@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744039519; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=rBI/ctOg6rttQTImP8b9T2x38eCYUNV1RiePYdYKl88=; b=fMi/Qa89BmTP0DOMYMvRzPlir4JJMqa38MnKK+Nlh75EsWs0uKgqawee4GJmB7UNIj2IYo nBRkiUijlDq3dsYly/pv17PeVkDqnYss5brevtkWVQ3mf9KhNgmBEb1l7xIqdajmBTzyek D3hxwKQn/rOJRFofFuN5FrblcOOTFGo= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=MHuiMRgZ; spf=pass (imf09.hostedemail.com: domain of mkoutny@suse.com designates 209.85.128.41 as permitted sender) smtp.mailfrom=mkoutny@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744039519; a=rsa-sha256; cv=none; b=DhPAtL0Kkx0YOJJEiqHAFzdPKXZ1Men2aoQZ0kMZWp3ZewoVreng6njcDwkQtCJx/9YxBK cbZcKIcQuIIhrjy6itwtiwG0pVpuh9Jo5jIYq8I61TonyBWlJ6HUhDlAGMJsb+LP4UaSKa IxE+jKkeRtdhvtgwpHjOMcBk853Ctt4= Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-43cf06eabdaso42031125e9.2 for ; Mon, 07 Apr 2025 08:25:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1744039518; x=1744644318; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=rBI/ctOg6rttQTImP8b9T2x38eCYUNV1RiePYdYKl88=; b=MHuiMRgZx/b6t/B5Punt3LvHoTxAZgRYH9LoqnzOW/yjRBMhzTSthB5R2yStFceWtK gWenk0kMOAWgZPkyYpLNZd97MfLxa8RZImEPhPZYv4OfnD1AciG7vFttymARKVdWfBfc 8Bij+DNUHQWw3QEWYjVeJww0PrAc4WYSymvnyMNLb4nOaDEGY8tQ2EJJ9Xh1bDkG9LvM 6BGBPiuEEAimqOxjISHq5RHXd5SYQYEVK7+a1z+wkGW5tP0crBVD2q5wmjPf0+oOU0nL lYGOB19BHSoh82znE4gJZSNrd5XnR5jMcyk3Fr13PqrzizSdv6nUFnuCbgjcPSSPyPmb OigQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744039518; x=1744644318; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=rBI/ctOg6rttQTImP8b9T2x38eCYUNV1RiePYdYKl88=; b=uKDRIR5D607RoSfmIKhyk998VJ9FnOZzIA2yiOVRFJ1yp//KqjRVe7fnkvtn8Z/+iu M+WQRQbJZbkR5Fdk2S+99ukfUFS1eZisZS0CrsJ4B0FWnRITRIWw3kE1O8S8wtY6NdNG 23iE7FljZ1EshozjlXe7DG/KBOpo/vmrcTURTgBSnfDdKULtOWh/Y5bzpKkpkrDtajwo Cu7oXSpIpq1rqPVYKrTRih+rd+bElJdVBRD+pKPk9WeZjMHJVYHlCYDJt7krADi9G6qG ThOQZwqwlGpW6T4DERoONBmOgHzxIbbBiQpirBwVt5U5rCdBsZ+pEzijEjRUW5ydiZ5c mjuA== X-Forwarded-Encrypted: i=1; AJvYcCXPPN4p07VqNMGXw+9YQ/nH/mZjcvXYJ1PKpAWneReHEdxbuaf8FMPVI1RQRe0Wklo/xYR7jVYliA==@kvack.org X-Gm-Message-State: AOJu0YycwBXuyE7XTjsAKZfeF6rjOmu07cUWa2UnjLXPKkOe48xKPOZS 86nOgP9qAvtpt73M43ZhGn+ySfVMl7Ze2d4DCif1X73Kryjxm7dPWM/PZsnh6kY= X-Gm-Gg: ASbGncuzzXT3kLMVNlAqUSDmyf456exJgSkuNfmhDi7u8NqoeMEuJxmAlQ7d8dFiPMt KpHsR1B+P3dRrN7JYmtPXPZC4fQNL2Hur8eKFPHGng3q1mRvQPYH2JCs5rV2LM0kNcb3t6uGfDy gt0WfZ8kC2NM1K5iGCv5ym8WV58mOdoP/TOobuTY6Qta1qnsPRAiT/aH5M4uiQTOvRlJxwgSokc 5DFq9GbDCq7NSSjoWr4jqiqu1NxOZsVdkzJqdzOGPBaLkiKy0fdNV5BTmlSeWV8h6foqTIIaX6R 2KkZTSLBq/StzkRUgOiuGDsAlAHSrT+/y+hCueGhPjMLpQS6dCbadlX3gg== X-Google-Smtp-Source: AGHT+IEuUH3J67sjhqDoixk/QkJ0y0B2AA37FiOvvQzo5BNHB8IYmL/PuWEwjrbhfyj5yQcGP3H1UA== X-Received: by 2002:a05:600c:3b08:b0:43d:b85:1831 with SMTP id 5b1f17b1804b1-43ecf585cacmr129997875e9.0.1744039518078; Mon, 07 Apr 2025 08:25:18 -0700 (PDT) Received: from blackdock.suse.cz ([193.86.92.181]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43ec34be2ffsm132570725e9.22.2025.04.07.08.25.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Apr 2025 08:25:17 -0700 (PDT) Date: Mon, 7 Apr 2025 17:25:15 +0200 From: Michal =?utf-8?Q?Koutn=C3=BD?= To: Waiman Long Cc: Johannes Weiner , Michal Hocko , Roman Gushchin , Shakeel Butt , Muchun Song , Andrew Morton , Tejun Heo , Shuah Khan , linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH v4 1/2] mm/vmscan: Skip memcg with !usage in shrink_node_memcgs() Message-ID: References: <20250407014159.1291785-1-longman@redhat.com> <20250407014159.1291785-2-longman@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="lu3xupyh5hd532gg" Content-Disposition: inline In-Reply-To: <20250407014159.1291785-2-longman@redhat.com> X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: B068A140012 X-Stat-Signature: 7jjp1nb471jeuhco43dqx4tp9onu7ymq X-HE-Tag: 1744039519-151623 X-HE-Meta: U2FsdGVkX198WnIW/cuqutDcEZSKkDkoVH0Z1iJBjYzXBkcOBrDGMqgb9YUIETi7FdcdpAS3coD1xCsM/Yi9OenEAu+xMVC3B2ftrEqAwO6OrjEW0hcmlRdSZ9pVXR6gPcviH1eZoxJSopucFzLDJH6U0IqOUTLeDdD5ZjRLvXhCPa0TGX//KDc3smqnkqBmWF8nSWy6Am3k2NpTZSyr5LFYbxj44poijlu/02yzvQ0GfuPVyvvaRk30SfSomdddSq8Qzjm8sGhdKERvjJ5jpdknwl8XoiFtBIXLB/QaWz2n6SNo477PLgxPt7KoJ2DAIExoWDokVxgUGYj2UQLFT8W4iGa+TCV81/Zss3KuW4d7ssmWAZcOxClxEZe8/IEEDcSoJv1OylEvy2jaXLa0RuRikFWR6og6sAZbUC6htN/jQg5LK866+0YVGb/3oKKY4cB9iBiNXdELaY87jqrVlwGZKu/4/M+IYl9Rt0aZTqsjF5eXJmHFPKv6bjWyf/EYxk9avIYwRS8JPuk5dRkWboGJPMf/GhP3406bSx3EOCfMp8kI2W9uUnhmBQQcpo1xxIuRSM8yuA035TqgLTmmYYbh9xSXGDX0bMigZMDZtK1RfFSHtRgsXkmO+8uvN7gIL4mleD/81v9bIVogpVw61MxHUIrphhanvG1/l0LIYondPHOwae064QWaWQHxM6oxEHGEiUQLuZcBKZDXd9QTXCv8E/3bR/+lIpio6p/nJXmv4y3O1UBSaqlmYqgLRQVO8A7yn5wArtxavYBglOs3zNbzjjSZVOmn+DS6SQf7LhvQxJ1R0RoBwKAetgFfi7fjVIXGqPugU+LSMsKCzEjdENeaJ7tzzxgbCKbMUgfUOXqJ70KikZwt7mUsZXPsq+sYEnrYH9xUj3VwDZ7C3nvpeknkC9QbOXh2tPrNFDgPcPyGbxIbfmfcKhLvI3q870xSiF8gZiSoz25gFwu7olk NhfpomD6 SvZ1NESPR10qv2XxG3D/nqPc8khdJudHj5l8MYcxV6OTFEnDXqairNZjUJcR1GbcC1GaktmjOr+rcQ9FydGYRRy8FaOwBRnCkojnslVC+ayeHf/QC6YMDPLePA6AOwE2y5vAUaL/UYGuv95Pml7gp9YZYel5YP3Ju5DI0DlPkYrTRaKPrfhe80ncbkDI6yC7VUNl1pmNCrWBRqKmyeB0pc3Pgr7yDMiXcPACfVpJlgDiDk8Ioly+kcgOzrx6LuJRUd1vqAwKC9QClKPcvbSUYumjHwWVCW0cC8emJS7YjmS/+H/mky+GRWXDuBfuUVw/kXcWUZ6neo4srEBI97mcab8LK97S/qp9Lu3JDeqcfiN+7PQBeCxj7AP+J88CFQp75eKfuOFtqPgCX4VC98wWDWQsGBqJS7M3agNaYQsI8Fmfyb2C8JX6IGmfX/Yf7RhtYuRuNHZVQp6fcaWCFf7MinUvnOA3EgjSMKw0hMA8jOxwLh/M3UnB6UPa0p3ZILoE6cA5jHFGZberbjJ4M4X+X7JNXmO85R+ONxMopzJo0oLnRpvg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: --lu3xupyh5hd532gg Content-Type: text/plain; protected-headers=v1; charset=us-ascii Content-Disposition: inline Subject: Re: [PATCH v4 1/2] mm/vmscan: Skip memcg with !usage in shrink_node_memcgs() MIME-Version: 1.0 Hi Waiman. On Sun, Apr 06, 2025 at 09:41:58PM -0400, Waiman Long wrote: ... > diff --git a/tools/testing/selftests/cgroup/test_memcontrol.c b/tools/testing/selftests/cgroup/test_memcontrol.c > index 16f5d74ae762..bab826b6b7b0 100644 > --- a/tools/testing/selftests/cgroup/test_memcontrol.c > +++ b/tools/testing/selftests/cgroup/test_memcontrol.c I'd suggest updating also the header of the test for clarity and then exempt the Child 2 ('E') conditionally from comparisons, something like: @@ -380,10 +380,10 @@ static bool reclaim_until(const char *memcg, long goal); * * Then it checks actual memory usages and expects that: * A/B memory.current ~= 50M - * A/B/C memory.current ~= 29M - * A/B/D memory.current ~= 21M - * A/B/E memory.current ~= 0 - * A/B/F memory.current = 0 + * A/B/C memory.current ~= 29M, memory.events:low > 0 + * A/B/D memory.current ~= 21M, memory.events:low > 0 + * A/B/E memory.current ~= 0, memory.events:low not specified (==0 w/out memory_recursiveprot) + * A/B/F memory.current = 0, memory.events:low == 0 * (for origin of the numbers, see model in memcg_protection.m.) * * After that it tries to allocate more than there is @@ -527,6 +527,7 @@ static int test_memcg_protection(const char *root, bool min) for (i = 0; i < ARRAY_SIZE(children); i++) { int no_low_events_index = 1; + int ignore_low_events_index = has_recursiveprot ? 2 : -1; long low, oom; oom = cg_read_key_long(children[i], "memory.events", "oom "); @@ -534,6 +535,8 @@ static int test_memcg_protection(const char *root, bool min) if (oom) goto cleanup; + if (i == ignore_low_events_index) + continue; if (i <= no_low_events_index && low <= 0) goto cleanup; if (i > no_low_events_index && low) --lu3xupyh5hd532gg Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQTd6mfF2PbEZnpdoAkt3Wney77BSQUCZ/PuWQAKCRAt3Wney77B ScwcAP46No9qCK9KNhyaGyrJbha1L6AsoeFeO9BW0ZboeZ5NRAEAvEX67kbDxGFX Obe817O6E0lDvyjPXo6bT4YSjrBk1AQ= =yLF8 -----END PGP SIGNATURE----- --lu3xupyh5hd532gg--