* [PATCH] mmu_notifiers: remove leftover stub macros
@ 2025-05-22 22:30 Jann Horn
2025-05-22 22:59 ` Alistair Popple
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Jann Horn @ 2025-05-22 22:30 UTC (permalink / raw)
To: Andrew Morton
Cc: Alistair Popple, linux-mm, linux-kernel, Jason Gunthorpe, Jann Horn
Commit ec8832d007cb ("mmu_notifiers: don't invalidate secondary TLBs as
part of mmu_notifier_invalidate_range_end()") removed the main definitions
of {ptep,pmdp_huge,pudp_huge}_clear_flush_notify; just their
!CONFIG_MMU_NOTIFIER stubs are left behind, remove them.
Signed-off-by: Jann Horn <jannh@google.com>
---
include/linux/mmu_notifier.h | 3 ---
1 file changed, 3 deletions(-)
diff --git a/include/linux/mmu_notifier.h b/include/linux/mmu_notifier.h
index bc2402a45741..d1094c2d5fb6 100644
--- a/include/linux/mmu_notifier.h
+++ b/include/linux/mmu_notifier.h
@@ -654,9 +654,6 @@ static inline void mmu_notifier_subscriptions_destroy(struct mm_struct *mm)
#define pmdp_clear_flush_young_notify pmdp_clear_flush_young
#define ptep_clear_young_notify ptep_test_and_clear_young
#define pmdp_clear_young_notify pmdp_test_and_clear_young
-#define ptep_clear_flush_notify ptep_clear_flush
-#define pmdp_huge_clear_flush_notify pmdp_huge_clear_flush
-#define pudp_huge_clear_flush_notify pudp_huge_clear_flush
static inline void mmu_notifier_synchronize(void)
{
---
base-commit: e85dea591fbf900330c796579314bfb7cc399d31
change-id: 20250523-mmu-notifier-cleanup-unused-238762302a66
--
Jann Horn <jannh@google.com>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] mmu_notifiers: remove leftover stub macros
2025-05-22 22:30 [PATCH] mmu_notifiers: remove leftover stub macros Jann Horn
@ 2025-05-22 22:59 ` Alistair Popple
2025-05-23 3:43 ` Qi Zheng
2025-05-25 18:56 ` Jason Gunthorpe
2 siblings, 0 replies; 4+ messages in thread
From: Alistair Popple @ 2025-05-22 22:59 UTC (permalink / raw)
To: Jann Horn; +Cc: Andrew Morton, linux-mm, linux-kernel, Jason Gunthorpe
Thanks.
Reviewed-by: Alistair Popple <apopple@nvidia.com>
On Fri, May 23, 2025 at 12:30:17AM +0200, Jann Horn wrote:
> Commit ec8832d007cb ("mmu_notifiers: don't invalidate secondary TLBs as
> part of mmu_notifier_invalidate_range_end()") removed the main definitions
> of {ptep,pmdp_huge,pudp_huge}_clear_flush_notify; just their
> !CONFIG_MMU_NOTIFIER stubs are left behind, remove them.
>
> Signed-off-by: Jann Horn <jannh@google.com>
> ---
> include/linux/mmu_notifier.h | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/include/linux/mmu_notifier.h b/include/linux/mmu_notifier.h
> index bc2402a45741..d1094c2d5fb6 100644
> --- a/include/linux/mmu_notifier.h
> +++ b/include/linux/mmu_notifier.h
> @@ -654,9 +654,6 @@ static inline void mmu_notifier_subscriptions_destroy(struct mm_struct *mm)
> #define pmdp_clear_flush_young_notify pmdp_clear_flush_young
> #define ptep_clear_young_notify ptep_test_and_clear_young
> #define pmdp_clear_young_notify pmdp_test_and_clear_young
> -#define ptep_clear_flush_notify ptep_clear_flush
> -#define pmdp_huge_clear_flush_notify pmdp_huge_clear_flush
> -#define pudp_huge_clear_flush_notify pudp_huge_clear_flush
>
> static inline void mmu_notifier_synchronize(void)
> {
>
> ---
> base-commit: e85dea591fbf900330c796579314bfb7cc399d31
> change-id: 20250523-mmu-notifier-cleanup-unused-238762302a66
>
> --
> Jann Horn <jannh@google.com>
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] mmu_notifiers: remove leftover stub macros
2025-05-22 22:30 [PATCH] mmu_notifiers: remove leftover stub macros Jann Horn
2025-05-22 22:59 ` Alistair Popple
@ 2025-05-23 3:43 ` Qi Zheng
2025-05-25 18:56 ` Jason Gunthorpe
2 siblings, 0 replies; 4+ messages in thread
From: Qi Zheng @ 2025-05-23 3:43 UTC (permalink / raw)
To: Jann Horn
Cc: Andrew Morton, Alistair Popple, linux-mm, linux-kernel, Jason Gunthorpe
On 5/23/25 6:30 AM, Jann Horn wrote:
> Commit ec8832d007cb ("mmu_notifiers: don't invalidate secondary TLBs as
> part of mmu_notifier_invalidate_range_end()") removed the main definitions
> of {ptep,pmdp_huge,pudp_huge}_clear_flush_notify; just their
> !CONFIG_MMU_NOTIFIER stubs are left behind, remove them.
>
> Signed-off-by: Jann Horn <jannh@google.com>
> ---
> include/linux/mmu_notifier.h | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/include/linux/mmu_notifier.h b/include/linux/mmu_notifier.h
> index bc2402a45741..d1094c2d5fb6 100644
> --- a/include/linux/mmu_notifier.h
> +++ b/include/linux/mmu_notifier.h
> @@ -654,9 +654,6 @@ static inline void mmu_notifier_subscriptions_destroy(struct mm_struct *mm)
> #define pmdp_clear_flush_young_notify pmdp_clear_flush_young
> #define ptep_clear_young_notify ptep_test_and_clear_young
> #define pmdp_clear_young_notify pmdp_test_and_clear_young
> -#define ptep_clear_flush_notify ptep_clear_flush
> -#define pmdp_huge_clear_flush_notify pmdp_huge_clear_flush
> -#define pudp_huge_clear_flush_notify pudp_huge_clear_flush
Reviewed-by: Qi Zheng <zhengqi.arch@bytedance.com>
Thanks!
>
> static inline void mmu_notifier_synchronize(void)
> {
>
> ---
> base-commit: e85dea591fbf900330c796579314bfb7cc399d31
> change-id: 20250523-mmu-notifier-cleanup-unused-238762302a66
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] mmu_notifiers: remove leftover stub macros
2025-05-22 22:30 [PATCH] mmu_notifiers: remove leftover stub macros Jann Horn
2025-05-22 22:59 ` Alistair Popple
2025-05-23 3:43 ` Qi Zheng
@ 2025-05-25 18:56 ` Jason Gunthorpe
2 siblings, 0 replies; 4+ messages in thread
From: Jason Gunthorpe @ 2025-05-25 18:56 UTC (permalink / raw)
To: Jann Horn; +Cc: Andrew Morton, Alistair Popple, linux-mm, linux-kernel
On Fri, May 23, 2025 at 12:30:17AM +0200, Jann Horn wrote:
> Commit ec8832d007cb ("mmu_notifiers: don't invalidate secondary TLBs as
> part of mmu_notifier_invalidate_range_end()") removed the main definitions
> of {ptep,pmdp_huge,pudp_huge}_clear_flush_notify; just their
> !CONFIG_MMU_NOTIFIER stubs are left behind, remove them.
>
> Signed-off-by: Jann Horn <jannh@google.com>
> ---
> include/linux/mmu_notifier.h | 3 ---
> 1 file changed, 3 deletions(-)
Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
Jason
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-05-25 18:56 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-05-22 22:30 [PATCH] mmu_notifiers: remove leftover stub macros Jann Horn
2025-05-22 22:59 ` Alistair Popple
2025-05-23 3:43 ` Qi Zheng
2025-05-25 18:56 ` Jason Gunthorpe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox