From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B91D6D10F5A for ; Mon, 18 Nov 2024 03:57:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D17D46B00CC; Sun, 17 Nov 2024 22:57:13 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id CC78C6B00CD; Sun, 17 Nov 2024 22:57:13 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B1ACB6B00CE; Sun, 17 Nov 2024 22:57:13 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 8E29C6B00CC for ; Sun, 17 Nov 2024 22:57:13 -0500 (EST) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 2148640113 for ; Mon, 18 Nov 2024 03:57:13 +0000 (UTC) X-FDA: 82797854034.26.1EDB630 Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by imf10.hostedemail.com (Postfix) with ESMTP id 25060C0007 for ; Mon, 18 Nov 2024 03:56:47 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=VVZhwG1z; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=QczwoOPX; spf=pass (imf10.hostedemail.com: domain of liam.howlett@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=liam.howlett@oracle.com; arc=pass ("microsoft.com:s=arcselector10001:i=1"); dmarc=pass (policy=reject) header.from=oracle.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1731902139; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ARmpMadx8JqgCzeTK7xksXIEefTcXGkeTpu3n0+g/dM=; b=Pusqa9GXGZRjveB+Mp7FlmBh2KXdywXBUK5JHDH/j6X6t6n3EZyGoKfIIXawa9iVTYIk/G x4bdV/tjZ0SgJs0G/Ncw1HVJ5R2ZK9CfyRiNaXKAuHMLgVUIO4N/tEYiSVmYNcog221TrX cZB7WVXwvLKAxm/qo7y0rMzodJrT4EY= ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1731902139; a=rsa-sha256; cv=pass; b=pn44iocxJDyRAKaAiFTosm4nIBSggijOlI2hVunTroeBrmSrCBmEPc1OwT3kNfG54erOXV tKF4qIC0WEau2TMy9/q3vIGkNPWnG3IvAJgPmMFufGHpAZfT4inp7Li/ZSi+jAXgI4ekXe pSx/6CZC/KBfwQIB+29x7iaBhkpuRI8= ARC-Authentication-Results: i=2; imf10.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=VVZhwG1z; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=QczwoOPX; spf=pass (imf10.hostedemail.com: domain of liam.howlett@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=liam.howlett@oracle.com; arc=pass ("microsoft.com:s=arcselector10001:i=1"); dmarc=pass (policy=reject) header.from=oracle.com Received: from pps.filterd (m0333521.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 4AI1BfoC007496; Mon, 18 Nov 2024 03:57:06 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=corp-2023-11-20; bh=ARmpMadx8JqgCzeTK7 xksXIEefTcXGkeTpu3n0+g/dM=; b=VVZhwG1zw8p6jHYcHXmj59zekxkUXQ16wD dGAfef41XZ7pouYWiBqEeh0+Z9C2sL3qDcTtDuvve1zsi+XCf6XqgzYwPb0+VEc6 nkpF8Cal8nsW5YRRlWok9wEUVDhGLA7U2F+Lmg3Ct3z2A2w3hGiot+ED9cL8MoRZ P217yi8nu57z4ZYIZ5r6UVG0Bec6YWxGTzgAhNYzlJuUI44sjiSyHz6Kd4bFZRRD fu/jEIFOwWs1Zo6isKIlYiczN7F0ArUakK0PWH00r+p98eUZxO9pSfdyyWl8jmbq lTHGCNoFWfmQtUMMyg2V64/AzCuoaV5QQWYiB5SKdyQtj7KJXItA== Received: from iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta02.appoci.oracle.com [147.154.18.20]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 42xjaa1vc7-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 18 Nov 2024 03:57:06 +0000 (GMT) Received: from pps.filterd (iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 4AI0l7ap036931; Mon, 18 Nov 2024 03:57:04 GMT Received: from nam12-mw2-obe.outbound.protection.outlook.com (mail-mw2nam12lp2046.outbound.protection.outlook.com [104.47.66.46]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 42xhu6m69x-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 18 Nov 2024 03:57:04 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=DAeM2vmaWarvC8WqujxAC1bQ/11/ofcd6A9WAtBS34EybgOaBlwhJR4T7hZjKnnBEqc0YA2JKjkihA0Jl2/28ef7wAusCKApZnyBz9LQXUOYa3fKcXY33Io17iKsrfMMhtMgwLRNT5abEQoGVpAW/S0lFtq727jgxKieyYeJVPtCNl94GcpFX9DGDXtqpRKIAjw/edG94oXtGhywuul4G4YaF/T8z8FXGb4yq+53RKsVqTK4hesV/L01D48XSImpEvRklpRtaqryzOtCrcVX1RkacNKKuzIFYmbHv9Zonbf+RE/Sb2GwVYhS/KtwRGsKga0LZR8iAvF4q0AAMzf6sA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ARmpMadx8JqgCzeTK7xksXIEefTcXGkeTpu3n0+g/dM=; b=j+psuXWtocMixuwWA5xQmolvkIPxqfueQW0MwKtqpRLhrQ8aIrv08pQL0DvYY+NHqabH62iBArJU2E0tM/KL0+9Xj3yzcp/GyVtF8bAewMJ8yMqBx4ysYB5amJ9pZInlJ/lCk61Fh+nhLXR6ZBrc3sq0NyTrJdfY6CWYRpcvKzN1s482aqsmrARW6YuasW3fE7ShYsmSoJK3e4tpjhFGOzYg7bnst/HMQ4MHwh+vow9GgQf5a2I2uWE2AnD9GzyyWAHBF0SXz/fcn58e3AZ0+ct/nM9nl/Qrz27HNLjI8qBYhHvZV0jXCv9XZSpcGgJucIuPIg+twRzAw3+Wc7wfzw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ARmpMadx8JqgCzeTK7xksXIEefTcXGkeTpu3n0+g/dM=; b=QczwoOPXCuz8zlIRPtZ/GMCbC5jAayaiiJ+skWv3FiKUMja7sTAvMhy1a6NsllZ+q3/qtP/hHjFbgoNgJbX+uRErubVsxXKYiTzn4hPLWe3S57qa9VufLErUzbdbluulZCHNJeFJ1KpN0CSYrRn15Du0LACNRduIzX9iz3kaqZ8= Received: from PH0PR10MB5777.namprd10.prod.outlook.com (2603:10b6:510:128::16) by BLAPR10MB4996.namprd10.prod.outlook.com (2603:10b6:208:30c::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8158.23; Mon, 18 Nov 2024 03:57:01 +0000 Received: from PH0PR10MB5777.namprd10.prod.outlook.com ([fe80::75a8:21cc:f343:f68c]) by PH0PR10MB5777.namprd10.prod.outlook.com ([fe80::75a8:21cc:f343:f68c%6]) with mapi id 15.20.8158.021; Mon, 18 Nov 2024 03:57:01 +0000 Date: Sun, 17 Nov 2024 22:56:55 -0500 From: "Liam R. Howlett" To: Wei Yang Cc: akpm@linux-foundation.org, lorenzo.stoakes@oracle.com, vbabka@suse.cz, jannh@google.com, linux-mm@kvack.org Subject: Re: [PATCH] mm/vma: check retry_merge only for new vma case Message-ID: Mail-Followup-To: "Liam R. Howlett" , Wei Yang , akpm@linux-foundation.org, lorenzo.stoakes@oracle.com, vbabka@suse.cz, jannh@google.com, linux-mm@kvack.org References: <20241118021823.17386-1-richard.weiyang@gmail.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241118021823.17386-1-richard.weiyang@gmail.com> User-Agent: NeoMutt/20240425 X-ClientProxiedBy: YT4PR01CA0290.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:10e::23) To PH0PR10MB5777.namprd10.prod.outlook.com (2603:10b6:510:128::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR10MB5777:EE_|BLAPR10MB4996:EE_ X-MS-Office365-Filtering-Correlation-Id: c40ac4df-807c-4718-dad5-08dd07850ecd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|1800799024|366016; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?qJPqRHt3KEmhNO/t4lGamh92+Do5OfML4w/S0TG2fbOxPse3z5EE3jdiJGFx?= =?us-ascii?Q?XVt1Vm/WTHlz7IqxSI97rVZlVK6fGZqs7Ms4kw2NhUdYnHyeCFTPuY4fr/ED?= =?us-ascii?Q?bUBo2XLi6VZvoRODxFI5LcUDEYaAourBlJMexMVoOrlw5MHd86tQztjWcas7?= =?us-ascii?Q?JVlxGG/y5fsUZSuFLrSzPhW8xDWdwZfNAkY9Rmk0c7V1lmuyYFL110hlsmN9?= =?us-ascii?Q?VNMfws5d6jrCsbvVc1NgJ5t8yuA5dQkS+HV17wKxO+blzVVDSix+BMcxz7DN?= =?us-ascii?Q?XWiBMdWMYQ/3j9e5gQ5kOtjjVG2GG9eTBNLMJIrqMTF27mdQfvPE/OT22L4G?= =?us-ascii?Q?Hg6nJxhFlWTdSqvXJbLEuRG9bYakTO8JRCbJ7wTYxq0c02wfsQPi+rZOCy/W?= =?us-ascii?Q?tfmijbszAq2zEwAD1UhwecK2eQ1gR+wox9LFsMkHOiXcJ6fJXVJ3jD/8lBqW?= =?us-ascii?Q?0b7CepX7dO9cmPjROI6kS2cgCx53o3wrbI69iy0zkOaw/nxTHEshNeftDdlk?= =?us-ascii?Q?A36UyWXsUF+HRySNiwG/2w+8dfoJyCASWipyXUYHFvG+mVyXX1/bquSMLlsp?= =?us-ascii?Q?5pjZSX4idrDhhD1JzRUGVHepmQoJVPfibhHQEWX/+BGqXI5oRlwOxZdi9Ro4?= =?us-ascii?Q?GUhuV4izHf0f+8C+VE9sU9Xy7rraV99RdnUlCVmwa+FZxhaU0QAu1nI3ky2/?= =?us-ascii?Q?OxkD4DU9ebE2PDaCphUCG1mtHZ5Tsjeoe63Wvl1sQLY11THyacZr2uFrE4uk?= =?us-ascii?Q?238geI7oHbOpzRleBNFGzcjAeoQhvDtQD1dNy5gqaaH/bed1/7YDsJmel/Dy?= =?us-ascii?Q?xYVmImmJsZLOGOpG0361ObT8lEtgxkUC+rhMpTy03NvZ6+vD9PyUs249Z+HC?= =?us-ascii?Q?Fb4cRRxygzpZasCfKy8PZ8FvhNElniGwJ9jqb20dzEaZdcQXrsaeVILVQ8Zu?= =?us-ascii?Q?n+Ux0UPHQv/mHtqJJUe5kryYrmsg57PmA4ban02kkKzyW2BvWhoex6R5g3Sc?= =?us-ascii?Q?Ze9kIHhEvxIqMq8Va0BPJPknDwA/GIqGaCGMBCPIm4vwEjkuNWIwBfx/4GOx?= =?us-ascii?Q?ND2jU30CHMYb/4D9aGk7ZuLgkss3D3z+tIREfWrbMlsXXZHKaKhYLY0OPBSy?= =?us-ascii?Q?BwAj9tFxrnzhiLdG1PdpNJjOGUt57JDryneCih56RwdLm2j/SirJ1I4SsRdZ?= =?us-ascii?Q?ZM3q3guw1XgtEe0LcRyypD8JARvoasGEN+IC6JqZeFoQDvJPmTDcG/0uMn1s?= =?us-ascii?Q?z5PlQzhzBHqWa6Vyu9DB+zeA1Z4PaqfPgEycqMF5GWVbKmkbBjZMRc3gz37e?= =?us-ascii?Q?B6+rYeL3FrCS761toVo0eNCG?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR10MB5777.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(1800799024)(366016);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?i23JGL2f4XMbid8uQ/i4LIVtR4CKxbsd1Uv3rpBkJZ9lNlkysNEldI04SAcg?= =?us-ascii?Q?XXMhyHU/cRMNSFrMAD0OGc22lYgm1zX1iIDYk1H4NoCsFla0hgzhx/iUGYkh?= =?us-ascii?Q?+ms12BnJBg5DUnMeALWM+BXtN/mq0mWTtic4uGQ1kJQ2vd2Eg9F0f/9s02Bv?= =?us-ascii?Q?z6mFIVjC6HuB2XFLqrNyDKY16MTKLD8qzU+UkfTx5K24v33y2n3WsR5fSrqQ?= =?us-ascii?Q?YXTmSHHce42RDYRrlYrydnYFigjCIxhmekf44CdV5Tggl1Od700Ej1tCnbjn?= =?us-ascii?Q?6VTRovHvRbLnvtey2aNYER4+5Yi2Xej6CTBVvUV6f8ocFOAcrwn4/glKf8s2?= =?us-ascii?Q?dLZS4rSMpZRnM49NL9fzcxNIG74tvj/DjebDM7e4Y7AN9InP67ZMUaJnHak2?= =?us-ascii?Q?ZspoQ6xea05NxxaHaRxO0uHHbBLHCUm/5S7f+IuxLGiMtMKeKPiQa6+RX/zx?= =?us-ascii?Q?CDI8H3brhKyTIUupaAVNH8ibnDHXWCjfSuv01rLWXhfeKixhkZe7K3Sfos2b?= =?us-ascii?Q?/6MDDqV/3vXO+ouO+Twf5B+JAYqrDV/elTKWKwqUwe+y7rMODwf3y+8ou1Z3?= =?us-ascii?Q?d9gjqbAmqL/FAOjt7ZnW2BZqpeUZtki4WW24c7RcM5XkywGJL6LHZgGTgFuR?= =?us-ascii?Q?z7ajxE0j3Ry6SA53wv05QlN2CmVl8q5EoquihzN3h/4dSTfp4HU+1oLn8VEz?= =?us-ascii?Q?iB4Mn4/UD7WN/I68RCjHpRoDnu1tTXTljgXIaM/UHJL0Yl8b23Hb3x3PUwZ1?= =?us-ascii?Q?qwTiBhETpyM6XCLCZs27PRQXCYKGyQ8OAjwH75GCtJuAhwUjp3Eo09a/zUoc?= =?us-ascii?Q?ckxEPFrQ86br9GpRQkorNpTQpUVpS68a2JJrE4Zu/pBqUdK4lZ+VIhcPYK0F?= =?us-ascii?Q?pX+IA3cuUdonjvzyuEs51B0Y3pjkNl+OSX/3i2HmVdWJeN2uInL5y4BxbePY?= =?us-ascii?Q?bk+MqPc9bELffAwaBkJHLQxop7IxbM2dHS73Ifa2qfBJxsTqMbDWGDGPmphP?= =?us-ascii?Q?+E56ODkb5hxZFhmupu16G+51z2fnLFrOzvG+bK9rOzPVCsjqGAuTk5xCrova?= =?us-ascii?Q?yH82RQbFTC1qrAPdho3+2TMinDRVXPRrcexCoUZpJ7vEHXrzci+DzX4Ahkj3?= =?us-ascii?Q?I8u0tE+CbWILOdfA316PERjko+fmavwpA6tqDTSmpoZpvE1PUp//Hh8XUlaq?= =?us-ascii?Q?If6yA+T7tKBjmCPrgfsVN2ggo1EgzcVrNy1Ks6vlHZ98jX9Ksm+TonaDM/wq?= =?us-ascii?Q?nlMwGqNmNNZ09ydyV5KwhGd2uMpSgAimsbVGAj/4tdpQrCSW0GgpCEQ3vnR7?= =?us-ascii?Q?WzNhWWRz9oIA1e08MNkSXh4vsz41iBexvMeGSQgp6TS4jRGMWh/Wra9LgMlH?= =?us-ascii?Q?uqWVElROmx0djHmfqscNsYvjYGOLdOxzlHL9XiR2RjVzXFKTOLQO308OktdF?= =?us-ascii?Q?2F+0PsrV/XzWWxA3FjHj2rky/buoRXckxUfJ1aQqO3zpA00w7Pod8LceIOZV?= =?us-ascii?Q?JWtnrv3lo/Tvl85cyEeDGDmaNnBxHdwqywFx14Hf7CiAtS1C5T8ibRODLEUh?= =?us-ascii?Q?bvbdIT1HlQeTU7kUoZc6YrCdFXRNkFP5qNgk9CY2?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: y3BUotxN8pYSFI7dbFFZebr0Z12qtbKhojEK4WXUMX5Kz5Nn5r/qzagGcPobBb+nUwJQld0TKwS9goaJZOdR/jaaflJwMliKg7oyAg3Kfs7FcMKmQWtdUTa2ryp49H/qnhEqW/qT4XlPMtZSV3b+sPSmJRDpllo6G7WU+o4zAaqDzgQuzczksFMh9+o00i7xDRy8ZWHWo2SGNUPU6yTlw7QPogtP95GukEijM95DH4DT9N9pRYEDOsx4XHxCUt2POG4Hi+696bPDvFu2y836APvGDGbDQ4/51EN/tA/492XEAqkrmPISJswJLWCwidIp8dmxqSDsKfPTBXNgXn/cjzwCjCyuNGa2YT9eDznjPms2rqnhAorsmkcpV0a2EDd5K8v7BTjd1TnoNq5yCzVeYlbahUmiEvoulE+fY2h34d8V3PnNjca5xaLxzeeUrunFi0eaHVm3tSRI5pvc1OgGAnsQyDjxRJaUW/kIoRjlniqXERvxem+Pd6F/Nl7WLIiXfie07Gw2H13qCA/sNHw0ITdA6QHjrADK81burXu0A13VT4ewcasEdIWRK4Xw5LBHExB4oufO9bp0Uyb3WyVp0IgpTOzUH8kmnurGdt/mgHs= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: c40ac4df-807c-4718-dad5-08dd07850ecd X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB5777.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Nov 2024 03:57:01.8334 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: iVOVIw9JR72gGqHdJmOAGFtDUR0zbZEto1+ykDFtyLx1k2+bYEXpvIbdnJqFDEwZyshYQ3ShEKsAHMPDLNHwww== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR10MB4996 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1057,Hydra:6.0.680,FMLib:17.12.62.30 definitions=2024-11-17_24,2024-11-14_01,2024-09-30_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 adultscore=0 mlxlogscore=999 phishscore=0 spamscore=0 suspectscore=0 malwarescore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2409260000 definitions=main-2411180032 X-Proofpoint-ORIG-GUID: HqBmc8W7XDqFtZAhFIl-Pnc_4TV589XR X-Proofpoint-GUID: HqBmc8W7XDqFtZAhFIl-Pnc_4TV589XR X-Rspamd-Server: rspam10 X-Stat-Signature: f96hd3oncexd88tmsd71cmyqtksfhsi5 X-Rspamd-Queue-Id: 25060C0007 X-Rspam-User: X-HE-Tag: 1731902207-724014 X-HE-Meta: U2FsdGVkX19gGg5S5FPZ/FZmDmVd3XaOLI8X6DV8JIXbUxalTb0TZnfHyij1zKzOO9zGBw70G1d8nLcrkjz/Fj0x0c4KE22r6LX5H/k3B1iIluFzwo6WM0QXbxNr7H2A+aGy8Ox2v3zOef9GEQW7xQ1GOqONBfk4wXi8v++yXb4t5CefSQEVWonSA3RA8J7bSbuszZFqBPwjKS4f7AwWtRYLli3rcSrQu0TtWp5Oq5PIhA8tWZfTfBb1hiqbAhdB5Pqbz1nod7X2B7VeqLS3euLYVmk3gIsY5uAW6ESSbQfZJcsM3CCJK2NWNoiiCZdau4iYAyaqx2gx6s+l44sQBdFonrLayCh++kT148n09p/V6Mq2dlq0d9f7HLrOpkMch6JD+uRsbN384moZTTMdH/aRo1NJB970UOYcIi98/qLuxGUcMNv/AwFi87PqrV1ilqMGkrrqLvwJ77s/NEdIAE5u1+mIkRq9VoZpOXz1hFEGm0qFz+ka5PgblCRzGi4aMX6/dwzE4T8Vo/j7Ioeg+62tIliI8+VFd0smSJvS5xFwpuhBTNQPC9aRRGavL4R0q03NwAxi2YD3voeN9kdNXzpZ5TbNxMf0am0Nf5DqhpHcqvKaaBkiXY7yASe8QLzSroPzQ7v5o66LMsTbTfsyIW9x6a7F0U2PtySynJqivr1PQCr5AU3MdSjaS1WWjCHrNsXF6H9Rw0UsQCkJbmeq2ZONCOABBFVd0ELrNGZN60UVUoC1FYds/BmOk6E+Bogguwsh68R2KFH2aOCIuIaREuWaFPhmqlX132WiZKkOP3mUz8X36+mgmRsnnlJZOk1Pb1HkI6l2zBj+iMWCeRLIP6kmeKncbR804PnqvVrWNAN/x36KwLBnH01IbqTAJ01sjg1+plY5+lOA3AMcZVtUK+S9MFSOpQCyNMvAHiMzn7jXcPRxclBCXs2gVFijpsGwH5qdHqfY7SJGNpUV33J gO+iPBIR wxEcMr/8FzbzHGij2G2lIWHfL5YHpYht7ylNHphcnosqLtMGIvxB44hO7N2mHqrhCWyOer0NTApMxomJGx+Jsnxin7cJDcpQ+iIjbxHNmuW8c4k9lP6drIBgGp0ZmO++nxrj4HR1uHWfoj2Ho39MZNXuuDrvLYcMfxS/D+drQ2UQQpOSTD9wJQ198D+LfiPXDGCXtjjxa1M/zMnT1nG/vJUJZ0EIr7eDXjTnaOo6Yl/d6AC5gIkSaJHkJl7UlqDOYISMxJUwC5VaRB2lrHHSitaMHWJepYBrFilupegym236TscIxnQC4aMMnploPobTApuknou29TZ4V7akRr2X2dAy41PwXnf8nFWvauRfCDsWenZHIH0t0VVDUwY4qC8WekToD2Blnx+JMPIkPXxzviLiCQIH4AWNVwQq8b0BsxykKqwt+/Z0oBevPrPT3Wb3ASfsML28VqJ597K3T5FiMJ81/fnv9/K66IN4w21yduMTqIbxLlSUsET+vRfhbbvtgPjsFPlLlbit5jEtHAbuMNBRPKcrf8levj3QCdXLejBRJNl/w2J0+EovOBGd5hb+IeWoNhs8rnRg7vrDBfpH47qIhoE5lvoCyQ6YwU+STEDSJdaudJOghIeBMvliW0bX9Nujjlv4az7726+USbefM5DVxif9PZoKF6M0fqBg6U1CwYt7hO6mum5xZSFXSR0n3Uoubsek5AB4XLaaYfM0cdo4r8iE1HsUlSZdSpKG3520kClw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: * Wei Yang [241117 21:21]: > Current code logic looks like this: > > __mmap_region() > vma = vma_merge_new_range(&vmg) > if (!vma) > __mmap_new_vma(&map, &vma) > __mmap_new_file_vma(map, vma) > map->retry_merge = xxx --- (1) > if (map.retry_merge) > vma_merge_existing_range(vmg, &map, vma) Please don't quote code in your commit log. We can see the code in the diff section. > > Location (1) is the only place where map.retry_merge is set, this means > it is not necessary to check it if already merged with adjacent vma. > > Let's move the check and following operation into new vma case. This makes sense, but this is a complex block of code. I'm all for optimisations, but there is already a bug in the code that you relocated in your patch, and the backport of these changes isn't even complete. Maybe we can give the existing code some time to soak before optimising? > > Signed-off-by: Wei Yang > CC: Liam R. Howlett > CC: Lorenzo Stoakes > CC: Vlastimil Babka > CC: Jann Horn > --- > mm/vma.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/mm/vma.c b/mm/vma.c > index 8a454a7bbc80..80b1bd404f23 100644 > --- a/mm/vma.c > +++ b/mm/vma.c > @@ -2456,14 +2456,14 @@ unsigned long __mmap_region(struct file *file, unsigned long addr, > error = __mmap_new_vma(&map, &vma); > if (error) > goto unacct_error; > - } > > - /* If flags changed, we might be able to merge, so try again. */ > - if (map.retry_merge) { > - VMG_MMAP_STATE(vmg, &map, vma); > + /* If flags changed, we might be able to merge, so try again. */ > + if (map.retry_merge) { > + VMG_MMAP_STATE(vmg, &map, vma); > > - vma_iter_config(map.vmi, map.addr, map.end); > - vma_merge_existing_range(&vmg); > + vma_iter_config(map.vmi, map.addr, map.end); > + vma_merge_existing_range(&vmg); > + } > } > > __mmap_complete(&map, vma); > -- > 2.34.1 >