From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8B37C28B30 for ; Mon, 10 Mar 2025 12:06:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 92064280010; Mon, 10 Mar 2025 08:06:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8D111280009; Mon, 10 Mar 2025 08:06:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 77390280010; Mon, 10 Mar 2025 08:06:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 1C95B280009 for ; Mon, 10 Mar 2025 08:06:31 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 7784D55DED for ; Mon, 10 Mar 2025 12:06:30 +0000 (UTC) X-FDA: 83205514140.24.7BB9700 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.8]) by imf10.hostedemail.com (Postfix) with ESMTP id 5303FC0011 for ; Mon, 10 Mar 2025 12:06:26 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=JNSEefD6; spf=none (imf10.hostedemail.com: domain of kirill.shutemov@linux.intel.com has no SPF policy when checking 192.198.163.8) smtp.mailfrom=kirill.shutemov@linux.intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741608388; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=QhjuFut7kXpJNbBu6LjegJE00Sqg2GSpTbFlJ9HMOYY=; b=J8YMJ5QgXOmAFyf3rpS0x+AkEF+9jZ0C0P7sf/bPLNe5PH4aBO2mM+oML74HExtjpp93Gq qJQrHsroRlH7GpHec/HsVE/GczHs8kAEIKpkgwIK5uDklS2kMJsYuNcGEOIXSPyXqYOIug IKmaGwdNd2DN4cuQxRxkwvEzUCSjfTo= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=JNSEefD6; spf=none (imf10.hostedemail.com: domain of kirill.shutemov@linux.intel.com has no SPF policy when checking 192.198.163.8) smtp.mailfrom=kirill.shutemov@linux.intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741608388; a=rsa-sha256; cv=none; b=icbl2nT2MGViWl1M18x0eE+gf1S4DUqMvBVgTGT3sW9zn9YPUfk45Ql1YL4Ki/ko2q2uVQ nluk4FH7+EKMqcPxGtAaPidX5UengbGhO0BPQZMJG4B3otaMhZEdkDNQKm5HOtdHoDleu9 /sHSsGXU59bMaeQNO9nvd9HubRrlXLQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1741608388; x=1773144388; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=fLAJAiqYd+Sl4aTlzjXT7WtMKBaFjK51w6THZu36tD4=; b=JNSEefD66ccQVd4IgUjfIJ41djD5GJJqY5DRZYF2sOnYIKS+eoi4+/o8 obnphpic3xbamFwgk6h+5DVnVJ25hxLZpKzTjrDmdBfflaF8p9wygfUF2 guZ+3hz4AhTEq9yiK9oY7mw5nTt7vtUknSH2fAMr/JnmNVPYIBFBheUVr Ed3MbxIHODNSwbA/wdhTgYKsbyziHdiMEc5qTuLhOjIsq6qpuZXHgKmbX yJ87we5RcUhbHlIzZ/qmcXiZi//TNjkYJpOx79u/VsvVOENwbgcd1BiSh isXguBbGM3qqh7n+lBnoG/c05RqB2FCugIzDcTVAy5WabgWqrUJIN2FmD g==; X-CSE-ConnectionGUID: gjfvdAfRT7KTisiHnrFp5g== X-CSE-MsgGUID: vUEoJfJNT7ClqCdod9dRXA== X-IronPort-AV: E=McAfee;i="6700,10204,11368"; a="60150538" X-IronPort-AV: E=Sophos;i="6.14,236,1736841600"; d="scan'208";a="60150538" Received: from fmviesa005.fm.intel.com ([10.60.135.145]) by fmvoesa102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Mar 2025 05:06:25 -0700 X-CSE-ConnectionGUID: EBoIinS3T/2ESNvpSDaWog== X-CSE-MsgGUID: AY3cGCFuTmKo8D50e1j/+w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.14,236,1736841600"; d="scan'208";a="124582470" Received: from black.fi.intel.com ([10.237.72.28]) by fmviesa005.fm.intel.com with ESMTP; 10 Mar 2025 05:06:23 -0700 Received: by black.fi.intel.com (Postfix, from userid 1000) id E7AC0156; Mon, 10 Mar 2025 14:06:20 +0200 (EET) Date: Mon, 10 Mar 2025 14:06:20 +0200 From: "Kirill A. Shutemov" To: Vlastimil Babka Cc: Andrew Morton , Mike Rapoport , David Hildenbrand , Mel Gorman , Tom Lendacky , "Kalra, Ashish" , Rick Edgecombe , linux-mm@kvack.org, linux-coco@lists.linux.dev, linux-kernel@vger.kernel.org, Farrah Chen Subject: Re: [PATCH] mm/page_alloc: Fix memory accept before watermarks gets initialized Message-ID: References: <20250310082855.2587122-1-kirill.shutemov@linux.intel.com> <03b53f18-8c16-4716-8ed4-1902d7247354@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <03b53f18-8c16-4716-8ed4-1902d7247354@suse.cz> X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 5303FC0011 X-Stat-Signature: 795x8syj7kp1z18kmm7eduus6bk773kn X-Rspam-User: X-HE-Tag: 1741608386-84827 X-HE-Meta: U2FsdGVkX1+Vg1bami17FxN6tZ+PGlDjVfIRHj1K8CMGytjH5TfcexxtyQ82BN9xPNVXDN6GBrbtESMjHMjHccDKniV90y/An5CZVRgo17FFyS0Cl0SbMm20JOw5OnTPyFYnbcpTQIKuiRQDLfA32q4bo1jF6SfPxluU1Za9mK1xGeYqFajT+h5cM1nIIITDNP0krdq1GIwXGPuluVc8gFUnhTIaZy4mf/VH9AoYMa4YLvwH1hwH/SX6Ei+BhXX0Znk50XtlgM5J75XcKhtOnN3s16ieaXnBGwPJ7YaJwE6u0gm2FLDMypjJwCn6QSsYp8lhnRWm1iTiv+oWw6wmCtYUA5bp+lo5gxLA2YNKL65SjBecL5j/pn9TEF12edBBDAfhvlBwaFow7Uei/H0KEtS4FlCCReOnwKvKscdBswqqImZjmaDjj86B9LvzSjOAIxi21ukkpNG9O4CIcSJllqnm+IqZS1gm0LTF3G3WWav8D7frbcQ1Ew21re6ZlZTCv2ojDfdw8dNGLE1N8F7+TnDsoOiYGHKUcaSYFiouLJT4J4MgJWMgUK5uYiJgt+9Wkfzp0os+sfC5TIFUF2OPYD1bq8xT3m02ZULaMeOg0DukKjuegFdhWNOJhquTEXgAF3jZ8q8yQwJC4JzIZ/xp6IRWhs76G2uP+UyWZ2lGcLyLYJ9rHWCIW70dLvbS+ET0IJ5P8ZxZvgq2Hbi0fPlK3upRwmz+jkPWYrEqnStgma0u+51ezjK69S23VjEsgr9vyL0vMoO4ok7nUaJNsZsojpNIehMNiVo51WbpUElVkt8w6hlxePCDPsP9NtpGEUpzN8/21Z7g4UC85dg6kmb6QW/16zZeyNk7KzyejIT7jyi2TOoiVeAIz+etiFSSwykYmln1jaRHK1/mdkLOONcPC75Da10mIUfvVd20bZu7wYIB21TWxbZdJjbZPxlGVxwXplcIWEgreiXO8JabiB5 ILMOgPF1 WuAQRtsnNKL+63t1PnjOopQW/TRYbNDUsXqDNaaFvW0qVIYiTFqc9JLWNAdztT3KPhsgLyz8cvI/hs1iYCw0wAs8+HhnFw/iqtKkFDJoGGRO6kzTZDWzAhZpcxGpx17e68sm/+gfYfEXOYYF83JEyl39GnS5u+jUPymnYYFe3sI6K7T8cJea9aVhuZ7OvgUJp0Q9CHVQJc1G2esNGqUrBTpTIs9p2RyXjN2yodeaWREfuodspY0LKoCMCVTWTLUctVgrFfR3rrJSlQy1efrx4DYnvaQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Mar 10, 2025 at 12:37:25PM +0100, Vlastimil Babka wrote: > On 3/10/25 09:28, Kirill A. Shutemov wrote: > > Watermarks are initialized during the postcore initcall. Until then, all > > watermarks are set to zero. This causes cond_accept_memory() to > > incorrectly skip memory acceptance because a watermark of 0 is always > > met. > > What are the user-visible consequences of that? Premature OOM on boot. It can be triggered with certain combinations of number of vCPUs and memory size. > > To ensure progress, accept one MAX_ORDER page if the watermark is zero. > > > > Signed-off-by: Kirill A. Shutemov > > Reported-and-tested-by: Farrah Chen > > Fixes:, Cc: stable etc? Fixes: dcdfdd40fa82 ("mm: Add support for unaccepted memory") Cc: stable@@vger.kernel.org # v6.5+ -- Kiryl Shutsemau / Kirill A. Shutemov