From: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
To: Vlastimil Babka <vbabka@suse.cz>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Mike Rapoport <rppt@kernel.org>,
David Hildenbrand <david@redhat.com>,
Mel Gorman <mgorman@techsingularity.net>,
Tom Lendacky <thomas.lendacky@amd.com>,
"Kalra, Ashish" <ashish.kalra@amd.com>,
Rick Edgecombe <rick.p.edgecombe@intel.com>,
linux-mm@kvack.org, linux-coco@lists.linux.dev,
linux-kernel@vger.kernel.org,
Farrah Chen <farrah.chen@intel.com>
Subject: Re: [PATCH] mm/page_alloc: Fix memory accept before watermarks gets initialized
Date: Mon, 10 Mar 2025 14:06:20 +0200 [thread overview]
Message-ID: <asxbkez3pwoc2p4jb5ftwbvapzvoj3kma2tunprrnp4ptihebb@dxhvj3uicw6c> (raw)
In-Reply-To: <03b53f18-8c16-4716-8ed4-1902d7247354@suse.cz>
On Mon, Mar 10, 2025 at 12:37:25PM +0100, Vlastimil Babka wrote:
> On 3/10/25 09:28, Kirill A. Shutemov wrote:
> > Watermarks are initialized during the postcore initcall. Until then, all
> > watermarks are set to zero. This causes cond_accept_memory() to
> > incorrectly skip memory acceptance because a watermark of 0 is always
> > met.
>
> What are the user-visible consequences of that?
Premature OOM on boot.
It can be triggered with certain combinations of number of vCPUs and
memory size.
> > To ensure progress, accept one MAX_ORDER page if the watermark is zero.
> >
> > Signed-off-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
> > Reported-and-tested-by: Farrah Chen <farrah.chen@intel.com>
>
> Fixes:, Cc: stable etc?
Fixes: dcdfdd40fa82 ("mm: Add support for unaccepted memory")
Cc: stable@@vger.kernel.org # v6.5+
--
Kiryl Shutsemau / Kirill A. Shutemov
next prev parent reply other threads:[~2025-03-10 12:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20250310082855.2587122-1-kirill.shutemov@linux.intel.com>
2025-03-10 11:37 ` Vlastimil Babka
2025-03-10 12:06 ` Kirill A. Shutemov [this message]
2025-03-11 20:15 ` Vlastimil Babka
2025-03-12 19:14 ` Gupta, Pankaj
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=asxbkez3pwoc2p4jb5ftwbvapzvoj3kma2tunprrnp4ptihebb@dxhvj3uicw6c \
--to=kirill.shutemov@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=ashish.kalra@amd.com \
--cc=david@redhat.com \
--cc=farrah.chen@intel.com \
--cc=linux-coco@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
--cc=rick.p.edgecombe@intel.com \
--cc=rppt@kernel.org \
--cc=thomas.lendacky@amd.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox