From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30833C25B76 for ; Sat, 1 Jun 2024 06:46:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id ACD256B00B2; Sat, 1 Jun 2024 02:46:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A7DF86B00B3; Sat, 1 Jun 2024 02:46:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9455D6B00B4; Sat, 1 Jun 2024 02:46:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 777C26B00B2 for ; Sat, 1 Jun 2024 02:46:51 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 3F323161292 for ; Sat, 1 Jun 2024 06:46:51 +0000 (UTC) X-FDA: 82181387022.03.12DC585 Received: from out-177.mta1.migadu.com (out-177.mta1.migadu.com [95.215.58.177]) by imf29.hostedemail.com (Postfix) with ESMTP id 28FF6120009 for ; Sat, 1 Jun 2024 06:46:48 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=Tpq11TBP; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf29.hostedemail.com: domain of shakeel.butt@linux.dev designates 95.215.58.177 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717224409; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=sjLZZRzBZcTCQY3kC3rZ1Hok+tlDm5Px6KNoO2+Q8ls=; b=0igOzIVhMtkflx6pTC2TbHIBm1bvtCXZnpkJOs/EM56fIWW0eaRk/Hd2CxWQPW4TgknqgR IjrNWrj0wrw9h1+MzmCqIFUGfURnOR+gOYzY0edsrU7zIAcDFsHlx3VF5+Gc1BW8lV4GGY SRtJSILOFKPTprKp9f15FVs/GYiZ5Rc= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717224409; a=rsa-sha256; cv=none; b=c8gsigW2gg7hFWDHP3M0XqvrHblCVka/oAafeOYUf4G4JM69SpXmNuUfgJC6JQCggDoWwZ XJVBwIV50gpvrAXNK50hx9vpRrRg3XNq4r5+6KqMG8iG8gIlUSlZPKgoxQyhF0NeanHVoq Vf+qC1ivWrDJkJqFzm/OQ9K7WZLezFw= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=Tpq11TBP; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf29.hostedemail.com: domain of shakeel.butt@linux.dev designates 95.215.58.177 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev X-Envelope-To: roman.gushchin@linux.dev DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1717224407; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=sjLZZRzBZcTCQY3kC3rZ1Hok+tlDm5Px6KNoO2+Q8ls=; b=Tpq11TBPzvCXFAe+S4KdI4ASzj2MnffMgdB+YBmPKZXNVUgNGAsz0nJIdkonmlmSRBflwj pvMHYWk6wPbKsifnfkYPY1oCs8FB7zYUNCay4esXuhFOeaL6j+ZzGmGBWIq5uu0gj5by9D +zUBny/uXuH/ztNkMD1V9G1k2YIreOA= X-Envelope-To: akpm@linux-foundation.org X-Envelope-To: muchun.song@linux.dev X-Envelope-To: hannes@cmpxchg.org X-Envelope-To: mhocko@kernel.org X-Envelope-To: willy@infradead.org X-Envelope-To: linux-mm@kvack.org X-Envelope-To: linux-kernel@vger.kernel.org Date: Fri, 31 May 2024 23:46:43 -0700 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Shakeel Butt To: Roman Gushchin Cc: Andrew Morton , Muchun Song , Johannes Weiner , Michal Hocko , Matthew Wilcox , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 08/14] mm: memcg: move cgroup v1 oom handling code into memcontrol-v1.c Message-ID: References: <20240528202101.3099300-1-roman.gushchin@linux.dev> <20240528202101.3099300-9-roman.gushchin@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240528202101.3099300-9-roman.gushchin@linux.dev> X-Migadu-Flow: FLOW_OUT X-Stat-Signature: qiqmc15txuqj93n8a3j4xoo5xzzdcoj7 X-Rspamd-Queue-Id: 28FF6120009 X-Rspam-User: X-Rspamd-Server: rspam01 X-HE-Tag: 1717224408-607673 X-HE-Meta: U2FsdGVkX1/13uJX7f9nj0T2HxbA3v0/y5YmaUQkqI/wKxsiZJSr8coPTKdPZqp3dPX7LkOuauYuurKCiTEVX1YfRJA/pAwGOJxJIDUjQMknfTuH8YqAblZzjNJxB87RRD4ggqpyt/gstSJTV/4e+ozj3zhdgUGYxwVvmLbjXrk47PUuP1hZc4q+xd1azCMuQaPDmqopNVS7CkvMgvJJ+2W0heDSpIPFbHTfOyZWPUVf59aKRAVDpz4ur9be2HVJKLDpgcg/77bl1n5E7yG0xEl/X6IOLHQrIfOW1pkN7wl4ozG4coGiEdc9EmZlm5vUMZGvsdbGS2DWkKAe8pHUzm9zulh/94a4ocW4EZOfeQ6xMisgIpOid2QmpN8KRs/z1d1kQdFjFUEOmWVnEEu3blfzyK2pwU115vsfUceUZHsKsuw2YOGdD1qWqmkfPzqV9LOtaOG2Cnm9OY0h4CoA61bPz5cB+oWZImcLZ6XtraW9WMdqq6a2i2R32yHYF5EYbtDhMN9mvwwbIRvrY2NFYhc8g2mlH58oiN45LuLIZN22HIqin4DpO9yQUKTcTEOQaAwElZlsbktw2KGCK0mJFthRb1WZdlWdNyZ5n26I+czwYq5xWn2CQTU8mb2xAOAkoYxlLPmQYUGMCSWCTgcQg8dFziiel6TBBveaPukk84ZhJisBPn4LuPqL+YK6C8uGVeAn+aUXMqbVS0AsgQygNUUgvLc2N08VadswelziMbGgHQgOUZwuudjT3qNVZdFdIm2AwB3HubRt56hN6ZSyFiR4HP9emTW7t6UYoFtmVfK5jCQ9V9FT8OjRtSQWAxkckV8FTCIcp/a+Hb1l+43JRurlM4ibzkVK0CZBEANfn/HYEv5zGr1FPjTrnzkD2jY2g0Qq6gKJGSWArZ+jzAsdj41PB7F+oRXhDFo95Y6mTWu/N9ydwF1anK2Cv1/c+Fk7oclq2+37keA9IJYfHB/ edB8RyIc sUgtPBY517qgCqWFzzzdBSVgd+DkOzXbTQef3AbFEeLENEUDYMz6zS+APBytqbcUnlW8di+gBJpG1dg6Ep4kz8KahmQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, May 28, 2024 at 01:21:00PM GMT, Roman Gushchin wrote: > Cgroup v1 supports a complicated OOM handling in userspace mechanism, > which is not supported by cgroup v2. Let's move the corresponding code > into memcontrol-v1.c. > > Aside from mechanical code movement this patch introduces two new > functions: memcg1_oom_prepare() and memcg1_oom_finish(). > Those are implementing cgroup v1-specific parts of the common memcg > OOM handling path. > > Signed-off-by: Roman Gushchin Acked-by: Shakeel Butt