From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89109C3DA70 for ; Tue, 30 Jul 2024 15:46:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EE9FD6B008A; Tue, 30 Jul 2024 11:46:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E99C56B008C; Tue, 30 Jul 2024 11:46:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D61916B0092; Tue, 30 Jul 2024 11:46:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id B6D0C6B008A for ; Tue, 30 Jul 2024 11:46:28 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 4E574A445C for ; Tue, 30 Jul 2024 15:46:27 +0000 (UTC) X-FDA: 82396846014.18.214DBF2 Received: from mail-ej1-f48.google.com (mail-ej1-f48.google.com [209.85.218.48]) by imf11.hostedemail.com (Postfix) with ESMTP id 274B040007 for ; Tue, 30 Jul 2024 15:46:24 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=fiwgWeTi; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf11.hostedemail.com: domain of mkoutny@suse.com designates 209.85.218.48 as permitted sender) smtp.mailfrom=mkoutny@suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1722354324; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=yRC8EpL8O0R6ThyQIF5jdND8pmO+k3m9i0jeg+m0dq0=; b=EpWDOh6ACpZw2mHxjWcWA1b0UobhfFAdrwHtUcKAY2p4sjuGBY/UBjOs+5RlQQTDGy/zIC TN4yyTu8MFekk4IWeRWicJpOIFn5BquF7dBr1/JAssiVQ46DgBSoKoLrO8m5kfAZBUxTue znl2w3exh9aUJKGC/ak/o1lCO4WiPLQ= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1722354324; a=rsa-sha256; cv=none; b=x1h2q+5xKt59D76V0uItq1wYIfkglpfQzfF5iQoMxvA9J2hhhkqqx3MvAXB+2zTPumvabb TrVRgqgBnseIzq9hT97Y03y3jI7L1AiMaYBGmGnXQUMhl1pSks8DaES7Qi1pUxHClJsqll lXEp+zkZFom2vtENhqV5x0t9/U5hQmQ= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=fiwgWeTi; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf11.hostedemail.com: domain of mkoutny@suse.com designates 209.85.218.48 as permitted sender) smtp.mailfrom=mkoutny@suse.com Received: by mail-ej1-f48.google.com with SMTP id a640c23a62f3a-a7a8e73b29cso352815566b.3 for ; Tue, 30 Jul 2024 08:46:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1722354383; x=1722959183; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=yRC8EpL8O0R6ThyQIF5jdND8pmO+k3m9i0jeg+m0dq0=; b=fiwgWeTi/A3igUkMPX0gk02gGhBLBW3krihu7rVgVkiQ615r+eAvjkX9AE5SBoAXRM kQ69cXfYwnY2uADyqmQxrFD/QMp6bsOqMjqp04fO06qioxi1Dnlm8woh8p9UZVE6QYZV oVjEQwX3Ldlv4ChcWae5cXzw6mBaKwMWFWzKrMehDl32vnfE5Jwa936z3oCcHIySncYh D80jhLxQOA7pNNRifjt08M2QQvF7ns53KM9EPrKkOXXHjD8MKEjzBpF9HqiOSMu1RW7X ZzEs8qfyNd+3cfcL16RA4y/9EMb9HU4x4y5D59yHrpRsOOa1+enb32fSVRUnm7C5Wiq8 4Fyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722354383; x=1722959183; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=yRC8EpL8O0R6ThyQIF5jdND8pmO+k3m9i0jeg+m0dq0=; b=PFMrErYILwihtFidEZY6MeejrtVOP//fZ7WTXsDk3/cMgszPgPIhhG6HP+mq+Ln6Fy NLWRxJ3K66LWjn59vd/B2MLdHy46u1os8l01RR0nPDF8atkY/1jmIDPajWgwWYtyDqnu Xf00KvLoTshXI4TM3EEYaZTbylFRnDIByELyBDQU9zUHwu+ejPdec+/95zAEKPbtQpmf e5F8h9YToOGJWjKWmM3eVXxVWNxWqos7XIP3PhetajBgGUxv/hU9lRvwUSKqINmOyYQR NVczSEf3JysneViMDKTX0+JCc9nOQIW+o1oHi2HRa6fO+DQvCNXsJB4rWXMMEez5ZxbG Nk0Q== X-Forwarded-Encrypted: i=1; AJvYcCU+P85zTs7uGyC64awMcOO42yvatVL8PvUiPOnkSHCj9Jc+nm6k9J9xe6Ae66Qh6s15lPNKAvV8xIORAuZv3EgY6+U= X-Gm-Message-State: AOJu0YxEI9VP0wRSMYoVxrJdMfZUOFG/AQkLIg+Whw3V2my+7aQKhYIB Qihib0Qz5kU5LjYAjs+65LNepiyFSjFpsTi7sbjotDsigykcOOV2unxCzwwEGqc= X-Google-Smtp-Source: AGHT+IEfShq2dlD0DfRiwM7bhyC9H1giL0hs81+b3W/KP3MMitXJ+IPNIAfmGBJOB3tFyCz+0fCaCg== X-Received: by 2002:a17:907:8692:b0:a6f:e47d:a965 with SMTP id a640c23a62f3a-a7d40064576mr768295166b.41.1722354383418; Tue, 30 Jul 2024 08:46:23 -0700 (PDT) Received: from blackdock.suse.cz ([193.86.92.181]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a7acab23125sm659769766b.1.2024.07.30.08.46.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jul 2024 08:46:22 -0700 (PDT) Date: Tue, 30 Jul 2024 17:46:21 +0200 From: Michal =?utf-8?Q?Koutn=C3=BD?= To: David Finkel Cc: Muchun Song , Tejun Heo , Roman Gushchin , Andrew Morton , core-services@vimeo.com, Jonathan Corbet , Michal Hocko , Shakeel Butt , Shuah Khan , Johannes Weiner , Zefan Li , cgroups@vger.kernel.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH v6 2/2] mm, memcg: cg2 memory{.swap,}.peak write tests Message-ID: References: <20240729143743.34236-1-davidf@vimeo.com> <20240729143743.34236-3-davidf@vimeo.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="5y6eempyzjoj5ljb" Content-Disposition: inline In-Reply-To: <20240729143743.34236-3-davidf@vimeo.com> X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 274B040007 X-Stat-Signature: spu775t4mdn8xfxeay8uh9fh1y933k4t X-Rspam-User: X-HE-Tag: 1722354384-318224 X-HE-Meta: U2FsdGVkX19qj9kfas1MCObG8oSHrcCaAUIjKT2muUpewxAL29iVxnQWXAbcDhAd02xRU9S4tf+fibvr0FMTnqOqbXDE284iqzA2vjOzmpaal9KioqUf1gmL2RRu5GggbPcQOdeMXWtzwM7Rzy3hVczQaWcPwpDAauGTICiCr0/ADdEv97+ikTTuuUF9BByACIwpZYZVsPPoI6uCuAYcf/QtFYur29GF6Mw8NfNIvH4Uhzeu9vodF9lAps14aCajP+Y01Jt6xN+xOoj4R2J3j2qhNyuRZJhbCxnHedTwCZoxSiZU+mQLKaQZYSkUn1lhlsiswIRB9YqQORWe4inGm4jb6XsHWyFSN9rXtig7cjF6pbqRbbjdLVBupNirqqEqQTgxVX0vhbE0cB8SG2yKp9mzVgd4A2QAAorEMmTOGCLU6RulYyNfnF+IopldOfP+nK+fs2PNF0nUiW9Pqv9NU/+qljXknyrO627b1uW07E81RdrYRdBe/rywHMJe/x0u87RgvY/yIwlCTiPfewOwCm01elXRdYjLzTOQ6mUbfjdjvGKdpA5MS74aPcSSlIFt+mKW2BuNy4bM92Rf9PoIc8u0K7qqXijdOfIz4GcH2AuJKdtM2/0oNnCDaMSgoTgRKjwd3tYSXNGtJ2BreWAho07JCmQHcHm9mM+jVYUzLbAICyPUrDiBYVjns9enWZPh4UX8/2dAL4SA8gyoi8AVl5HmRdyQmFSdqeW0zSf2mPw6mRYI/ba7USdY20ztkJB/rJShfJ4I81Id3623xOnrSang+F++lV2hzViVSg+Ys/wxo7xLzW57mL0vtXi8Ev1dqweoNf7OT4yjCs+V2yPje7tTp/1w2zKcs/vfD6daHQiDfyY8hMnpV3rE4xhpe4OTn2Q4FoWl76dmO5w6mag9KcNg+VBmeOjF8bnqv+5/z7ylIP8moGTykZvfMx8h++5aS1c/Hy5Z0a84g+23udh Qt2PC+fK qo5oIFcsDhUmduMW1ZcRnohHGjBYT3AXMCqlnQHpPlBwT8KoJJNZ0Q5HJjbfTrRiRUj4VudWocnNC2SXuKRj7n2eCQeH2M3bVfnUdVOffRRdKZnGoxz65aeU/S9BHvZgkuYO//GgxsO+waEVzAcA6TP2qEuCkfePx0leQB1Z4MrOs5r915HBSwtk9AIIT/44R4z7RvUOWLf92bDgRcFVyYuF4v266EV5dzCDFdl9x1CUR7U1RS4CctWFClxK/gooxEkfpx3aBN/NnM+/1WFjGP/+iaozp1nXeSHQK170O8Epj/ojlz5fqHYLHQSE7dNqCzDPx/4vIRqILT/FNg6faFURsJeRJGhUKMS7jO4GKUVipFN334bTFv/LCKZwa1Ripi7/vaQxUVxFIQgi1sXjWrh4wnbnNVHWI/FNYI0GWFD1GTdgqFpp5XRpWeg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: --5y6eempyzjoj5ljb Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hello. On Mon, Jul 29, 2024 at 10:37:43AM GMT, David Finkel wrote: > Extend two existing tests to cover extracting memory usage through the > newly mutable memory.peak and memory.swap.peak handlers. BTW do the tests pass for you? I gave it a try (v6.11-rc1+your patches) $ grep "not ok 2" -B30 test.strace ... 315 15:19:13.990351 read(6, "\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0"..., 4096) = 4096 315 15:19:13.994457 read(6, "\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0"..., 4096) = 4096 315 15:19:13.998562 read(6, "\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0"..., 4096) = 4096 315 15:19:13.998652 read(6, "\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0"..., 4096) = 4096 315 15:19:14.002759 read(6, "\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0"..., 4096) = 4096 315 15:19:14.006864 openat(AT_FDCWD, "/sys/fs/cgroup/memcg_test/memory.current", O_RDONLY) = 7 315 15:19:14.006989 read(7, "270336\n", 127) = 7 315 15:19:14.011114 close(7) = 0 315 15:19:14.015262 close(6) = 0 315 15:19:14.015448 exit_group(-1) = ? 315 15:19:14.019753 +++ exited with 255 +++ 313 15:19:14.019820 <... wait4 resumed>[{WIFEXITED(s) && WEXITSTATUS(s) == 255}], 0, NULL) = 315 313 15:19:14.019878 --- SIGCHLD {si_signo=SIGCHLD, si_code=CLD_EXITED, si_pid=315, si_uid=0, si_status=255, si_utime=1 /* 0.01 s */, - 313 15:19:14.019926 close(3) = 0 313 15:19:14.020001 close(5) = 0 313 15:19:14.020072 close(4) = 0 313 15:19:14.024173 rmdir("/sys/fs/cgroup/memcg_test") = 0 313 15:19:14.028517 write(1, "not ok 2 test_memcg_current_peak"..., 33) = 33 grep "^315 .*read.*4096" -c test.strace 12800 Hopefully, unrelated to your changes. I ran this within initrd (rapido image) so it may be an issue how rootfs pagecache is undercharged (due to sharing?), instead of 50M, there's only ~256k. To verify, I also tried with memory.peak patch reverted, failing differently: ... 238 15:30:29.034623 openat(AT_FDCWD, "/sys/fs/cgroup/memcg_test/memory.current", O_RDONLY) = 3 238 15:30:29.034766 read(3, "52801536\n", 127) = 9 238 15:30:29.038895 close(3) = 0 238 15:30:29.043048 openat(AT_FDCWD, "/sys/fs/cgroup/memcg_test/memory.stat", O_RDONLY) = 3 238 15:30:29.043230 read(3, "anon 52436992\nfile 0\nkernel 1105"..., 4095) = 870 238 15:30:29.047379 close(3) = 0 238 15:30:29.051491 munmap(0x7f2473600000, 52432896) = 0 238 15:30:29.058516 exit_group(0) = ? 238 15:30:29.062992 +++ exited with 0 +++ 237 15:30:29.067054 <... wait4 resumed>[{WIFEXITED(s) && WEXITSTATUS(s) == 0}], 0, NULL) = 238 237 15:30:29.067136 --- SIGCHLD {si_signo=SIGCHLD, si_code=CLD_EXITED, si_pid=238, si_uid=0, si_status=0, si_utime=1 /* 0.01 s */, si- 237 15:30:29.067210 openat(AT_FDCWD, "/sys/fs/cgroup/memcg_test/memory.peak", O_RDONLY) = 3 237 15:30:29.071349 read(3, "52805632\n", 127) = 9 237 15:30:29.075470 close(3) = 0 237 15:30:29.075562 openat(AT_FDCWD, "/sys/fs/cgroup/memcg_test/memory.peak", O_RDWR|O_APPEND|O_CLOEXEC) = 3 237 15:30:29.079712 openat(AT_FDCWD, "/sys/fs/cgroup/memcg_test/memory.peak", O_RDWR|O_APPEND|O_CLOEXEC) = 4 237 15:30:29.083848 openat(AT_FDCWD, "/sys/fs/cgroup/memcg_test/memory.peak", O_RDWR|O_APPEND|O_CLOEXEC) = 5 237 15:30:29.083970 write(3, "reset\n\0", 7) = -1 EINVAL (Invalid argument) 237 15:30:29.088095 close(3) = 0 237 15:30:29.092209 close(4) = 0 237 15:30:29.092295 close(5) = 0 237 15:30:29.096398 close(-1) = -1 EBADF (Bad file descriptor) 237 15:30:29.100497 rmdir("/sys/fs/cgroup/memcg_test") = 0 237 15:30:29.100760 write(1, "not ok 2 test_memcg_current_peak"..., 33) = 33 This failure makes sense but it reminded me -- could you please modify the test so that it checks write permission of memory.peak and skips the reset testing on old(er) kernels? That'd be in accordance with other cgroup selftest that maintain partial backwards compatibility when possible. Thanks, Michal --5y6eempyzjoj5ljb Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQTd6mfF2PbEZnpdoAkt3Wney77BSQUCZqkKygAKCRAt3Wney77B SRUAAP4/N9esJbrEK3Dc8W7fMPFhJO2vSYHkWLaM8DmxVvSNLwD/e6VjqMIAdSUh SFcFj4YkO6Uy6D5wFhGyjPQbmHi3lwg= =GgTK -----END PGP SIGNATURE----- --5y6eempyzjoj5ljb--