From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D06CC7115B for ; Fri, 20 Jun 2025 17:42:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id ACEE26B0093; Fri, 20 Jun 2025 13:42:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AA63A6B0095; Fri, 20 Jun 2025 13:42:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9E2D56B0096; Fri, 20 Jun 2025 13:42:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 8E45B6B0093 for ; Fri, 20 Jun 2025 13:42:17 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 3501B103FE8 for ; Fri, 20 Jun 2025 17:42:17 +0000 (UTC) X-FDA: 83576497914.10.5293D64 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.9]) by imf16.hostedemail.com (Postfix) with ESMTP id A046918000C for ; Fri, 20 Jun 2025 17:42:14 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=lAyEZ8Je; spf=none (imf16.hostedemail.com: domain of kirill.shutemov@linux.intel.com has no SPF policy when checking 192.198.163.9) smtp.mailfrom=kirill.shutemov@linux.intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750441335; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=T1RrlpewBOyJdPcjeYiLynL7H1qUOyJqzvGEMPiki9M=; b=zZ0uLdlNpU0PZEi34y8WkYHZrOLiQcd9VMSuSESki+/LxpZIuHJT+b5YhBomBbmPsKKvYW aRlLJU3AjeomaBO4/8qpDjhQgxcZiH3pxZhftzV67MJHIGbwMWWiZ6IF30KlCp0sRqryen REwLpGNwNkEqVdI5DXZxvyiHYy+1+zE= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=lAyEZ8Je; spf=none (imf16.hostedemail.com: domain of kirill.shutemov@linux.intel.com has no SPF policy when checking 192.198.163.9) smtp.mailfrom=kirill.shutemov@linux.intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750441335; a=rsa-sha256; cv=none; b=qM4r6A3yPkH+530Q06lgN1s/RygZSaN71c0d0CVdYT5PK/0pifafC7SppGYEnyGktdwU1v 9+xVv+x2b0IAwBNy0JkjeKOz0hxJlW9r6vHZFb46Ic4MJocQ9Xl9Y5BRXew+BkQJ2POJEM zJvc4+7lvGOAJSjGXAf/EWflARG/JEs= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1750441334; x=1781977334; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=+d8rWtAZJO4o7jYg3VVESTCyMRK/oKsbIChLqwzbf0k=; b=lAyEZ8JeIWaxE/7CIH0xhLVGxj87APxxhZHoTc82l5QlIHs+EZ5A9qKf Jn5UezPw5xkScEy40xjJaAL0WITqXnplEdna+Y9B4IRFQYCpN0XAGGuzq uqoqWzHMHPHwDGMhD25/5ElF4dtWWLwuyaJ7Wn2TzWc3TZzJPyTSn8NUW gJsglbJpQ9mx+eElPgXBY++mXKsR6azW+VpF4CCn6Qw6FYl52JX+ZuqOT MRl8/dN+Klbn0CPn54vepZYjTKBuN2a6mWJMVQcaNxAYE8gomyP8fPk5p KZva+ZvwTDCpODAAoC30c0yvneXHIWaqZFf/2n3Kdl1GsnSOh/0LQQ+kS g==; X-CSE-ConnectionGUID: R3lct4Z8T4WaDgQ3r47Xyg== X-CSE-MsgGUID: ltDNOlvTQnii2u5xljINkw== X-IronPort-AV: E=McAfee;i="6800,10657,11469"; a="63396420" X-IronPort-AV: E=Sophos;i="6.16,252,1744095600"; d="scan'208";a="63396420" Received: from orviesa008.jf.intel.com ([10.64.159.148]) by fmvoesa103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Jun 2025 10:42:13 -0700 X-CSE-ConnectionGUID: Jz2GhDOiQICSKlR67fCgag== X-CSE-MsgGUID: K38Nbuk0TT+ExDsKqRqDHQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.16,252,1744095600"; d="scan'208";a="151514115" Received: from black.fi.intel.com ([10.237.72.28]) by orviesa008.jf.intel.com with ESMTP; 20 Jun 2025 10:42:02 -0700 Received: by black.fi.intel.com (Postfix, from userid 1000) id 4B1EE109; Fri, 20 Jun 2025 20:42:00 +0300 (EEST) Date: Fri, 20 Jun 2025 20:42:00 +0300 From: "Kirill A. Shutemov" To: Dave Hansen Cc: Andy Lutomirski , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Peter Zijlstra , Ard Biesheuvel , "Paul E. McKenney" , Josh Poimboeuf , Xiongwei Song , Xin Li , "Mike Rapoport (IBM)" , Brijesh Singh , Michael Roth , Tony Luck , Alexey Kardashevskiy , Alexander Shishkin , Jonathan Corbet , Sohil Mehta , Ingo Molnar , Pawan Gupta , Daniel Sneddon , Kai Huang , Sandipan Das , Breno Leitao , Rick Edgecombe , Alexei Starovoitov , Hou Tao , Juergen Gross , Vegard Nossum , Kees Cook , Eric Biggers , Jason Gunthorpe , "Masami Hiramatsu (Google)" , Andrew Morton , Luis Chamberlain , Yuntao Wang , Rasmus Villemoes , Christophe Leroy , Tejun Heo , Changbin Du , Huang Shijie , Geert Uytterhoeven , Namhyung Kim , Arnaldo Carvalho de Melo , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-efi@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCHv6 04/16] x86/efi: Move runtime service initialization to arch/x86 Message-ID: References: <20250620135325.3300848-1-kirill.shutemov@linux.intel.com> <20250620135325.3300848-5-kirill.shutemov@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: A046918000C X-Rspam-User: X-Rspamd-Server: rspam07 X-Stat-Signature: 6i43uxtbr8ub5ymnienk8ewszxm1brhp X-HE-Tag: 1750441334-421445 X-HE-Meta: U2FsdGVkX1+0Y2AWM21cO4Qc2AmH0Rm1C61CfCJEld1pqZdrAYu1VvRN/nl7AeVunjs9yF5DaOUUZaeICPm4Ndg1mUVr68jr4rSmncWfgxSt8eekGZxWsHhOEYUs2WFZtivtWsR5b6REJbKsNzZ4wrAGVVP9lLUmiolX8pK2hYwHE1KvlLd2A4WMSSKZd68NY7K5RHk5rHVR6pv6NrrRrLhvzZ7Of+Jaw+zqTvZ+PJYOONU90Gef4NG4uavW6uB6eieVR3owU7wUpDtzX7yywTjLC/dim849ANW7fPMj2flPgWK9oAyRTyC1+s9YdFnfjlDh1tWCyGrABMH8xes6GWyGBj72xgnJMmlobPtd5PUmMld0K8SOav+Lb4eeeIg45es5K8gagLp+6gbRjI+vBjWIi9mOuU1UEvw0gGrRsdkd1j6MXdWBK1Nyz3EqYYLZ3SquOYbzcGw5f1jOO8m0GmvtGzQMg3ntldF91od9cxyyms5rq5TUQbDcTxUyN+wZeSsx1dOvkUiTsW2gYr8R9FH9ONRrmjHpB81k3WhnrAMsCFPHX1xdtr8LZ4bKkYagl9J3MGzPzUgVszEoajJmEYFBoraeUk6Cxjc2ZvU2X9q71swQAMD2IR3NG2nyqVAMZ47ppHwfAKHYK4Oh8PfDwq7f41fYu9J6QtVV6FBgERvOfYV/cVyL4GW0+TyPvSC3eoMUdiFdIQeNqpZipbDTwoYJljJ1aJVJjbt3w+JxjiaZ2cFFP95Y77DmDbpvo9fx8gsslc03ZOFUZB++hZyR33VS1A6Ggobm8metjspofTVwMVjHAKHBCf+pp08NIdhiA5hBF0he0ZQFNt/0Lnd9toub0ROSi6dL85a6z/bNqFlhFn2Ff8bVc8z8ozDeX70pDLUyADo+MKlm9l65Rvpm1eI7DjOaTthQ1//GdT5A0Tdm+SwHvph/tg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Jun 20, 2025 at 08:35:14AM -0700, Dave Hansen wrote: > On 6/20/25 06:53, Kirill A. Shutemov wrote: > > From: Alexander Shishkin > > > > The EFI call in start_kernel() is guarded by #ifdef CONFIG_X86. Move > > the thing to the arch_cpu_finalize_init() path on x86 and get rid of > > the #ifdef in start_kernel(). > > What does this have to do with LASS? It is required to move CR pinning below it and allow to disable CR4.LASS temporarily during EFI initialization. > Is there any reason not to just pull this in to tip now as a cleanup? It > looks good regardless of what it does to LASS. I am totally fine with applying it right away. -- Kiryl Shutsemau / Kirill A. Shutemov