From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6041DC433F5 for ; Wed, 9 Feb 2022 15:42:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B14CA6B0074; Wed, 9 Feb 2022 10:42:57 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id AC38E6B0075; Wed, 9 Feb 2022 10:42:57 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9B2976B0078; Wed, 9 Feb 2022 10:42:57 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0215.hostedemail.com [216.40.44.215]) by kanga.kvack.org (Postfix) with ESMTP id 8B2A56B0074 for ; Wed, 9 Feb 2022 10:42:57 -0500 (EST) Received: from smtpin22.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 4C1F78B75D for ; Wed, 9 Feb 2022 15:42:57 +0000 (UTC) X-FDA: 79123659594.22.5B049BE Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf17.hostedemail.com (Postfix) with ESMTP id AE42940003 for ; Wed, 9 Feb 2022 15:42:56 +0000 (UTC) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id 7205821106; Wed, 9 Feb 2022 15:42:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1644421375; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=cPanT84froBQDy0fnPPljPjc/sJJc6UFVNaQtZQNyJo=; b=SdlN6/o0bkHJLdF7/rqstxANEqRu2FGQdADvtFm36FXgWN7qy8cv5E9FmMIqemtYqj5JCx jcFKtYvkxRDAXyWddaU5BJQjRCKUXa8uB96+IfTENqG3s4IjsNq2JfIo9n1aVAoh4vUxkN ye8z9cU4lRKUrZHOL79VeCmsS2uUcBg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1644421375; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=cPanT84froBQDy0fnPPljPjc/sJJc6UFVNaQtZQNyJo=; b=0X+aVbHtAO76L1P2h7Y2RgH4e7i5tXnnZmX6Tcr6MKy1WuACuL/CGsKG7z3DXWtcr4kHZJ FFE4oGuZFBJRVUCA== Received: from pobox.suse.cz (pobox.suse.cz [10.100.2.14]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id 5BFF8A3B88; Wed, 9 Feb 2022 15:42:55 +0000 (UTC) Date: Wed, 9 Feb 2022 16:42:55 +0100 (CET) From: Miroslav Benes To: Christophe Leroy cc: Luis Chamberlain , Jessica Yu , "linux-kernel@vger.kernel.org" , "linuxppc-dev@lists.ozlabs.org" , "kgdb-bugreport@lists.sourceforge.net" , "linux-mm@kvack.org" , "linux-arch@vger.kernel.org" Subject: Re: [PATCH v2 0/5] Allocate module text and data separately In-Reply-To: Message-ID: References: User-Agent: Alpine 2.21 (LSU 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Rspamd-Queue-Id: AE42940003 X-Stat-Signature: 5ws5qtej3m69bj55jt1cka9mef9moq6c Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="SdlN6/o0"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=0X+aVbHt; dmarc=none; spf=pass (imf17.hostedemail.com: domain of mbenes@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=mbenes@suse.cz X-Rspamd-Server: rspam06 X-Rspam-User: X-HE-Tag: 1644421376-982104 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, 27 Jan 2022, Christophe Leroy wrote: > This series allow architectures to request having modules data in > vmalloc area instead of module area. > > This is required on powerpc book3s/32 in order to set data non > executable, because it is not possible to set executability on page > basis, this is done per 256 Mbytes segments. The module area has exec > right, vmalloc area has noexec. Without this change module data > remains executable regardless of CONFIG_STRICT_MODULES_RWX. > > This can also be useful on other powerpc/32 in order to maximize the > chance of code being close enough to kernel core to avoid branch > trampolines. > > Changes in v2: > - Dropped first two patches which are not necessary. They may be added back later as a follow-up series. > - Fixed the printks in GDB > > Christophe Leroy (5): > modules: Always have struct mod_tree_root > modules: Prepare for handling several RB trees > modules: Introduce data_layout > modules: Add CONFIG_ARCH_WANTS_MODULES_DATA_IN_VMALLOC > powerpc: Select ARCH_WANTS_MODULES_DATA_IN_VMALLOC on book3s/32 and > 8xx > > arch/Kconfig | 6 ++ > arch/powerpc/Kconfig | 1 + > include/linux/module.h | 8 ++ > kernel/debug/kdb/kdb_main.c | 10 +- > kernel/module.c | 193 +++++++++++++++++++++++++----------- > 5 files changed, 156 insertions(+), 62 deletions(-) Looks good to me apart from the typo I mentioned at v1. I will review again once it is rebased on Aaron's patch set. Regards, Miroslav