From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.8 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1, USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91822C433B4 for ; Fri, 23 Apr 2021 20:09:02 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 006976144E for ; Fri, 23 Apr 2021 20:09:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 006976144E Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 6416F6B0036; Fri, 23 Apr 2021 16:09:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6179C6B006C; Fri, 23 Apr 2021 16:09:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 46B936B006E; Fri, 23 Apr 2021 16:09:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 26AE66B0036 for ; Fri, 23 Apr 2021 16:09:01 -0400 (EDT) Received: from smtpin35.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id CD11F1269 for ; Fri, 23 Apr 2021 20:09:00 +0000 (UTC) X-FDA: 78064720440.35.9B8EFE8 Received: from mail-qk1-f182.google.com (mail-qk1-f182.google.com [209.85.222.182]) by imf16.hostedemail.com (Postfix) with ESMTP id 8912F80192F0 for ; Fri, 23 Apr 2021 20:08:58 +0000 (UTC) Received: by mail-qk1-f182.google.com with SMTP id t17so22386993qkg.4 for ; Fri, 23 Apr 2021 13:09:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=aK8iz3zm04xOuoxeCmMxLwgvro5ZujIcNZdrYiQYSqw=; b=CA/6bq0RQgR39iQYo3JaGJ3rhlMNTFg6Kp52Q9HfsiTEIksa18HN+fGFPH4Vpl9Lih VHl3FWjZ5xDxzUyrFLH7zB1fnKywzv5TKjJr3DeKTfyzYo9N6wxpIVpbFGvamk2mNH9l bNtBr5OD9aHHaEBZxo3Qsv4zXEQLTXvX0mHYageo00UQXDp3d/abDfjJmMuhHQOx0vIv EcUqYxQO7vq78dVd5OlBG0o7MP4T952lErPJut9Kl9OMTHpWUOtdazSW4RyOj2VdlJQn k63IbKsCqXPO0f9r8jT4f8/1fPqiCx7GydKYLn9fftipvTZ+EZY3Ftic4v0D3dsQvbEW KnWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=aK8iz3zm04xOuoxeCmMxLwgvro5ZujIcNZdrYiQYSqw=; b=q7heeSOKdPxGJoxPYoKX3XYMnMq9CSs6hjs8gm+1uAJQGq8y2sxE+LeW7dKk2nHztE wXTUGn3kYfiGLqSqyuo/7AEqFkr/4izRiu37kwRuNraoCvJhAxI2II7R/SKXjSAwykma 2whmXco88vXSdCPX0JUx/bBmXh3BX1qQaAIkAQ3iNKeqPLk+0BDTq6G/1p/GFvjGJUwt GSJ+SmpJPIPTy3YrXY40A1zfw/O62jRcuYgFhnlp+X0cglACKrpi7DPEZCXHcyCuqrvJ 3e5SczIUFkFzVv22Z/DRRG8u/1ZryMk4/wFUxIjVwQePG/+gREXsTXCX6LKCfKAXggjq Mdeg== X-Gm-Message-State: AOAM532A/OVvpucnzwXS5TM7yt15z/B91yuFVUrdfnKErGN3Uo8k7imt Yot1NWWDxmIo/JK0DvNhpBNWAw== X-Google-Smtp-Source: ABdhPJyh9pNSKDLnATFK2Hm5RgriFDYoCipfaWR58npPvwxnUU+kGd/Y/FkZNtq7A1mgkBx15YVUmg== X-Received: by 2002:a05:620a:1350:: with SMTP id c16mr5839252qkl.105.1619208539641; Fri, 23 Apr 2021 13:08:59 -0700 (PDT) Received: from eggly.attlocal.net (172-10-233-147.lightspeed.sntcca.sbcglobal.net. [172.10.233.147]) by smtp.gmail.com with ESMTPSA id i127sm5091592qke.71.2021.04.23.13.08.58 (version=TLS1 cipher=ECDHE-ECDSA-AES128-SHA bits=128/128); Fri, 23 Apr 2021 13:08:59 -0700 (PDT) Date: Fri, 23 Apr 2021 13:08:43 -0700 (PDT) From: Hugh Dickins X-X-Sender: hugh@eggly.anvils To: Andrew Morton cc: Hugh Dickins , Matthew Wilcox , William Kucharski , Christoph Hellwig , Jan Kara , Dave Chinner , Johannes Weiner , "Kirill A. Shutemov" , Yang Shi , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v2 2/2] mm/filemap: fix mapping_seek_hole_data on THP & 32-bit In-Reply-To: <20210423122940.26829dc784a4b6546349dac5@linux-foundation.org> Message-ID: References: <20210422011631.GL3596236@casper.infradead.org> <20210422160410.e9014b38b843d7a6ec06a9bb@linux-foundation.org> <20210423122940.26829dc784a4b6546349dac5@linux-foundation.org> User-Agent: Alpine 2.11 (LSU 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 8912F80192F0 X-Stat-Signature: xmsuibm58fdqha6f6jgqett94pu7bwx4 Received-SPF: none (google.com>: No applicable sender policy available) receiver=imf16; identity=mailfrom; envelope-from=""; helo=mail-qk1-f182.google.com; client-ip=209.85.222.182 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1619208538-13721 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, 23 Apr 2021, Andrew Morton wrote: > On Fri, 23 Apr 2021 10:22:51 -0700 (PDT) Hugh Dickins wrote: > > On Thu, 22 Apr 2021, Andrew Morton wrote: > > > On Thu, 22 Apr 2021 13:48:57 -0700 (PDT) Hugh Dickins wrote: > > > > > > > Andrew, I'd have just sent a -fix.patch to remove the unnecessary u64s, > > > > but need to reword the commit message: so please replace yesterday's > > > > mm-filemap-fix-mapping_seek_hole_data-on-thp-32-bit.patch > > > > by this one - thanks. > > > > > > Actually, I routinely update the base patch's changelog when queueing a -fix. > > > > And thank you for that, but if there's time, I think we would still > > prefer the final commit message to include corrections where Matthew > > enlightened me (that "sign-extension" claim came from my confusion): > > That's my point. When I merge a -v2 as a -fix, I replace the v1 > patch's changelog with v2's changelog so everything works out after > folding. Oh, great, thanks: that was not clear to me, I feared you meant adding "v2: remove unneeded u64 casts" to v1 when merging. Hugh