From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-24.8 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11136C433DB for ; Tue, 30 Mar 2021 23:44:22 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 82A51614A7 for ; Tue, 30 Mar 2021 23:44:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 82A51614A7 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 0A3406B007E; Tue, 30 Mar 2021 19:44:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0540D6B0081; Tue, 30 Mar 2021 19:44:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E36446B0082; Tue, 30 Mar 2021 19:44:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0223.hostedemail.com [216.40.44.223]) by kanga.kvack.org (Postfix) with ESMTP id C6EDF6B007E for ; Tue, 30 Mar 2021 19:44:20 -0400 (EDT) Received: from smtpin23.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 868DA180AD830 for ; Tue, 30 Mar 2021 23:44:20 +0000 (UTC) X-FDA: 77978171880.23.6719C85 Received: from mail-qk1-f181.google.com (mail-qk1-f181.google.com [209.85.222.181]) by imf14.hostedemail.com (Postfix) with ESMTP id 1D116C0001EE for ; Tue, 30 Mar 2021 23:44:18 +0000 (UTC) Received: by mail-qk1-f181.google.com with SMTP id q3so17671710qkq.12 for ; Tue, 30 Mar 2021 16:44:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:user-agent:mime-version; bh=tbt+Wr8D7RF2IDMuf+UsIa6Y7VNe6gu7kB9zX9lwwNE=; b=UTLkqaoPxsFd4hVxfCdR4/TwI2Gqit6rdTdr54qg+p87gUukGjLYevnzXuEQYfzSW0 2AVylzrW6aV3dSiymbrpuA5XVQT/8TXwTXNOAPIUMmc92xmQ8cy9gR4oTEqx6XvsAK1N ELjan+5IpdZCuNq0ef9fUSZy2O8Fa5PwNT6OP7RgAlcbFAZBTooMhKlJjXFyIEhpkUO4 jlYTsG0y1ELm0rUGFWPMXVV5KJeD9EO6j0eJ9cmJ431Zox287eN1Jja5hMQ27FGrI9za 3XXLiKEhQFylKIPT0L45eSSu+df+zc0gVd6NUIOFNXYdcPOyUP0Eo3e4p9QjId/Y1ZTL lXDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:user-agent :mime-version; bh=tbt+Wr8D7RF2IDMuf+UsIa6Y7VNe6gu7kB9zX9lwwNE=; b=pOAJTHpeyvsseaznnqwRemOn/aEfI8EhWnH2FiipuoDWPc2MGetVsUB1n+IiaPqlYW N3J5hNJikqN8zRJ0r+BiVgoAKiBNbfHzbDpr/hqAJ81+Mmq/naymk77EGZVNCGK2z5As csM8wJAFaEtiGBB2AlyuW9EhAXlupmstgGGEl8SxQH0vy22RuCUooI3AKt8WlU/e5hQX mgORJl7gMrgUm3sEro7sW8Ir6k3I/UjYHUBFnmoajKuJkXwYx1y0l36EYL7zCMZIrC3w qkQqHj012LdZAvFT9WCjGSt6n7xJ4q80j6AjSIxTV07MYQafsPY0Ny9cwFWdBAmKtZ5Q qgAg== X-Gm-Message-State: AOAM532nMfDlGnaq9glA8sNhnwsQOOYtPvP3Gap7lOmf6wOHh232bIrG tp3jy+I+L55gx1tXjwL3GHkgNw== X-Google-Smtp-Source: ABdhPJxc2JvaxYgZNwYGkXF4tE1bYB17KkgQNOLk/2jDXZ1LJvy3WOa5yUT2vjyFydYzzJQ7A7mICA== X-Received: by 2002:a37:42cb:: with SMTP id p194mr690996qka.213.1617147859029; Tue, 30 Mar 2021 16:44:19 -0700 (PDT) Received: from eggly.attlocal.net (172-10-233-147.lightspeed.sntcca.sbcglobal.net. [172.10.233.147]) by smtp.gmail.com with ESMTPSA id j129sm228556qkf.110.2021.03.30.16.44.17 (version=TLS1 cipher=ECDHE-ECDSA-AES128-SHA bits=128/128); Tue, 30 Mar 2021 16:44:18 -0700 (PDT) Date: Tue, 30 Mar 2021 16:44:05 -0700 (PDT) From: Hugh Dickins X-X-Sender: hugh@eggly.anvils To: Andrew Morton cc: kernel test robot , Yang Shi , Stephen Rothwell , Roman Gushchin , Kirill Tkhai , Vlastimil Babka , Shakeel Butt , Dave Chinner , Johannes Weiner , Michal Hocko , LKML , Linux Memory Management List , lkp@lists.01.org, lkp@intel.com Subject: [PATCH mmotm] mm: vmscan: fix shrinker_rwsem in free_shrinker_info() Message-ID: User-Agent: Alpine 2.11 (LSU 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Rspamd-Queue-Id: 1D116C0001EE X-Stat-Signature: 89tiw85is83nw8nsz7c3hyuyq6pt8s7w X-Rspamd-Server: rspam02 Received-SPF: none (google.com>: No applicable sender policy available) receiver=imf14; identity=mailfrom; envelope-from=""; helo=mail-qk1-f181.google.com; client-ip=209.85.222.181 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1617147858-161547 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Lockdep warns mm/vmscan.c: suspicious rcu_dereference_protected() usage! when free_shrinker_info() is called from mem_cgroup_css_free(): there it is called with no locking, whereas alloc_shrinker_info() calls it with down_write of shrinker_rwsem - which seems appropriate. Rearrange that so free_shrinker_info() can manage the shrinker_rwsem for itself. Link: https://lkml.kernel.org/r/20210317140615.GB28839@xsang-OptiPlex-9020 Reported-by: kernel test robot Signed-off-by: Hugh Dickins Cc: Yang Shi --- Sorry, I've made no attempt to work out precisely where in the series the locking went missing, nor tried to fit this in as a fix on top of mm-vmscan-add-shrinker_info_protected-helper.patch which Oliver reported (and which you notated in mmotm's "series" file). This patch just adds the fix to the end of the series, after mm-vmscan-shrink-deferred-objects-proportional-to-priority.patch mm/vmscan.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) --- mmotm/mm/vmscan.c 2021-03-28 17:26:54.935553064 -0700 +++ linux/mm/vmscan.c 2021-03-30 15:55:13.374459559 -0700 @@ -249,18 +249,20 @@ void free_shrinker_info(struct mem_cgrou struct shrinker_info *info; int nid; + down_write(&shrinker_rwsem); for_each_node(nid) { pn = memcg->nodeinfo[nid]; info = shrinker_info_protected(memcg, nid); kvfree(info); rcu_assign_pointer(pn->shrinker_info, NULL); } + up_write(&shrinker_rwsem); } int alloc_shrinker_info(struct mem_cgroup *memcg) { struct shrinker_info *info; - int nid, size, ret = 0; + int nid, size; int map_size, defer_size = 0; down_write(&shrinker_rwsem); @@ -270,9 +272,9 @@ int alloc_shrinker_info(struct mem_cgrou for_each_node(nid) { info = kvzalloc_node(sizeof(*info) + size, GFP_KERNEL, nid); if (!info) { + up_write(&shrinker_rwsem); free_shrinker_info(memcg); - ret = -ENOMEM; - break; + return -ENOMEM; } info->nr_deferred = (atomic_long_t *)(info + 1); info->map = (void *)info->nr_deferred + defer_size; @@ -280,7 +282,7 @@ int alloc_shrinker_info(struct mem_cgrou } up_write(&shrinker_rwsem); - return ret; + return 0; } static inline bool need_expand(int nr_max)