From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.8 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1, USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 59292C433E6 for ; Wed, 24 Feb 2021 16:56:00 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id CF69364F08 for ; Wed, 24 Feb 2021 16:55:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CF69364F08 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 54D316B0005; Wed, 24 Feb 2021 11:55:59 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4D3648D0002; Wed, 24 Feb 2021 11:55:59 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3C4D38D0001; Wed, 24 Feb 2021 11:55:59 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0212.hostedemail.com [216.40.44.212]) by kanga.kvack.org (Postfix) with ESMTP id 231A56B0005 for ; Wed, 24 Feb 2021 11:55:59 -0500 (EST) Received: from smtpin06.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id D0CD2173087A for ; Wed, 24 Feb 2021 16:55:58 +0000 (UTC) X-FDA: 77853763596.06.8561DE3 Received: from mail-oo1-f47.google.com (mail-oo1-f47.google.com [209.85.161.47]) by imf18.hostedemail.com (Postfix) with ESMTP id 6B5892000386 for ; Wed, 24 Feb 2021 16:55:57 +0000 (UTC) Received: by mail-oo1-f47.google.com with SMTP id e17so667858oow.4 for ; Wed, 24 Feb 2021 08:55:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=qzIzE3gw2sE+uqnG1z5ybJKgabwnkpbeDNpeXkPoLLA=; b=rOMFMda0e0+PgT6qyZtEzWuybeZnEKJIq6hNGk1YkcwiufEVQh5WEa/JtL2jQ2uKO5 HpdcBPqBgOOOgiHQhWyue1AkWGjy2BonhXvCMAWl4OSdsbsp7m8hoKg+mhW7s1nWKvFt 23rsozxkrbJcEBaa/BzcgCmZZPshxvsnLKtEPLpaaFoGdzSjRu8lHlmFY/9BBH934XfQ uzkGj8x4S0/RCrCnW9y3Qsu/E0yuIiiSMX3rCA1ATrj7Q0F0CjP2cLrW7yDADVFvYYCZ NZvMxR6VhmZqhfJTw0gTacdNIhatEfvz2YhdVQ2qPA6c5ls2rY0M2SZRE2WZee3VMwnt Xx8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=qzIzE3gw2sE+uqnG1z5ybJKgabwnkpbeDNpeXkPoLLA=; b=A24I7rS/SZLil43INTaXrq2JSb15TkfEMqN8W51FRlJr32I5wLlctAzdzdID8BObSk BTTe4iOKXEky1Ab4xBfJPuRjKCGLMGLhA32uY3MQt5Vlk4zta8DllPecAR/RjQLqEiYq Akk0GGyji8quzO488qf0LMnYTKscSN/v5OtCxfYcZr5Pzx4nWNu8Xr+d4jRJnuz0cfxn +H33v5ppTpQrWp5Ora1bEMu9ZwLdi23eqaZt/YR0jHaCOEV5laHCBfxv05vZd4cF0cSF SVtjGXKa4wnche7TgmyOvoxn5aXADxkW/+1avVx3iQEvFzQXXC8pp6F6LnsWfsiv0xe6 +XzA== X-Gm-Message-State: AOAM530n5pawY9foNTkmK5WKn5b0k9yiXskYllMWtPsoM4inT5+g46Pf W0QVhSaxPV30quWKmP4tFL8Jig== X-Google-Smtp-Source: ABdhPJyRwCKX5qHjV0sZ3hvYKAC052p7WG7STZ76eIno3EcNLNlFLX3uD3g/DSnbU6oWxCn90Vyt8Q== X-Received: by 2002:a4a:b815:: with SMTP id g21mr1964494oop.13.1614185754931; Wed, 24 Feb 2021 08:55:54 -0800 (PST) Received: from eggly.attlocal.net (172-10-233-147.lightspeed.sntcca.sbcglobal.net. [172.10.233.147]) by smtp.gmail.com with ESMTPSA id l202sm450958oib.16.2021.02.24.08.55.53 (version=TLS1 cipher=ECDHE-ECDSA-AES128-SHA bits=128/128); Wed, 24 Feb 2021 08:55:54 -0800 (PST) Date: Wed, 24 Feb 2021 08:55:40 -0800 (PST) From: Hugh Dickins X-X-Sender: hugh@eggly.anvils To: Rik van Riel cc: Hugh Dickins , Vlastimil Babka , Andrew Morton , xuyu@linux.alibaba.com, mgorman@suse.de, aarcange@redhat.com, willy@infradead.org, linux-kernel@vger.kernel.org, kernel-team@fb.com, linux-mm@kvack.org, mhocko@suse.com Subject: Re: [PATCH v6 0/3] mm,thp,shm: limit shmem THP alloc gfp_mask In-Reply-To: Message-ID: References: <20201124194925.623931-1-riel@surriel.com> User-Agent: Alpine 2.11 (LSU 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Stat-Signature: hm4c9ors8ea9bpfftfas3c6j4okd67tu X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 6B5892000386 Received-SPF: none (google.com>: No applicable sender policy available) receiver=imf18; identity=mailfrom; envelope-from=""; helo=mail-oo1-f47.google.com; client-ip=209.85.161.47 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1614185757-227912 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 24 Feb 2021, Rik van Riel wrote: > On Wed, 2021-02-24 at 00:41 -0800, Hugh Dickins wrote: > > On Mon, 14 Dec 2020, Vlastimil Babka wrote: > > > > > > (There's also a specific issue with the gfp_mask limiting: I have > > > > not yet reviewed the allowing and denying in detail, but it looks > > > > like it does not respect the caller's GFP_ZONEMASK - the gfp in > > > > shmem_getpage_gfp() and shmem_read_mapping_page_gfp() is there to > > > > satisfy the gma500, which wanted to use shmem but could only > > manage > > > > DMA32. I doubt it wants THPS, but shmem_enabled=force forces > > them.) > > > > Oh, I'd forgotten all about that gma500 aspect: > > well, I can send a fixup later on. > > I already have code to fix that, which somebody earlier > in this discussion convinced me to throw away. Want me > to send it as a patch 4/3 ? If Andrew wants it all, yes, please do add that - thanks Rik. Hugh