From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-24.8 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3739C433E0 for ; Mon, 8 Feb 2021 22:51:05 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 5CFCC64E8C for ; Mon, 8 Feb 2021 22:51:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5CFCC64E8C Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id A1C176B0005; Mon, 8 Feb 2021 17:51:04 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9C87D6B006C; Mon, 8 Feb 2021 17:51:04 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8BB906B006E; Mon, 8 Feb 2021 17:51:04 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0237.hostedemail.com [216.40.44.237]) by kanga.kvack.org (Postfix) with ESMTP id 7323A6B0005 for ; Mon, 8 Feb 2021 17:51:04 -0500 (EST) Received: from smtpin03.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 2DDF13635 for ; Mon, 8 Feb 2021 22:51:04 +0000 (UTC) X-FDA: 77796597648.03.low31_3b0442127602 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin03.hostedemail.com (Postfix) with ESMTP id 088CB28A4E9 for ; Mon, 8 Feb 2021 22:51:04 +0000 (UTC) X-HE-Tag: low31_3b0442127602 X-Filterd-Recvd-Size: 5805 Received: from mail-oo1-f54.google.com (mail-oo1-f54.google.com [209.85.161.54]) by imf35.hostedemail.com (Postfix) with ESMTP for ; Mon, 8 Feb 2021 22:51:03 +0000 (UTC) Received: by mail-oo1-f54.google.com with SMTP id q4so3830552ood.8 for ; Mon, 08 Feb 2021 14:51:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=2jaIFVPMabgNRI/gSMsENX64xR0X2GpzOOyOdGUnNRo=; b=pBScR02E5r0TkgIM7R/gTKUoLt7Z0j2l+KmGEUVvzVD6iJ+rV1NRqIGbxRSCpN/xF9 6ECzsWEtkMBYUHsLOW6EmRZvwcz50tmS4Z4kiMiTfHKdQVnDJR9wum99SFr67PJhCEhZ LIAGh6+XAHdhQB9YQkWu+PZsyD1WTPyCGPQIOOzymGPNz3Zg/acuqdTbeBlHqgHqbB9X QenXmEk9IGatt+KNlyRpsbxQe1sY+gcou4x4VQREJS7Wkxn/y9p8kt/wMxSfTAPAzsFj ohqYM+FW7JqUugev+5lDjtz30gnXn9A1GT2uGo8yxHk2lR3kD335idp9Ai8G83c7Ni6B LKbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=2jaIFVPMabgNRI/gSMsENX64xR0X2GpzOOyOdGUnNRo=; b=tQKhzA4iN4OdYlLqt987a9s5pmB143Rh2dUQK8kqevMZEDVdQIokw41MSkTAYoETsA Q1XL7nNiOt0PYsvUvjzLgVtQt39HozlR6yMaQiZJL+QPzdq8y/TYDjfVrbfB1n+AeUeP GO8atGRB3c0N+0N++OSe6UuCjFU8BUtFQFVP0o0+uBU2ndCd+DmUrpfP9qPHAJauWhcu fZRRNgJHTCOt6hAW5csNd2azMhe+kPh32F4Apqvrn1tj77wIKAI6WYU1O4VPtlCs9qH1 Dxz04ht0df3Y+KmpUvakJRBG84mMA5wZS6ckV3REB5mq897YFyZw4CygJjJypyH/oSfs tVQg== X-Gm-Message-State: AOAM530c256YIAJPdz2wnJ0xoihuQt+eqcAFkV3E19p68xkc9kkONOUu hXAB37ImCHq0uOzJaXNCzUw6YQ== X-Google-Smtp-Source: ABdhPJwKMs+R/f6Grt4JROunZj+IRHTQeNwBZcyQQGNO0b5W18rmchqi31uaPJUE+MthD6a4Uan95Q== X-Received: by 2002:a4a:870c:: with SMTP id z12mr13898102ooh.15.1612824662639; Mon, 08 Feb 2021 14:51:02 -0800 (PST) Received: from eggly.attlocal.net (172-10-233-147.lightspeed.sntcca.sbcglobal.net. [172.10.233.147]) by smtp.gmail.com with ESMTPSA id r25sm1079478ota.42.2021.02.08.14.50.59 (version=TLS1 cipher=ECDHE-ECDSA-AES128-SHA bits=128/128); Mon, 08 Feb 2021 14:51:01 -0800 (PST) Date: Mon, 8 Feb 2021 14:50:47 -0800 (PST) From: Hugh Dickins X-X-Sender: hugh@eggly.anvils To: Seth Forshee cc: Andrew Morton , Hugh Dickins , Chris Down , Amir Goldstein , Heiko Carstens , Vasily Gorbik , Christian Borntraeger , linux-mm@kvack.org, linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] tmpfs: Disallow CONFIG_TMPFS_INODE64 on s390 In-Reply-To: <20210205160551.cf57c4293ba5ccb8eb648c11@linux-foundation.org> Message-ID: References: <20210205230620.518245-1-seth.forshee@canonical.com> <20210205160551.cf57c4293ba5ccb8eb648c11@linux-foundation.org> User-Agent: Alpine 2.11 (LSU 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, 5 Feb 2021, Andrew Morton wrote: > On Fri, 5 Feb 2021 17:06:20 -0600 Seth Forshee wrote: > > > This feature requires ino_t be 64-bits, which is true for every > > 64-bit architecture but s390, so prevent this option from being > > selected there. > > > > The previous patch nicely described the end-user impact of the bug. > This is especially important when requesting a -stable backport. > > Here's what I ended up with: > > > From: Seth Forshee > Subject: tmpfs: disallow CONFIG_TMPFS_INODE64 on s390 > > Currently there is an assumption in tmpfs that 64-bit architectures also > have a 64-bit ino_t. This is not true on s390 which has a 32-bit ino_t. > With CONFIG_TMPFS_INODE64=y tmpfs mounts will get 64-bit inode numbers and > display "inode64" in the mount options, but passing the "inode64" mount > option will fail. This leads to the following behavior: > > # mkdir mnt > # mount -t tmpfs nodev mnt > # mount -o remount,rw mnt > mount: /home/ubuntu/mnt: mount point not mounted or bad option. > > As mount sees "inode64" in the mount options and thus passes it in the > options for the remount. > > > So prevent CONFIG_TMPFS_INODE64 from being selected on s390. > > Link: https://lkml.kernel.org/r/20210205230620.518245-1-seth.forshee@canonical.com > Fixes: ea3271f7196c ("tmpfs: support 64-bit inums per-sb") > Signed-off-by: Seth Forshee > Cc: Chris Down > Cc: Hugh Dickins Thank you Seth: now that you've fixed Kirill's alpha observation too, Acked-by: Hugh Dickins > Cc: Amir Goldstein > Cc: Heiko Carstens > Cc: Vasily Gorbik > Cc: Christian Borntraeger > Cc: [5.9+] > Signed-off-by: Andrew Morton > --- > > fs/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > --- a/fs/Kconfig~tmpfs-disallow-config_tmpfs_inode64-on-s390 > +++ a/fs/Kconfig > @@ -203,7 +203,7 @@ config TMPFS_XATTR > > config TMPFS_INODE64 > bool "Use 64-bit ino_t by default in tmpfs" > - depends on TMPFS && 64BIT > + depends on TMPFS && 64BIT && !S390 > default n > help > tmpfs has historically used only inode numbers as wide as an unsigned > _ > >