From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.8 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3861C433E0 for ; Fri, 5 Feb 2021 17:57:30 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 2DA2864E36 for ; Fri, 5 Feb 2021 17:57:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2DA2864E36 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 7F4E86B0071; Fri, 5 Feb 2021 12:57:29 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7A6526B0073; Fri, 5 Feb 2021 12:57:29 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 694186B0074; Fri, 5 Feb 2021 12:57:29 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0136.hostedemail.com [216.40.44.136]) by kanga.kvack.org (Postfix) with ESMTP id 50E6E6B0071 for ; Fri, 5 Feb 2021 12:57:29 -0500 (EST) Received: from smtpin11.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 09FD03632 for ; Fri, 5 Feb 2021 17:57:29 +0000 (UTC) X-FDA: 77784971418.11.lake20_4705435275e6 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin11.hostedemail.com (Postfix) with ESMTP id DAE9D180F8B80 for ; Fri, 5 Feb 2021 17:57:28 +0000 (UTC) X-HE-Tag: lake20_4705435275e6 X-Filterd-Recvd-Size: 9532 Received: from mail-ot1-f48.google.com (mail-ot1-f48.google.com [209.85.210.48]) by imf28.hostedemail.com (Postfix) with ESMTP for ; Fri, 5 Feb 2021 17:57:28 +0000 (UTC) Received: by mail-ot1-f48.google.com with SMTP id d1so7667632otl.13 for ; Fri, 05 Feb 2021 09:57:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=ubRCMr0IcTC3F3rvhK6FNCSkYK2+GzXh+aG1g21wwmM=; b=WADuhEvrZseQmGBeo1CAj0phhzqV29X+dnVB1euOmK//AGFKRQdnP8XOmEgR3SBnzp jNLCeN6ylnPoOM1hM5LvyrIqUHebc7/Em26N0kGsEyVQnl3diYzsOyZ3RgbDyW6G1X0+ RT1PbHZjDWGOhj7VPx5Cm4nqzaZgEUusuh4GZW1p2AaZ9208ElWRFVP7WiR0zQaGtjLs /xiN/rH5KtuSDzV0MSp/PeyKoZb9CqA/Ex22Wuq0pEvB8lugl15cjNvPmn5uyVVb8Vwv CxT8OEyyHiAgu+ZJh8U+Kho1RClN9PWIIgbmlDE/b+v8Dc3wgU7Ympa5Ns6Lypbe6e3p qQzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=ubRCMr0IcTC3F3rvhK6FNCSkYK2+GzXh+aG1g21wwmM=; b=VEhiVXsTbmSSftRvhtBfO/B+Ud0Rq4zmwJdSoHWaUeREr+cA0kQwK5Or0ThvlogtBt f9iCSEvs54sZ/457/fc/vUBzC0WnIuLO5R2ccI/01jLIdBy8vEs/ZDW6maNqhpYJO+uL ROT4xuAsyW15aqsi5hH3t2fAEPtCxTYolkGqFPMu9j80DZ1llUvl5znFe6KSRWQfzuyI zk8lQ8LDXlv4YAVMopeHUMlUmrlAY0nbdnKXUmZeUvgawX96FO8A//NwOeqhSFugfH0q zWsCrd/XCw5REp5qlF1vmEwpiKM/DMPEnUA9NSMRcqPL5fiZ78nxul10g+OV6r4QHLfv p71A== X-Gm-Message-State: AOAM533BQey8Nb9Drig/Eye8+twu1GBHoWzxt5hcTMuv/nPph5ByvCZ5 ENLacHcW+PxI4xfDBrgoDbVBnQ== X-Google-Smtp-Source: ABdhPJy1MVXEbFwucx+eOSIP+rtkBFHcVsdLdqbD+nQLYRzwP3avXR42NfnqObQ75PWU2y+2pctuLw== X-Received: by 2002:a9d:ec8:: with SMTP id 66mr3283589otj.217.1612547847542; Fri, 05 Feb 2021 09:57:27 -0800 (PST) Received: from eggly.attlocal.net (172-10-233-147.lightspeed.sntcca.sbcglobal.net. [172.10.233.147]) by smtp.gmail.com with ESMTPSA id g11sm1961029oif.9.2021.02.05.09.57.26 (version=TLS1 cipher=ECDHE-ECDSA-AES128-SHA bits=128/128); Fri, 05 Feb 2021 09:57:27 -0800 (PST) Date: Fri, 5 Feb 2021 09:57:12 -0800 (PST) From: Hugh Dickins X-X-Sender: hugh@eggly.anvils To: Matthew Wilcox cc: Hugh Dickins , Andrew Morton , syzbot , linux-kernel@vger.kernel.org, linux-mm@kvack.org, syzkaller-bugs@googlegroups.com, Alex Shi , Roman Gushchin , Wu Fengguang Subject: Re: INFO: task can't die in shrink_inactive_list (2) In-Reply-To: <20210205174433.GJ308988@casper.infradead.org> Message-ID: References: <0000000000000340a105b49441d3@google.com> <20201123195452.8ecd01b1fc2ce287dfd6a0d5@linux-foundation.org> <20201221203344.GG874@casper.infradead.org> <20210205174433.GJ308988@casper.infradead.org> User-Agent: Alpine 2.11 (LSU 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, 5 Feb 2021, Matthew Wilcox wrote: > > Hugh, did you get a chance to test this? 'fraid not: since I was unable to reproduce the problem, I did not try running with your suggested fix at all: hoped someone who could reproduce the problem might. Hugh > > On Mon, Dec 21, 2020 at 08:33:44PM +0000, Matthew Wilcox wrote: > > On Mon, Dec 21, 2020 at 11:56:36AM -0800, Hugh Dickins wrote: > > > On Mon, 23 Nov 2020, Andrew Morton wrote: > > > > On Fri, 20 Nov 2020 17:55:22 -0800 syzbot wrote: > > > > > > > > > Hello, > > > > > > > > > > syzbot found the following issue on: > > > > > > > > > > HEAD commit: 03430750 Add linux-next specific files for 20201116 > > > > > git tree: linux-next > > > > > console output: https://syzkaller.appspot.com/x/log.txt?x=13f80e5e500000 > > > > > kernel config: https://syzkaller.appspot.com/x/.config?x=a1c4c3f27041fdb8 > > > > > dashboard link: https://syzkaller.appspot.com/bug?extid=e5a33e700b1dd0da20a2 > > > > > compiler: gcc (GCC) 10.1.0-syz 20200507 > > > > > syz repro: https://syzkaller.appspot.com/x/repro.syz?x=12f7bc5a500000 > > > > > C reproducer: https://syzkaller.appspot.com/x/repro.c?x=10934cf2500000 > > > > > > > > Alex, your series "per memcg lru lock" changed the vmscan code rather a > > > > lot. Could you please take a look at that reproducer? > > > > > > Andrew, I promised I'd take a look at this syzreport too (though I think > > > we're agreed by now that it has nothing to do with per-memcg lru_lock). > > > > > > I did try, but (unlike Alex) did not manage to get the reproducer to > > > reproduce it. No doubt I did not try hard enough: I did rather lose > > > interest after seeing that it appears to involve someone with > > > CAP_SYS_ADMIN doing an absurdly large ioctl(BLKFRASET) on /dev/nullb0 > > > ("Null test block driver" enabled via CONFIG_BLK_DEV_NULL_BLK=y: that I > > > did enable) and faulting from it: presumably triggering an absurd amount > > > of readahead. > > > > > > Cc'ing Matthew since he has a particular interest in readahead, and > > > might be inspired to make some small safe change that would fix this, > > > and benefit realistic cases too; but on the whole it didn't look worth > > > worrying about - or at least not by me. > > > > Oh, interesting. Thanks for looping me in, I hadn't looked at this one > > at all. Building on the debugging you did, this is the interesting > > part of the backtrace to me: > > > > > > > try_to_free_pages+0x29f/0x720 mm/vmscan.c:3264 > > > > > __perform_reclaim mm/page_alloc.c:4360 [inline] > > > > > __alloc_pages_direct_reclaim mm/page_alloc.c:4381 [inline] > > > > > __alloc_pages_slowpath.constprop.0+0x917/0x2510 mm/page_alloc.c:4785 > > > > > __alloc_pages_nodemask+0x5f0/0x730 mm/page_alloc.c:4995 > > > > > alloc_pages_current+0x191/0x2a0 mm/mempolicy.c:2271 > > > > > alloc_pages include/linux/gfp.h:547 [inline] > > > > > __page_cache_alloc mm/filemap.c:977 [inline] > > > > > __page_cache_alloc+0x2ce/0x360 mm/filemap.c:962 > > > > > page_cache_ra_unbounded+0x3a1/0x920 mm/readahead.c:216 > > > > > do_page_cache_ra+0xf9/0x140 mm/readahead.c:267 > > > > > do_sync_mmap_readahead mm/filemap.c:2721 [inline] > > > > > filemap_fault+0x19d0/0x2940 mm/filemap.c:2809 > > > > So ra_pages has been set to something ridiculously large, and as > > a result, we call do_page_cache_ra() asking to read more memory than > > is available in the machine. Funny thing, we actually have a function > > to prevent this kind of situation, and it's force_page_cache_ra(). > > > > So this might fix the problem. I only tested that it compiles. I'll > > be happy to write up a proper changelog and sign-off for it if it works ... > > it'd be good to get it some soak testing on a variety of different > > workloads; changing this stuff is enormously subtle. > > > > As a testament to that, I think Fengguang got it wrong in commit > > 2cbea1d3ab11 -- async_size should have been 3 * ra_pages / 4, not ra_pages > > / 4 (because we read-behind by half the range, so we're looking for a > > page fault to happen a quarter of the way behind this fault ...) > > > > This is partially Roman's fault, see commit 600e19afc5f8. > > > > diff --git a/mm/filemap.c b/mm/filemap.c > > index d5e7c2029d16..43fe0f0ae3bb 100644 > > --- a/mm/filemap.c > > +++ b/mm/filemap.c > > @@ -2632,7 +2632,7 @@ static struct file *do_sync_mmap_readahead(struct vm_fault *vmf) > > ra->size = ra->ra_pages; > > ra->async_size = ra->ra_pages / 4; > > ractl._index = ra->start; > > - do_page_cache_ra(&ractl, ra->size, ra->async_size); > > + force_page_cache_ra(&ractl, ra, ra->size); > > return fpin; > > } > > > > diff --git a/mm/internal.h b/mm/internal.h > > index c43ccdddb0f6..5664b4b91340 100644 > > --- a/mm/internal.h > > +++ b/mm/internal.h > > @@ -49,8 +49,6 @@ void unmap_page_range(struct mmu_gather *tlb, > > unsigned long addr, unsigned long end, > > struct zap_details *details); > > > > -void do_page_cache_ra(struct readahead_control *, unsigned long nr_to_read, > > - unsigned long lookahead_size); > > void force_page_cache_ra(struct readahead_control *, struct file_ra_state *, > > unsigned long nr); > > static inline void force_page_cache_readahead(struct address_space *mapping, > > diff --git a/mm/readahead.c b/mm/readahead.c > > index c5b0457415be..f344c894c26a 100644 > > --- a/mm/readahead.c > > +++ b/mm/readahead.c > > @@ -246,7 +246,7 @@ EXPORT_SYMBOL_GPL(page_cache_ra_unbounded); > > * behaviour which would occur if page allocations are causing VM writeback. > > * We really don't want to intermingle reads and writes like that. > > */ > > -void do_page_cache_ra(struct readahead_control *ractl, > > +static void do_page_cache_ra(struct readahead_control *ractl, > > unsigned long nr_to_read, unsigned long lookahead_size) > > { > > struct inode *inode = ractl->mapping->host;