From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-24.8 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57B40C433E0 for ; Tue, 22 Dec 2020 03:39:04 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id DE4B622B43 for ; Tue, 22 Dec 2020 03:39:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DE4B622B43 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 065AD8D0008; Mon, 21 Dec 2020 22:39:03 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id F30AC8D0001; Mon, 21 Dec 2020 22:39:02 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DF8E08D0008; Mon, 21 Dec 2020 22:39:02 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0067.hostedemail.com [216.40.44.67]) by kanga.kvack.org (Postfix) with ESMTP id C32C18D0001 for ; Mon, 21 Dec 2020 22:39:02 -0500 (EST) Received: from smtpin24.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 7EEFF181AEF31 for ; Tue, 22 Dec 2020 03:39:02 +0000 (UTC) X-FDA: 77619512124.24.lip28_33086402745c Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin24.hostedemail.com (Postfix) with ESMTP id 5441E1A4A0 for ; Tue, 22 Dec 2020 03:39:02 +0000 (UTC) X-HE-Tag: lip28_33086402745c X-Filterd-Recvd-Size: 6400 Received: from mail-pf1-f181.google.com (mail-pf1-f181.google.com [209.85.210.181]) by imf13.hostedemail.com (Postfix) with ESMTP for ; Tue, 22 Dec 2020 03:39:01 +0000 (UTC) Received: by mail-pf1-f181.google.com with SMTP id d2so7663863pfq.5 for ; Mon, 21 Dec 2020 19:39:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=mQRnP/VE3MNPubHtDGscBCYTtM3M8Hnq7UmsE7TsaOU=; b=aIf0pGKPSreq5IVVApVQmbb6IeRO6q0rWAZSyCbchKd3JzFF0dl9OPfFoHGNFNiHwF L+PGmSJ8KKPAvSREpdpX6LSXrbYNPfsG8FVdHbjA8LD/1ePrfwtDbx3AWnxEuINxSew3 /G8z6kj9+V4oGzdjwzEy8MUC6hMWUMjOAvTi37ZruuJMuB+w38j3U49XOQ18xz5C7BVz wUZXDjqM9Gt/WugmBrxR3FkzKW14NzEwrqYBEZvE9HaWZrMRdAjZMSLqC75JVU3Rd9C8 EcLCcFmN4/gMoHTqSqYVnXFo6AfOR/TIvdNCCQ3C5sK/AllRIAKhmLggrfk4onGmXCyA 2+tg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=mQRnP/VE3MNPubHtDGscBCYTtM3M8Hnq7UmsE7TsaOU=; b=Len2OIFRKrvIx7iOAyackV3GqZYD9YWLOwQ8CitKQLEktHhcF1AytysMS4nmGNmron SRUIAVl10reg0xR+ZukQ0m13WwXy8nDYVjZDJC4Gczpq7ci/TijFXYAcp3crJi+umUVO jpKR/2gkVeAa4L4F6o92PAFffvYa7+Vy/bzxEn8Gtil6L5EQbUfa6WbrzCXgvx2VxY8p ZgFtOyCUKCAlCLu2GZ71GRCwpAyXMscTk5hirUYdtmEHozZwfjyyHD8ZbGvbso0dB74v fiJXjcoydtfJO/0aiV3htP7aXVp/QH566TWOHpGqX8pHBOmGKtMy6LkAOTX/VNIDd9kh KwKw== X-Gm-Message-State: AOAM530E8Qf6UJVaAjv3KrjTo/j9xpAL0qTOHWGISlR17EkU1Aa0UnrU fUpUYDvCWcS0nAEQTfttsg+cdA== X-Google-Smtp-Source: ABdhPJzRa1gPuiUdV7wKyv/rJCmjaS+AMnNm3WPKmFO8ip/FFKsK2HgBJHAyyXooG0/zw4pVdGEMrA== X-Received: by 2002:a63:609:: with SMTP id 9mr18084864pgg.391.1608608340308; Mon, 21 Dec 2020 19:39:00 -0800 (PST) Received: from eggly.attlocal.net (172-10-233-147.lightspeed.sntcca.sbcglobal.net. [172.10.233.147]) by smtp.gmail.com with ESMTPSA id nk11sm17068952pjb.26.2020.12.21.19.38.58 (version=TLS1 cipher=ECDHE-ECDSA-AES128-SHA bits=128/128); Mon, 21 Dec 2020 19:38:59 -0800 (PST) Date: Mon, 21 Dec 2020 19:38:57 -0800 (PST) From: Hugh Dickins X-X-Sender: hugh@eggly.anvils To: Alex Shi cc: Andrew Morton , Hugh Dickins , Johannes Weiner , Michal Hocko , Vladimir Davydov , Alexander Duyck , Hui Su , cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/3] mm/memcg: remove rcu locking for lock_page_lruvec function series In-Reply-To: <1608186532-81218-2-git-send-email-alex.shi@linux.alibaba.com> Message-ID: References: <1608186532-81218-1-git-send-email-alex.shi@linux.alibaba.com> <1608186532-81218-2-git-send-email-alex.shi@linux.alibaba.com> User-Agent: Alpine 2.11 (LSU 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, 17 Dec 2020, Alex Shi wrote: > The rcu_read_lock was used to block memcg destory, but with the detailed > calling conditions, the memcg won't gone since the page is hold. So we > don't need it now, let's remove them to save locking load in debugging. " lock_page_lruvec() and its variants used rcu_read_lock() with the intention of safeguarding against the mem_cgroup being destroyed concurrently; but so long as they are called under the specified conditions (as they are), there is no way for the page's mem_cgroup to be destroyed. Delete the unnecessary rcu_read_lock() and _unlock(). " This has little to do with a "locking load in debugging" - so what? But everything to do with deleting bogosity, the sooner the better. > > Signed-off-by: Alex Shi > Cc: Hugh Dickins Acked-by: Hugh Dickins This really surprised me! Nice change, but how on earth did we not notice until now? The rcu_read_lock() seems to have come in, without explanation, somewhere between lru_lock v9 and v11 (I never saw v10); and I guess I was so used to needing rcu_read_lock() in my own implementation, that I was blind to its irrelevance in yours. Cc'ing Alex Duyck, since he was generally very alert to this kind of thing - be good to have his Ack too. Also Cc'ing Hui Su, who sent a similar but unexplained patch just before yours. > Cc: Johannes Weiner > Cc: Michal Hocko > Cc: Vladimir Davydov > Cc: Andrew Morton > Cc: cgroups@vger.kernel.org > Cc: linux-mm@kvack.org > Cc: linux-kernel@vger.kernel.org > --- > mm/memcontrol.c | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > index e6b50d068b2f..98bbee1d2faf 100644 > --- a/mm/memcontrol.c > +++ b/mm/memcontrol.c > @@ -1356,10 +1356,8 @@ struct lruvec *lock_page_lruvec(struct page *page) > struct lruvec *lruvec; > struct pglist_data *pgdat = page_pgdat(page); > > - rcu_read_lock(); > lruvec = mem_cgroup_page_lruvec(page, pgdat); > spin_lock(&lruvec->lru_lock); > - rcu_read_unlock(); > > lruvec_memcg_debug(lruvec, page); > > @@ -1371,10 +1369,8 @@ struct lruvec *lock_page_lruvec_irq(struct page *page) > struct lruvec *lruvec; > struct pglist_data *pgdat = page_pgdat(page); > > - rcu_read_lock(); > lruvec = mem_cgroup_page_lruvec(page, pgdat); > spin_lock_irq(&lruvec->lru_lock); > - rcu_read_unlock(); > > lruvec_memcg_debug(lruvec, page); > > @@ -1386,10 +1382,8 @@ struct lruvec *lock_page_lruvec_irqsave(struct page *page, unsigned long *flags) > struct lruvec *lruvec; > struct pglist_data *pgdat = page_pgdat(page); > > - rcu_read_lock(); > lruvec = mem_cgroup_page_lruvec(page, pgdat); > spin_lock_irqsave(&lruvec->lru_lock, *flags); > - rcu_read_unlock(); > > lruvec_memcg_debug(lruvec, page); > > -- > 2.29.GIT