From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.9 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1, USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 32113C433DF for ; Tue, 13 Oct 2020 02:30:22 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 837B9208FE for ; Tue, 13 Oct 2020 02:30:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="KrUvpd/N" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 837B9208FE Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id B150F940007; Mon, 12 Oct 2020 22:30:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AC3C5900002; Mon, 12 Oct 2020 22:30:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 97910940007; Mon, 12 Oct 2020 22:30:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0236.hostedemail.com [216.40.44.236]) by kanga.kvack.org (Postfix) with ESMTP id 601C7900002 for ; Mon, 12 Oct 2020 22:30:20 -0400 (EDT) Received: from smtpin27.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 01E431EE6 for ; Tue, 13 Oct 2020 02:30:20 +0000 (UTC) X-FDA: 77365323000.27.talk80_6115997271ff Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin27.hostedemail.com (Postfix) with ESMTP id D72D83D668 for ; Tue, 13 Oct 2020 02:30:19 +0000 (UTC) X-HE-Tag: talk80_6115997271ff X-Filterd-Recvd-Size: 8791 Received: from mail-oi1-f194.google.com (mail-oi1-f194.google.com [209.85.167.194]) by imf36.hostedemail.com (Postfix) with ESMTP for ; Tue, 13 Oct 2020 02:30:19 +0000 (UTC) Received: by mail-oi1-f194.google.com with SMTP id x62so20855154oix.11 for ; Mon, 12 Oct 2020 19:30:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=bnow7E0NdAgjP24uVGPtsFmB33v0oAbeU6I6hhEmdgc=; b=KrUvpd/NgSTDTdOcGQLuHHaZU0xD55DjswJ8khTx2pSoboXy93Jxf2qHywUyjFDyrL eJQUerC2H2GL4jTguLveYvjUixN4gsg3qBA/m+K5Dfe6h4qUtsz7Vzxttb55XV+X07yB kfJsUhqTIm7vY9XRgP0As0lJu4QCGjFfWbyvTvKwuQN9Ol1pXyvIXfZ0yCe+cDXpIBz0 NktjqctuKy/KaU5U0Jzy7+/tIpw0pkGlOhP2aiJ/dnkqcmgDetRZb/OomuI7G4yUVnsK bQwYA/vsGGaELvLzBIJMzUE0z3E9wAmmRH21fVOl6c2nyipuA/AhCfzP0wGJoCU0LAAQ PArg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=bnow7E0NdAgjP24uVGPtsFmB33v0oAbeU6I6hhEmdgc=; b=qbvjT9JUJ3oTPbAymPRukhXgvNzu+yafGSPPIviq0sVOrsy8U4gBhhfRpQyoUD68Eu jrHNVjBEStVBpjWKHxuEQgZgomhOC2xo9CsOcSI5r09Qw2Wgqj4VQ3tGn/TQS2ffYs21 VskqtUICuZ/jMcsmdIV+kgRM1tYky9Dn6bzqvFY4amjIrqQjhTQIl/Y1N7lWF2puJaeu i79ZKoZ1nvVqEZ9l5yYwXxIJqj4zIAKM1YlHIUGpBB3TshEI11v+NVum2ZIR/Hm7JeId ZxcOQLSt7aMfK6CJ4Cah+enIJBpxZFpk3fA0htoChAXFSD6isIaV5em76+Q68U7s2ZPY BQXg== X-Gm-Message-State: AOAM533esVJCSj4xmGQwYeab3hi5LYgK5K2wd6Z+m9kSh/CQKoyfdmyd k3XMk9axIYv5GP/04+TTSqaT7w== X-Google-Smtp-Source: ABdhPJyONDiO5yevIWMqwITzHHdmzf1rJ12V6IDE32XCQJ68uNg6ZptgDpu7d8FRdFcD63qBuGDB4w== X-Received: by 2002:aca:c490:: with SMTP id u138mr12541282oif.54.1602556218373; Mon, 12 Oct 2020 19:30:18 -0700 (PDT) Received: from eggly.attlocal.net (172-10-233-147.lightspeed.sntcca.sbcglobal.net. [172.10.233.147]) by smtp.gmail.com with ESMTPSA id x15sm11158198oor.33.2020.10.12.19.30.15 (version=TLS1 cipher=ECDHE-ECDSA-AES128-SHA bits=128/128); Mon, 12 Oct 2020 19:30:17 -0700 (PDT) Date: Mon, 12 Oct 2020 19:30:03 -0700 (PDT) From: Hugh Dickins X-X-Sender: hugh@eggly.anvils To: Andrew Morton cc: Yu Zhao , Hugh Dickins , Michal Hocko , Alex Shi , Steven Rostedt , Ingo Molnar , Johannes Weiner , Vladimir Davydov , Roman Gushchin , Shakeel Butt , Chris Down , Yafang Shao , Vlastimil Babka , Huang Ying , Pankaj Gupta , Matthew Wilcox , Konstantin Khlebnikov , Minchan Kim , Jaewon Kim , cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 00/13] mm: clean up some lru related pieces In-Reply-To: Message-ID: References: <20200918030051.650890-1-yuzhao@google.com> <20200918210126.GA1118730@google.com> User-Agent: Alpine 2.11 (LSU 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, 18 Sep 2020, Hugh Dickins wrote: > On Fri, 18 Sep 2020, Yu Zhao wrote: > > On Fri, Sep 18, 2020 at 01:46:59PM -0700, Hugh Dickins wrote: > > > On Thu, 17 Sep 2020, Yu Zhao wrote: > > > > > > > Hi Andrew, > > > > > > > > I see you have taken this: > > > > mm: use add_page_to_lru_list()/page_lru()/page_off_lru() > > > > Do you mind dropping it? > > > > > > > > Michal asked to do a bit of additional work. So I thought I probably > > > > should create a series to do more cleanups I've been meaning to. > > > > > > > > This series contains the change in the patch above and goes a few > > > > more steps farther. It's intended to improve readability and should > > > > not have any performance impacts. There are minor behavior changes in > > > > terms of debugging and error reporting, which I have all highlighted > > > > in the individual patches. All patches were properly tested on 5.8 > > > > running Chrome OS, with various debug options turned on. > > > > > > > > Michal, > > > > > > > > Do you mind taking a looking at the entire series? > > > > > > > > Thank you. > > > > > > > > Yu Zhao (13): > > > > mm: use add_page_to_lru_list() > > > > mm: use page_off_lru() > > > > mm: move __ClearPageLRU() into page_off_lru() > > > > mm: shuffle lru list addition and deletion functions > > > > mm: don't pass enum lru_list to lru list addition functions > > > > mm: don't pass enum lru_list to trace_mm_lru_insertion() > > > > mm: don't pass enum lru_list to del_page_from_lru_list() > > > > mm: rename page_off_lru() to __clear_page_lru_flags() > > > > mm: inline page_lru_base_type() > > > > mm: VM_BUG_ON lru page flags > > > > mm: inline __update_lru_size() > > > > mm: make lruvec_lru_size() static > > > > mm: enlarge the int parameter of update_lru_size() > > > > > > > > include/linux/memcontrol.h | 14 ++-- > > > > include/linux/mm_inline.h | 115 ++++++++++++++------------------- > > > > include/linux/mmzone.h | 2 - > > > > include/linux/vmstat.h | 2 +- > > > > include/trace/events/pagemap.h | 11 ++-- > > > > mm/compaction.c | 2 +- > > > > mm/memcontrol.c | 10 +-- > > > > mm/mlock.c | 2 +- > > > > mm/swap.c | 53 ++++++--------- > > > > mm/vmscan.c | 28 +++----- > > > > 10 files changed, 95 insertions(+), 144 deletions(-) > > > > > > > > -- > > > > 2.28.0.681.g6f77f65b4e-goog > > > > > > Sorry, Yu, I may be out-of-line in sending this: but as you know, > > > Alex Shi has a long per-memcg lru_lock series playing in much the > > > same area (particularly conflicting in mm/swap.c and mm/vmscan.c): > > > a patchset that makes useful changes, that I'm very keen to help > > > into mmotm a.s.a.p (but not before I've completed diligence). > > > > > > We've put a lot of effort into its testing, I'm currently reviewing > > > it patch by patch (my general silence indicating that I'm busy on that, > > > but slow as ever): so I'm a bit discouraged to have its stability > > > potentially undermined by conflicting cleanups at this stage. > > > > > > If there's general agreement that your cleanups are safe and welcome > > > (Michal's initial reaction sheds some doubt on that), great: I hope > > > that Andrew can fast-track them into mmotm, then Alex rebase on top > > > of them, and I then re-test and re-review. > > > > > > But if that quick agreement is not forthcoming, may I ask you please > > > to hold back, and resend based on top of Alex's next posting? > > > > The per-memcg lru lock series seems a high priority, and I have > > absolutely no problem accommodate your request. > > Many thanks! > > > > > In return, may I ask you or Alex to review this series after you > > have finished with per-memcg lru lock (to make sure that I resolve > > all the conflicts correctly at least)? > > Fair enough: I promise to do so. > > And your rebasing will necessarily lead you to review some parts > of Alex's patchset, which will help us all too. > > Andrew, Yu asked at the start: > > > > I see you have taken this: > > > > mm: use add_page_to_lru_list()/page_lru()/page_off_lru() > > > > Do you mind dropping it? > Dropping that for now will help too. Andrew, please drop Yu Zhao's mm-use-add_page_to_lru_list-page_lru-page_off_lru.patch from the mmotm tree. Yu wants to replace it by this cleanup series, and he has graciously agreed to rebase his series on top of Alex Shi's per-memcg lru_lock series; but mm-use-add_page_to_lru_list-page_lru-page_off_lru.patch is getting in the way of adding them to mmotm. The three of us are all hoping that Alex's v19 series can go into mmotm when the merge window closes, then I'll review Yu's series rebased on top of it. Thanks, Hugh