From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.9 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1, USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D045DC43465 for ; Fri, 18 Sep 2020 21:19:24 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 721262344C for ; Fri, 18 Sep 2020 21:19:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="RCLC4pAG" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 721262344C Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id EDB506B0095; Fri, 18 Sep 2020 17:19:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EB1766B0096; Fri, 18 Sep 2020 17:19:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DA03B6B0098; Fri, 18 Sep 2020 17:19:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0213.hostedemail.com [216.40.44.213]) by kanga.kvack.org (Postfix) with ESMTP id C27A86B0095 for ; Fri, 18 Sep 2020 17:19:23 -0400 (EDT) Received: from smtpin24.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 899A2181AEF23 for ; Fri, 18 Sep 2020 21:19:23 +0000 (UTC) X-FDA: 77277448206.24.sleet21_51156582712e Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin24.hostedemail.com (Postfix) with ESMTP id 727921A4A5 for ; Fri, 18 Sep 2020 21:19:23 +0000 (UTC) X-HE-Tag: sleet21_51156582712e X-Filterd-Recvd-Size: 7968 Received: from mail-ot1-f66.google.com (mail-ot1-f66.google.com [209.85.210.66]) by imf25.hostedemail.com (Postfix) with ESMTP for ; Fri, 18 Sep 2020 21:19:22 +0000 (UTC) Received: by mail-ot1-f66.google.com with SMTP id g96so6667521otb.12 for ; Fri, 18 Sep 2020 14:19:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=hCqfyPqClFtsWYJ6Us4lj54w9VZCcNft/YN87A9Cm1M=; b=RCLC4pAGnJPpVPcdwcMuRM/kCYe5yGj3+0+2krt4aXaidS5UjLbpsy5sPdGpUYeYRj IBCHrTculQJ+3IShLOsUN6M5LV+639lGd7bqOJYdYqXbWCjoM+eHsTdG3SZ0VnMu3VBb v1MqRjdzxrxOIQMNceoi2JERCRmFElH4hkgHDalq70CLk5z3OYuyljGxTWjzOaUk/Oxy 6zibOGX9vP7z9sGGCcerC4SEGV83/ul+bVkJTN0QLe4xEOrQBdEFfPpj32cEFf8O1FxL Neg5uuOeUd8D7gZYZDr8oPchdjy3oDL0qD8+0dxihlkhQph1J00Bku1yFNeDZ0N5wddQ SNFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=hCqfyPqClFtsWYJ6Us4lj54w9VZCcNft/YN87A9Cm1M=; b=WEMtRG9VUBlJyRi+/4s5FWmjU0kZXVpgFstZcMUALMI7oMnQxz7aQOYlSYyv6Sljg2 oGEXj0GpCr0v7R6dKi+H860+yp1hMcIWBYoqfyex/ZbUdzVb6oalxl/YTHJqgY0NFftz FLKI77F6YUtzxScnrghaBQOshHQXuMZNSQ9HYC8l6IXG/aIwm/8LPPbIWWP4uZ7hG0W6 VIJHs74jnOx/9/AKcR7dnAiXWPtaf/dez1Q2sxelHW5vJ6ua6ASV8QSflzaHz2oBl6bZ +v+F1P2i+VnBsGqHGWQOvKCoU9gQ92rB9fuCBbqb+j8NzN2bUElWpPGP3sRSWaOPzemD yORw== X-Gm-Message-State: AOAM532Hyh6TB8SB4N0T2ClpKa690LW/RTkGPZc5Iy1CXtnJocd1iHed rRl/M9akf19EnWYP/3LNbYW0LA== X-Google-Smtp-Source: ABdhPJyNWyKUZsUDgJBuIgPpf2i2iguj4TPsuCoz2AqoNjriX/A+uxXwTQHeC491Oww9bEb83eWPDg== X-Received: by 2002:a05:6830:1e6b:: with SMTP id m11mr24868463otr.40.1600463961917; Fri, 18 Sep 2020 14:19:21 -0700 (PDT) Received: from eggly.attlocal.net (172-10-233-147.lightspeed.sntcca.sbcglobal.net. [172.10.233.147]) by smtp.gmail.com with ESMTPSA id q184sm4146364ooq.40.2020.09.18.14.19.19 (version=TLS1 cipher=ECDHE-ECDSA-AES128-SHA bits=128/128); Fri, 18 Sep 2020 14:19:20 -0700 (PDT) Date: Fri, 18 Sep 2020 14:19:02 -0700 (PDT) From: Hugh Dickins X-X-Sender: hugh@eggly.anvils To: Yu Zhao cc: Hugh Dickins , Andrew Morton , Michal Hocko , Alex Shi , Steven Rostedt , Ingo Molnar , Johannes Weiner , Vladimir Davydov , Roman Gushchin , Shakeel Butt , Chris Down , Yafang Shao , Vlastimil Babka , Huang Ying , Pankaj Gupta , Matthew Wilcox , Konstantin Khlebnikov , Minchan Kim , Jaewon Kim , cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 00/13] mm: clean up some lru related pieces In-Reply-To: <20200918210126.GA1118730@google.com> Message-ID: References: <20200918030051.650890-1-yuzhao@google.com> <20200918210126.GA1118730@google.com> User-Agent: Alpine 2.11 (LSU 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, 18 Sep 2020, Yu Zhao wrote: > On Fri, Sep 18, 2020 at 01:46:59PM -0700, Hugh Dickins wrote: > > On Thu, 17 Sep 2020, Yu Zhao wrote: > > > > > Hi Andrew, > > > > > > I see you have taken this: > > > mm: use add_page_to_lru_list()/page_lru()/page_off_lru() > > > Do you mind dropping it? > > > > > > Michal asked to do a bit of additional work. So I thought I probably > > > should create a series to do more cleanups I've been meaning to. > > > > > > This series contains the change in the patch above and goes a few > > > more steps farther. It's intended to improve readability and should > > > not have any performance impacts. There are minor behavior changes in > > > terms of debugging and error reporting, which I have all highlighted > > > in the individual patches. All patches were properly tested on 5.8 > > > running Chrome OS, with various debug options turned on. > > > > > > Michal, > > > > > > Do you mind taking a looking at the entire series? > > > > > > Thank you. > > > > > > Yu Zhao (13): > > > mm: use add_page_to_lru_list() > > > mm: use page_off_lru() > > > mm: move __ClearPageLRU() into page_off_lru() > > > mm: shuffle lru list addition and deletion functions > > > mm: don't pass enum lru_list to lru list addition functions > > > mm: don't pass enum lru_list to trace_mm_lru_insertion() > > > mm: don't pass enum lru_list to del_page_from_lru_list() > > > mm: rename page_off_lru() to __clear_page_lru_flags() > > > mm: inline page_lru_base_type() > > > mm: VM_BUG_ON lru page flags > > > mm: inline __update_lru_size() > > > mm: make lruvec_lru_size() static > > > mm: enlarge the int parameter of update_lru_size() > > > > > > include/linux/memcontrol.h | 14 ++-- > > > include/linux/mm_inline.h | 115 ++++++++++++++------------------- > > > include/linux/mmzone.h | 2 - > > > include/linux/vmstat.h | 2 +- > > > include/trace/events/pagemap.h | 11 ++-- > > > mm/compaction.c | 2 +- > > > mm/memcontrol.c | 10 +-- > > > mm/mlock.c | 2 +- > > > mm/swap.c | 53 ++++++--------- > > > mm/vmscan.c | 28 +++----- > > > 10 files changed, 95 insertions(+), 144 deletions(-) > > > > > > -- > > > 2.28.0.681.g6f77f65b4e-goog > > > > Sorry, Yu, I may be out-of-line in sending this: but as you know, > > Alex Shi has a long per-memcg lru_lock series playing in much the > > same area (particularly conflicting in mm/swap.c and mm/vmscan.c): > > a patchset that makes useful changes, that I'm very keen to help > > into mmotm a.s.a.p (but not before I've completed diligence). > > > > We've put a lot of effort into its testing, I'm currently reviewing > > it patch by patch (my general silence indicating that I'm busy on that, > > but slow as ever): so I'm a bit discouraged to have its stability > > potentially undermined by conflicting cleanups at this stage. > > > > If there's general agreement that your cleanups are safe and welcome > > (Michal's initial reaction sheds some doubt on that), great: I hope > > that Andrew can fast-track them into mmotm, then Alex rebase on top > > of them, and I then re-test and re-review. > > > > But if that quick agreement is not forthcoming, may I ask you please > > to hold back, and resend based on top of Alex's next posting? > > The per-memcg lru lock series seems a high priority, and I have > absolutely no problem accommodate your request. Many thanks! > > In return, may I ask you or Alex to review this series after you > have finished with per-memcg lru lock (to make sure that I resolve > all the conflicts correctly at least)? Fair enough: I promise to do so. And your rebasing will necessarily lead you to review some parts of Alex's patchset, which will help us all too. Andrew, Yu asked at the start: > > > I see you have taken this: > > > mm: use add_page_to_lru_list()/page_lru()/page_off_lru() > > > Do you mind dropping it? Dropping that for now will help too. Thanks, Hugh