From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.9 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1, USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2FD6C43463 for ; Fri, 18 Sep 2020 20:47:06 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 1D3EE221EC for ; Fri, 18 Sep 2020 20:47:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="WjGWRtLt" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1D3EE221EC Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 6CE076B0093; Fri, 18 Sep 2020 16:47:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 67D036B0095; Fri, 18 Sep 2020 16:47:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 56BBE6B0096; Fri, 18 Sep 2020 16:47:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0183.hostedemail.com [216.40.44.183]) by kanga.kvack.org (Postfix) with ESMTP id 3EE5A6B0093 for ; Fri, 18 Sep 2020 16:47:05 -0400 (EDT) Received: from smtpin19.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 09B46181AEF15 for ; Fri, 18 Sep 2020 20:47:05 +0000 (UTC) X-FDA: 77277366810.19.laugh97_19005462712e Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin19.hostedemail.com (Postfix) with ESMTP id D2B021AD1BA for ; Fri, 18 Sep 2020 20:47:04 +0000 (UTC) X-HE-Tag: laugh97_19005462712e X-Filterd-Recvd-Size: 6776 Received: from mail-oi1-f196.google.com (mail-oi1-f196.google.com [209.85.167.196]) by imf36.hostedemail.com (Postfix) with ESMTP for ; Fri, 18 Sep 2020 20:47:04 +0000 (UTC) Received: by mail-oi1-f196.google.com with SMTP id w16so8597710oia.2 for ; Fri, 18 Sep 2020 13:47:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=2ZugjWO+M2gB8NAEaOpinUsTCy83ITVXPQJJCuUh0tk=; b=WjGWRtLtK/iF2JBGFvAFhBIIWnfYlGitLxgWOb55+90M8NWyeyAYHjMqullm40yEpn lmqlNP/RdMdof/dlgrXD7LIEh4QFBziiZqBFLkYpx6nqO0LhGPGEOc0jUI2Om0ofv1UI S/Hy5kwkEn3elzHAQrdsgG/Q9wGl2K6SM0TmW2KTpFSeBnGKYLHA64mphmfHRP2oHqcu Nw/MpK/R0Xy+kPNtblr1tupxRaInMGtJ8M9fnfZcWJFSLNg21CPbG28w+j/zksLAp7Vl 8clu8q+f9R+5RyuSHTYM6Cv81znd/ZP0aNzgFVSvrVYxc8q3XTCLKcwPTT/gq68bMO0y Um1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=2ZugjWO+M2gB8NAEaOpinUsTCy83ITVXPQJJCuUh0tk=; b=UmB9vG3wLF7Hbl57++rGqLsVI2haC/krn6RHnbVwi4tn/709qzEnzfXEiDNTUYSipr SE/uJhCeZOdx+53JCYi09QRpqxbxXO+RAUkuYeKZ5rumilFeLB1EgnCRTnot60nHPPDW J7r8q8+lZSHrTkqesW4uMccGB3eEvVvZNcij49oQNqwJplliYK5eKUiOjq44fgTQ6rEV eCG1Is/DtAGE3ViaqT7dLbwyXG7oc8kQ259MDkFgvg8iS3NGuIosOmvBdU+ufpB0n4px frCy9DjDtGIJ4cO4UrIj4hKNIbcJKYTxYmITUZqdAaf5Sd7s/oey94yUGNIrH9ASu7gC +MnA== X-Gm-Message-State: AOAM530gopm7e7Rj74V3Qs5HVgRKOnAbgLCkH4MMHIfG0sxZBMlntGtL Bx4PFR2BPeVexsm59v44f/me6g== X-Google-Smtp-Source: ABdhPJxhcH3QXqNAiG7aPKPSB6t+sNO8rx1LG/17sQfL1FrCEcHVAqnygmkDHVSAZLGwrxyv727Pkg== X-Received: by 2002:aca:3e08:: with SMTP id l8mr9960330oia.152.1600462023374; Fri, 18 Sep 2020 13:47:03 -0700 (PDT) Received: from eggly.attlocal.net (172-10-233-147.lightspeed.sntcca.sbcglobal.net. [172.10.233.147]) by smtp.gmail.com with ESMTPSA id s5sm3116602otr.42.2020.09.18.13.47.00 (version=TLS1 cipher=ECDHE-ECDSA-AES128-SHA bits=128/128); Fri, 18 Sep 2020 13:47:02 -0700 (PDT) Date: Fri, 18 Sep 2020 13:46:59 -0700 (PDT) From: Hugh Dickins X-X-Sender: hugh@eggly.anvils To: Yu Zhao cc: Andrew Morton , Michal Hocko , Alex Shi , Steven Rostedt , Ingo Molnar , Johannes Weiner , Vladimir Davydov , Roman Gushchin , Shakeel Butt , Chris Down , Yafang Shao , Vlastimil Babka , Huang Ying , Pankaj Gupta , Matthew Wilcox , Konstantin Khlebnikov , Minchan Kim , Jaewon Kim , cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 00/13] mm: clean up some lru related pieces In-Reply-To: <20200918030051.650890-1-yuzhao@google.com> Message-ID: References: <20200918030051.650890-1-yuzhao@google.com> User-Agent: Alpine 2.11 (LSU 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, 17 Sep 2020, Yu Zhao wrote: > Hi Andrew, > > I see you have taken this: > mm: use add_page_to_lru_list()/page_lru()/page_off_lru() > Do you mind dropping it? > > Michal asked to do a bit of additional work. So I thought I probably > should create a series to do more cleanups I've been meaning to. > > This series contains the change in the patch above and goes a few > more steps farther. It's intended to improve readability and should > not have any performance impacts. There are minor behavior changes in > terms of debugging and error reporting, which I have all highlighted > in the individual patches. All patches were properly tested on 5.8 > running Chrome OS, with various debug options turned on. > > Michal, > > Do you mind taking a looking at the entire series? > > Thank you. > > Yu Zhao (13): > mm: use add_page_to_lru_list() > mm: use page_off_lru() > mm: move __ClearPageLRU() into page_off_lru() > mm: shuffle lru list addition and deletion functions > mm: don't pass enum lru_list to lru list addition functions > mm: don't pass enum lru_list to trace_mm_lru_insertion() > mm: don't pass enum lru_list to del_page_from_lru_list() > mm: rename page_off_lru() to __clear_page_lru_flags() > mm: inline page_lru_base_type() > mm: VM_BUG_ON lru page flags > mm: inline __update_lru_size() > mm: make lruvec_lru_size() static > mm: enlarge the int parameter of update_lru_size() > > include/linux/memcontrol.h | 14 ++-- > include/linux/mm_inline.h | 115 ++++++++++++++------------------- > include/linux/mmzone.h | 2 - > include/linux/vmstat.h | 2 +- > include/trace/events/pagemap.h | 11 ++-- > mm/compaction.c | 2 +- > mm/memcontrol.c | 10 +-- > mm/mlock.c | 2 +- > mm/swap.c | 53 ++++++--------- > mm/vmscan.c | 28 +++----- > 10 files changed, 95 insertions(+), 144 deletions(-) > > -- > 2.28.0.681.g6f77f65b4e-goog Sorry, Yu, I may be out-of-line in sending this: but as you know, Alex Shi has a long per-memcg lru_lock series playing in much the same area (particularly conflicting in mm/swap.c and mm/vmscan.c): a patchset that makes useful changes, that I'm very keen to help into mmotm a.s.a.p (but not before I've completed diligence). We've put a lot of effort into its testing, I'm currently reviewing it patch by patch (my general silence indicating that I'm busy on that, but slow as ever): so I'm a bit discouraged to have its stability potentially undermined by conflicting cleanups at this stage. If there's general agreement that your cleanups are safe and welcome (Michal's initial reaction sheds some doubt on that), great: I hope that Andrew can fast-track them into mmotm, then Alex rebase on top of them, and I then re-test and re-review. But if that quick agreement is not forthcoming, may I ask you please to hold back, and resend based on top of Alex's next posting? Thanks, Hugh