From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.9 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1, USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12656C433E2 for ; Tue, 15 Sep 2020 08:10:14 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 82E9F21D24 for ; Tue, 15 Sep 2020 08:10:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="nIyTzeIB" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 82E9F21D24 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 9824B90002C; Tue, 15 Sep 2020 04:10:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9323290001D; Tue, 15 Sep 2020 04:10:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8481C90002C; Tue, 15 Sep 2020 04:10:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0191.hostedemail.com [216.40.44.191]) by kanga.kvack.org (Postfix) with ESMTP id 6E98590001D for ; Tue, 15 Sep 2020 04:10:12 -0400 (EDT) Received: from smtpin08.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 2E9153628 for ; Tue, 15 Sep 2020 08:10:12 +0000 (UTC) X-FDA: 77264573064.08.sort79_0d04f422710f Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin08.hostedemail.com (Postfix) with ESMTP id 033E71819E798 for ; Tue, 15 Sep 2020 08:10:11 +0000 (UTC) X-HE-Tag: sort79_0d04f422710f X-Filterd-Recvd-Size: 6103 Received: from mail-qk1-f193.google.com (mail-qk1-f193.google.com [209.85.222.193]) by imf45.hostedemail.com (Postfix) with ESMTP for ; Tue, 15 Sep 2020 08:10:11 +0000 (UTC) Received: by mail-qk1-f193.google.com with SMTP id q5so3408312qkc.2 for ; Tue, 15 Sep 2020 01:10:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=+JVatOz5/Dh/xyAg85UUTlc2Kova9GVo8Ydw6vbee8g=; b=nIyTzeIBrWUervNx+ZYSIQs3H/l6i7vwus2Ha3I8FVsJWME+6Q6zBuLHukcO1Xcij/ j5R4e/ZCmOxtNw9oAWHeZq7ZmEeuOE1wVGnjbF/JEFb/h3Gpyr0zY82TI5IU8HJa3iwt wI+5RRixk+oQKYUF3g9xUmcY8v+Lbh/cTzjxMNENwyG+h/fSBMLQK4/VS47P+Igi7oZ1 9UckvC1TShzWV6/MknJfpHzSm2rh16Zq6E3B4Oi9mvYBkd/oM5Ats+6fyFmiLQab2Du2 7pn/Dd1cLCSugZFKNESH19JPHq/CXBJqNAhX10PcHYs8QaZCnL/QDibmKOhKsKMRnISA U9IA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=+JVatOz5/Dh/xyAg85UUTlc2Kova9GVo8Ydw6vbee8g=; b=Hc5+lIJYTPM70zDv8jHqYsaV5eKKqHnF/CLRGBfOn3U0MtbOm/xwZqHYPSqf0wR39o lagKGl2Oy1NDqSiMabiPDKwnP7PeiFCTcZsyxqg/7DngfUWxjvAcwb3Ijs0sj0bToH5G BxFaoh3Y8WNFFvq73ph6Mf5JoKPJZw/lZnNaomo6sGVaj7EvUS5e40wpSqXqpnyAkXGB OcQHlWEBgesEYiTJP+5HVT2tFhn3TFtPHgwUXRlk9zVAPq+46ukZNbx1McSP30X+QNc4 71VuDZlEaYfYbo/rRHwvpeIGiXNz9TxMB5l62svZQzPrEz51CU795aAYPn3I/J7fehu8 BpNA== X-Gm-Message-State: AOAM530Y8SmP1y/7NFU3EjkT1tck6g7CeyO1WHkmRVcJs0VI/A5Kxf4+ Mmu18v5JXC9U98AVzwlmJawogA== X-Google-Smtp-Source: ABdhPJyS7xJTZfyWz8c4kNJtOicW4XfjWeOIR89eyPboMltYWj+TUMAFVzJOuE70LfMxUb5VQs5eUg== X-Received: by 2002:a37:a602:: with SMTP id p2mr16652323qke.254.1600157410569; Tue, 15 Sep 2020 01:10:10 -0700 (PDT) Received: from eggly.attlocal.net (172-10-233-147.lightspeed.sntcca.sbcglobal.net. [172.10.233.147]) by smtp.gmail.com with ESMTPSA id u4sm15673927qkk.68.2020.09.15.01.10.06 (version=TLS1 cipher=ECDHE-ECDSA-AES128-SHA bits=128/128); Tue, 15 Sep 2020 01:10:08 -0700 (PDT) Date: Tue, 15 Sep 2020 01:10:05 -0700 (PDT) From: Hugh Dickins X-X-Sender: hugh@eggly.anvils To: "Matthew Wilcox (Oracle)" cc: linux-mm@kvack.org, Andrew Morton , Hugh Dickins , William Kucharski , Jani Nikula , Alexey Dobriyan , Johannes Weiner , Chris Wilson , Matthew Auld , Huang Ying , intel-gfx@lists.freedesktop.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 0/8] Return head pages from find_*_entry In-Reply-To: <20200910183318.20139-1-willy@infradead.org> Message-ID: References: <20200910183318.20139-1-willy@infradead.org> User-Agent: Alpine 2.11 (LSU 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Rspamd-Queue-Id: 033E71819E798 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam04 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, 10 Sep 2020, Matthew Wilcox (Oracle) wrote: > This patch series started out as part of the THP patch set, but it has > some nice effects along the way and it seems worth splitting it out and > submitting separately. > > Currently find_get_entry() and find_lock_entry() return the page > corresponding to the requested index, but the first thing most callers do > is find the head page, which we just threw away. As part of auditing > all the callers, I found some misuses of the APIs and some plain > inefficiencies that I've fixed. > > The diffstat is unflattering, but I added more kernel-doc and a new wrapper. > > v2: > - Rework how shmem_getpage_gfp() handles getting a head page back from > find_lock_entry() > - Renamed find_get_swap_page() to find_get_incore_page() > - Make sure find_get_incore_page() doesn't return a head page > - Fix the missing include of linux/shmem_fs.h > - Move find_get_entry and find_lock_entry prototypes to mm/internal.h > - Rename thp_valid_index() to thp_contains() > - Fix thp_contains() for hugetlbfs and swapcache > - Add find_lock_head() wrapper around pagecache_get_page() > > Matthew Wilcox (Oracle) (8): > mm: Factor find_get_incore_page out of mincore_page > mm: Use find_get_incore_page in memcontrol > mm: Optimise madvise WILLNEED > proc: Optimise smaps for shmem entries > i915: Use find_lock_page instead of find_lock_entry > mm: Convert find_get_entry to return the head page > mm/shmem: Return head page from find_lock_entry > mm: Add find_lock_head > > drivers/gpu/drm/i915/gem/i915_gem_shmem.c | 4 +-- > fs/proc/task_mmu.c | 8 +---- > include/linux/pagemap.h | 43 +++++++++++++++++----- > include/linux/swap.h | 7 ++++ > mm/filemap.c | 44 +++++++++++------------ > mm/internal.h | 3 ++ > mm/madvise.c | 21 ++++++----- > mm/memcontrol.c | 24 ++----------- > mm/mincore.c | 28 ++------------- > mm/shmem.c | 20 +++++------ > mm/swap_state.c | 32 +++++++++++++++++ > 11 files changed, 127 insertions(+), 107 deletions(-) > > -- > 2.28.0 I was testing mmotm today (plus the shmem.c and swap_state.c fixes that you posted, but I did not try the madvise.c one) - my usual tmpfs swapping loads (plus hyperactive khugepaged to maximize the THPs). It behaved well, no problems found. But I probably won't get to try your series of 12 for a few days. Hugh