From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.9 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1, USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61B53C433E3 for ; Tue, 25 Aug 2020 02:05:10 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 22B16204EC for ; Tue, 25 Aug 2020 02:05:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="Qx7zECjP" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 22B16204EC Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id B838C900020; Mon, 24 Aug 2020 22:05:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B33C68D0002; Mon, 24 Aug 2020 22:05:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9FBA4900020; Mon, 24 Aug 2020 22:05:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0166.hostedemail.com [216.40.44.166]) by kanga.kvack.org (Postfix) with ESMTP id 867A18D0002 for ; Mon, 24 Aug 2020 22:05:09 -0400 (EDT) Received: from smtpin29.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 4A79A8248047 for ; Tue, 25 Aug 2020 02:05:09 +0000 (UTC) X-FDA: 77187448338.29.month95_520d54627058 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin29.hostedemail.com (Postfix) with ESMTP id 195F818086CDD for ; Tue, 25 Aug 2020 02:05:09 +0000 (UTC) X-HE-Tag: month95_520d54627058 X-Filterd-Recvd-Size: 5421 Received: from mail-ot1-f67.google.com (mail-ot1-f67.google.com [209.85.210.67]) by imf35.hostedemail.com (Postfix) with ESMTP for ; Tue, 25 Aug 2020 02:05:08 +0000 (UTC) Received: by mail-ot1-f67.google.com with SMTP id o8so6424173otp.9 for ; Mon, 24 Aug 2020 19:05:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=xCEzVSHJfiSnfhxabuVNC9t0rkX2zX2AVt5dsDA1M40=; b=Qx7zECjPFmyvrTTs8F/ocW7tCcVkTwhnunAlXDXZ02SD4HEo5pHK0qvUZ8cmV197QW 23MJoL24elKzlrQkZr8Yc7T8ZQWrmKbeOUd4hY5pKufw1Z5VW9CMRTRZfbjXU1Za+2yc qRLjAl0KCQd2veC9jbi1F0Watbt0V5rKLyNSxNLUGzhHJw2G/qIDuCpOTi/JiHnQg6Lr gSCfATvLRBLoL6yZredvS7LzkNyRekKGV1W4rh92bKf6/LJkuKnmLxgLMp2gUOAexBpV MmYNyURSACJ5Zg10joqtevQml+/+IDZ7wYzyaTgpNw8011WUWi4XwnMLAStJVcudiGaV qJuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=xCEzVSHJfiSnfhxabuVNC9t0rkX2zX2AVt5dsDA1M40=; b=n0eRhFqKOM1MlGvBGLRdXIiEj3tW+mArADy7Sx4pwqNe2tvq8B4IGbOWK3jyYHwH9M /SxjBOWSb9P3epxWRTb5ULhB8k97pfVcE6mzyeme4HZEgQWluknecnb5Wp4sb0OuZCdX LleBaEBCfpS8xjWc41xr+ehxjxJwcigxDnjut5+Jf4EDyYjP/Nowi7sGn5czDCZAXWdk 1axmAcpdu9OI8/y35Skg2HYhC1ecOTr/qWeDWrIHXx+/yVl3zR5fz0UZ9STookarfRDE N1T6dFM3Gp7UCDU9vtd3RH0fCg4zOqETGmY4WCZp022TKJ2ztX1NAb/lIYqbazMN0O4W ah1A== X-Gm-Message-State: AOAM530GWp4JMeRdhOZuExkYlAoQlFR2P7ZGKo9wULDj4Wi6tLNDgd3T UrjmLQmfAgcacN7DaK4GmpHhBA== X-Google-Smtp-Source: ABdhPJxzM2WV+TVOMQL/4Ow6BMstFoj6g+xmPTXBpDKBq7id1uxSEggrr4ObCz8lU1snOf/c5wzcZg== X-Received: by 2002:a9d:12a9:: with SMTP id g38mr5224481otg.299.1598321107433; Mon, 24 Aug 2020 19:05:07 -0700 (PDT) Received: from eggly.attlocal.net (172-10-233-147.lightspeed.sntcca.sbcglobal.net. [172.10.233.147]) by smtp.gmail.com with ESMTPSA id w62sm2402101otb.52.2020.08.24.19.05.05 (version=TLS1 cipher=ECDHE-ECDSA-AES128-SHA bits=128/128); Mon, 24 Aug 2020 19:05:06 -0700 (PDT) Date: Mon, 24 Aug 2020 19:04:53 -0700 (PDT) From: Hugh Dickins X-X-Sender: hugh@eggly.anvils To: Alex Shi cc: Michal Hocko , Qian Cai , akpm@linux-foundation.org, Johannes Weiner , Vladimir Davydov , cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, nao.horiguchi@gmail.com, osalvador@suse.de, mike.kravetz@oracle.com Subject: Re: [Resend PATCH 1/6] mm/memcg: warning on !memcg after readahead page charged In-Reply-To: <12425e06-38ce-7ff4-28ce-b0418353fc67@linux.alibaba.com> Message-ID: References: <1597144232-11370-1-git-send-email-alex.shi@linux.alibaba.com> <20200820145850.GA4622@lca.pw> <20200821080127.GD32537@dhcp22.suse.cz> <20200821123934.GA4314@lca.pw> <20200821134842.GF32537@dhcp22.suse.cz> <20200824151013.GB3415@dhcp22.suse.cz> <12425e06-38ce-7ff4-28ce-b0418353fc67@linux.alibaba.com> User-Agent: Alpine 2.11 (LSU 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Rspamd-Queue-Id: 195F818086CDD X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam02 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 25 Aug 2020, Alex Shi wrote: > reproduce using our linux-mm random bug collection on NUMA systems. > >> > >> OK, I must have missed that this was on ppc. The order makes more sense > >> now. I will have a look at this next week. > > > > OK, so I've had a look and I know what's going on there. The > > move_pages12 is migrating hugetlb pages. Those are not charged to any > > memcg. We have completely missed this case. There are two ways going > > around that. Drop the warning and update the comment so that we do not > > forget about that or special case hugetlb pages. > > > > I think the first option is better. > > > > > Hi Michal, > > Compare to ignore the warning which is designed to give, seems addressing > the hugetlb out of charge issue is a better solution, otherwise the memcg > memory usage is out of control on hugetlb, is that right? Please don't suppose that this is peculiar to hugetlb: I'm not testing hugetlb at all (sorry), but I see the VM_WARN_ON_ONCE from mem_cgroup_page_lruvec(), and from mem_cgroup_migrate(), and from mem_cgroup_swapout(). In all cases seen on a PageAnon page (well, in one case PageKsm). And not related to THP either: seen also on machine incapable of THP. Maybe there's an independent change in 5.9-rc that's defeating expectations here, or maybe they were never valid. Worth investigating, even though the patch is currently removed, to find out why expectations were wrong. You'll ask me for more info, stacktraces etc, and I'll say sorry, no time today. Please try the swapping tests I sent before. And may I say, the comment /* Readahead page is charged too, to see if other page uncharged */ is nonsensical to me, and much better deleted: maybe it would make some sense if the reader could see the comment it replaces - as they can in the patch - but not in the resulting source file. Hugh