From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.1 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1, USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B0EFC433E0 for ; Thu, 6 Aug 2020 11:21:45 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id BE16322D02 for ; Thu, 6 Aug 2020 11:21:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="lXg8hPY0" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BE16322D02 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 66F836B0006; Thu, 6 Aug 2020 01:46:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 61FCE6B0007; Thu, 6 Aug 2020 01:46:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4E6FE6B0008; Thu, 6 Aug 2020 01:46:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0034.hostedemail.com [216.40.44.34]) by kanga.kvack.org (Postfix) with ESMTP id 3A5136B0006 for ; Thu, 6 Aug 2020 01:46:18 -0400 (EDT) Received: from smtpin19.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id E19973624 for ; Thu, 6 Aug 2020 05:46:17 +0000 (UTC) X-FDA: 77119058394.19.rings10_61082d126fb5 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin19.hostedemail.com (Postfix) with ESMTP id BF1201AD1B4 for ; Thu, 6 Aug 2020 05:46:17 +0000 (UTC) X-HE-Tag: rings10_61082d126fb5 X-Filterd-Recvd-Size: 6742 Received: from mail-ot1-f68.google.com (mail-ot1-f68.google.com [209.85.210.68]) by imf17.hostedemail.com (Postfix) with ESMTP for ; Thu, 6 Aug 2020 05:46:17 +0000 (UTC) Received: by mail-ot1-f68.google.com with SMTP id 93so25127119otx.2 for ; Wed, 05 Aug 2020 22:46:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=ZaqiVLeoazR8CQkUYq5gppTrJuQmd0jN3Fkv88tkHZ8=; b=lXg8hPY0BmpGcYaRUchxmHWlFW+9e0oKPAB8zBqsFvDUDUFNdgW2oK0pVmG8vYYpK6 HJmAxj9jttkdlgsVM/cddriqU58ErheTTpQN8wjaneDSCH5TaaOfpWOPc8ArN/0HUO42 sLQleP56GlPaA2igOPdscQwwfi7wC4286H09lAr0agiItTYgbqojuxiPaCDhokeSHxsL YDUlbmMs98MWo7qo0HGDJ4q2bdsuM6QjcGvO+qapxkI9kDwYMnc+n4c4yqKHuCsa773A 37fUMz2x1/2PDP+ccsKkEGd50GohU0bmKOMcn4R/TN3bXkVwGr6mTdnaQSQse2mp+c2Z gW+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=ZaqiVLeoazR8CQkUYq5gppTrJuQmd0jN3Fkv88tkHZ8=; b=tT5U7uzN5mcnyl5yLxqLvy+S7nUnGf7G2DRQrJ5vbEEQiVeBaDNitOybLqMfFBLfXw tJ4/+dxwTcsqzaSuCn/YExqr2LcO5maJOrwqrRvIhfOGTBieqs3aP9If6Q5nApnyI7t3 9TlP3ybm2v6QIXwmVg38kS0ptfn7EbhhJmwOQCWUnhKsTx4tOR0YDXFzIn4L3yGlYYaF xVDvpHnsWsUYaB5/vRlhNi8vFdmp8RtJoZ0gHdlP+xicE12Wql+QYoN0kQ18FUdaUQ2J XigPBITl0aYeVjQdZ+vdp84QhXW4xfZ4xxAU+ndh5aVurXn8ZxMUfhKnt7z0Em485w0E Ep0Q== X-Gm-Message-State: AOAM533gMZqQPA4TW5YKGC7yTr8gOhbxkTE0ycIYKlYxODmogTSATIt9 Z9Se9xzFXXfhljn6SyO7sgCE2g== X-Google-Smtp-Source: ABdhPJy5o1IUmeAPs1J1R0jyj3A4334OcHJ6zDgUjb5xy7bS5RNnkj02GoG31GNRl0F1FVxN+w4J/w== X-Received: by 2002:a9d:38f:: with SMTP id f15mr5915614otf.74.1596692776353; Wed, 05 Aug 2020 22:46:16 -0700 (PDT) Received: from eggly.attlocal.net (172-10-233-147.lightspeed.sntcca.sbcglobal.net. [172.10.233.147]) by smtp.gmail.com with ESMTPSA id z72sm952656ooa.42.2020.08.05.22.46.13 (version=TLS1 cipher=ECDHE-ECDSA-AES128-SHA bits=128/128); Wed, 05 Aug 2020 22:46:14 -0700 (PDT) Date: Wed, 5 Aug 2020 22:46:12 -0700 (PDT) From: Hugh Dickins X-X-Sender: hugh@eggly.anvils To: Greg KH cc: Hugh Dickins , Linus Torvalds , Oleg Nesterov , Michal Hocko , Linux-MM , LKML , Andrew Morton , Tim Chen , Michal Hocko Subject: Re: [RFC PATCH] mm: silence soft lockups from unlock_page In-Reply-To: <20200727193512.GA236164@kroah.com> Message-ID: References: <20200724152424.GC17209@redhat.com> <20200725101445.GB3870@redhat.com> <20200727193512.GA236164@kroah.com> User-Agent: Alpine 2.11 (LSU 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Rspamd-Queue-Id: BF1201AD1B4 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam05 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, 27 Jul 2020, Greg KH wrote: > > Linus just pointed me at this thread. > > If you could run: > echo -n 'module xhci_hcd =p' > /sys/kernel/debug/dynamic_debug/control > and run the same workload to see if anything shows up in the log when > xhci crashes, that would be great. Thanks, I tried that, and indeed it did have a story to tell: ep 0x81 - asked for 16 bytes, 10 bytes untransferred ep 0x81 - asked for 16 bytes, 10 bytes untransferred ep 0x81 - asked for 16 bytes, 10 bytes untransferred a very large number of lines like the above, then Cancel URB 00000000d81602f7, dev 4, ep 0x0, starting at offset 0xfffd42c0 // Ding dong! ep 0x81 - asked for 16 bytes, 10 bytes untransferred Stopped on No-op or Link TRB for slot 1 ep 0 xhci_drop_endpoint called for udev 000000005bc07fa6 drop ep 0x81, slot id 1, new drop flags = 0x8, new add flags = 0x0 add ep 0x81, slot id 1, new drop flags = 0x8, new add flags = 0x8 xhci_check_bandwidth called for udev 000000005bc07fa6 // Ding dong! Successful Endpoint Configure command Cancel URB 000000006b77d490, dev 4, ep 0x81, starting at offset 0x0 // Ding dong! Stopped on No-op or Link TRB for slot 1 ep 2 Removing canceled TD starting at 0x0 (dma). list_del corruption: prev(ffff8fdb4de7a130)->next should be ffff8fdb41697f88, but is 6b6b6b6b6b6b6b6b; next(ffff8fdb4de7a130)->prev is 6b6b6b6b6b6b6b6b. ------------[ cut here ]------------ kernel BUG at lib/list_debug.c:53! RIP: 0010:__list_del_entry_valid+0x8e/0xb0 Call Trace: handle_cmd_completion+0x7d4/0x14f0 [xhci_hcd] xhci_irq+0x242/0x1ea0 [xhci_hcd] xhci_msi_irq+0x11/0x20 [xhci_hcd] __handle_irq_event_percpu+0x48/0x2c0 handle_irq_event_percpu+0x32/0x80 handle_irq_event+0x4a/0x80 handle_edge_irq+0xd8/0x1b0 handle_irq+0x2b/0x50 do_IRQ+0xb6/0x1c0 common_interrupt+0x90/0x90 Info provided for your interest, not expecting any response. The list_del info in there is non-standard, from a patch of mine: I find hashed addresses in debug output less than helpful. > > Although if you are using an "older version" of the driver, there's not > much I can suggest except update to a newer one :) Yes, I was reluctant to post any info, since really the ball is at our end of the court, not yours. I did have a go at bringing in the latest xhci driver instead, but quickly saw that was not a sensible task for me. And I did scan the git log of xhci changes (especially xhci-ring.c changes): thought I saw a likely relevant and easily applied fix commit, but in fact it made no difference here. I suspect it's in part a hardware problem, but driver not recovering correctly. I've replaced the machine (but also noticed that the same crash has occasionally been seen on other machines). I'm sure it has no relevance to this unlock_page() thread, though it's quite possible that it's triggered under stress, and Linus's changes allowed greater stress. Hugh