From: Hugh Dickins <hughd@google.com>
To: Qian Cai <cai@lca.pw>
Cc: Artem Savkov <asavkov@redhat.com>, Baoquan He <bhe@redhat.com>,
Michal Hocko <mhocko@suse.com>, Hugh Dickins <hughd@google.com>,
Andrea Arcangeli <aarcange@redhat.com>,
torvalds@linux-foundation.org, vbabka@suse.cz,
akpm@linux-foundation.org, Linux-MM <linux-mm@kvack.org>
Subject: Re: BUG() due to "mm: put_and_wait_on_page_locked() while page is migrated"
Date: Tue, 5 Feb 2019 11:08:42 -0800 (PST) [thread overview]
Message-ID: <alpine.LSU.2.11.1902051103300.9007@eggly.anvils> (raw)
In-Reply-To: <5bf18231-4039-10ad-4d2b-cac856a998c3@lca.pw>
On Fri, 25 Jan 2019, Qian Cai wrote:
> On 1/25/19 3:51 AM, Michal Hocko wrote:
> > On Thu 24-01-19 23:31:46, Qian Cai wrote:
> > [...]
> >> It looks like the put_and_wait commit just make the bug easier to reproduce, as
> >> it has finally been able to reproduce it (via a different path) after 50+ runs
> >> of migrate_pages03 on one of the affected machines even with the commit reverted.
> >
> > OK, great. This makes it a little bit less of a head scratcher then.
> > Could you confirm whether this is FS specific please? I will go and
> > check the migration path. Maybe we doing something wrong there but it
> > would be definitely good to know whether the underlying fs is really
> > relevant. Thanks!
> >
>
> So, I reinstalled everything using an ext4 rootfs, and then it becomes
> impossible to reproduce it anymore...
Just to wrap up this thread: Artem Savkov has identified 5.0-rc5 commit
8e47a457321c "iomap: get/put the page in iomap_page_create/release()"
as fixing this issue on xfs (iomap), and Cai verified, in other thread
https://marc.info/?l=linux-kernel&m=154927160417473&w=2
prev parent reply other threads:[~2019-02-05 19:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-23 4:29 Qian Cai
2019-01-23 9:30 ` Michal Hocko
2019-01-25 4:19 ` Hugh Dickins
2019-01-25 4:19 ` Hugh Dickins
2019-01-25 4:31 ` Qian Cai
2019-01-25 8:51 ` Michal Hocko
2019-01-26 3:17 ` Qian Cai
2019-02-05 19:08 ` Hugh Dickins [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LSU.2.11.1902051103300.9007@eggly.anvils \
--to=hughd@google.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=asavkov@redhat.com \
--cc=bhe@redhat.com \
--cc=cai@lca.pw \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=torvalds@linux-foundation.org \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox