RE: ksmd lockup - kernel 4.11-rc series

[Hugh Dickins <hughd@google.com>]

On Thu, 6 Apr 2017, Doug Smythies wrote:
> Hi,
> 
> Thank you for your quick work on this.
> 
> On 2017.04.02 17:03 Hugh Dickins wrote:
> > On Tue, 28 Mar 2017, Hugh Dickins wrote:
> >> On Tue, 28 Mar 2017, Kirill A. Shutemov wrote:
> >>> On Mon, Mar 27, 2017 at 04:16:00PM -0700, Doug Smythies wrote:
> 
> ...[snip]...
> 
> > Worked out what it was yesterday, but my first patch failed overnight:
> > I'd missed the placement of the next_pte label.  It had a similar fix
> > to mm/migrate.c in it, that hit me too in testing; but this morning I
> > find Naoya's 4b0ece6fa016 in git, which fixes that.
> 
> I think I got that one sometimes also.
> 
> >  Same issue here.
> >
> > [PATCH] mm: fix page_vma_mapped_walk() for ksm pages
> 
> ... [snip] ...
> 
> To establish a baseline, I ran kernel 4.11-rc5 without this
> patch for 24 hours. The failure occurred twice.
> 
> I have been running the exact same scenario with the patch
> for 55 hours now without any issues.

Great, thanks a lot for your careful testing and report.

> 
> Note: I stayed with version 1 of the patch, even though there
> was a version 2 sent out on Monday.

Right, I'd have done the same once useful testing was under way:
that's fine, the fix is the same, but version 2 looks more elegant.

I guess Andrew can add
Tested-by: Doug Smythies <dsmythies@telus.net>
or replace the Reported-by tag by
Reported-and-Tested-by: Doug Smythies <dsmythies@telus.net>
I'm not sure which is in fashion at present.

Thanks!
Hugh

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>