Re: [PATCH] mm: remove the unused gfp arg to shmem_add_to_page_cache

[Hugh Dickins <hughd@google.com>]

On Tue, 15 Jul 2014, Wang Sheng-Hui wrote:
> 
> The gfp arg is not used in shmem_add_to_page_cache.
> Remove this unused arg.
> 
> Signed-off-by: Wang Sheng-Hui <shhuiw@gmail.com>

Looks right, but checkpatch.pl has some complaints about the spaces:
please fix those.  Maybe you started off with tabs, and gmail turned
them into spaces.  gmail is an outstandingly excellent mailer (;)
but unhelpful on patches.  See Documentation/email-clients.txt or
Documentation/zh_CN/email-clients.txt.  Maybe "git send-email" will
get around it for you.

Thanks,
Hugh

> ---
>  mm/shmem.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/mm/shmem.c b/mm/shmem.c
> index 1140f49..63cc6af 100644
> --- a/mm/shmem.c
> +++ b/mm/shmem.c
> @@ -280,7 +280,7 @@ static bool shmem_confirm_swap(struct address_space *mapping,
>   */
>  static int shmem_add_to_page_cache(struct page *page,
>                                    struct address_space *mapping,
> -                                  pgoff_t index, gfp_t gfp, void *expected)
> +                                  pgoff_t index, void *expected)
>  {
>         int error;
> 
> @@ -643,7 +643,7 @@ static int shmem_unuse_inode(struct shmem_inode_info *info,
>          */
>         if (!error)
>                 error = shmem_add_to_page_cache(*pagep, mapping, index,
> -                                               GFP_NOWAIT, radswap);
> +                                               radswap);
>         if (error != -ENOMEM) {
>                 /*
>                  * Truncation and eviction use free_swap_and_cache(), which
> @@ -1089,7 +1089,7 @@ repeat:
>                                                 gfp & GFP_RECLAIM_MASK);
>                 if (!error) {
>                         error = shmem_add_to_page_cache(page, mapping, index,
> -                                               gfp, swp_to_radix_entry(swap));
> +                                               swp_to_radix_entry(swap));
>                         /*
>                          * We already confirmed swap under page lock, and make
>                          * no memory allocation here, so usually no possibility
> @@ -1152,7 +1152,7 @@ repeat:
>                 error = radix_tree_maybe_preload(gfp & GFP_RECLAIM_MASK);
>                 if (!error) {
>                         error = shmem_add_to_page_cache(page, mapping, index,
> -                                                       gfp, NULL);
> +                                                       NULL);
>                         radix_tree_preload_end();
>                 }
>                 if (error) {
> -- 
> 1.8.3.2

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>