Re: [PATCH] mm/process_vm_access: move into ipc/

[Hugh Dickins <hughd@google.com>]

On Mon, 26 May 2014, Konstantin Khlebnikov wrote:
> On Mon, May 26, 2014 at 11:16 PM, Hugh Dickins <hughd@google.com> wrote:
> > On Sat, 24 May 2014, Konstantin Khlebnikov wrote:
> >
> >> "CROSS_MEMORY_ATTACH" and mm/process_vm_access.c seems misnamed and misplaced.
> >> Actually it's a kind of IPC and it has no more relation to MM than sys_read().
> >> This patch moves code into ipc/ and config option into init/Kconfig.
> >>
> >> Signed-off-by: Konstantin Khlebnikov <koct9i@gmail.com>
> >
> > I disagree, and SysV's ipc/ isn't where I would expect to find it.
> > How about we just leave it where it is in mm?
> 
> Ok, how about moving only config option? It adds couple syscalls and
> nothing more.
> I don't think it should be in "Processor type and features".
> All other options related to non-standard syscalls are in "General
> setup' init/Kconfig.

That sounds reasonable to me.  I see you also snuck in a change
to the prompt string: which indeed seems an improvement, but you
ought to mention it in the comment, rather than hiding it in the move.

(I sometimes wonder if its help text ought to say "This CMA has
absolutely nothing to do with the Contiguous Memory Allocator";
but adding that might increase the confusion rather than reduce it,)

Hugh

> 
> >> diff --git a/init/Kconfig b/init/Kconfig
> >> index 9d3585b..d6ddb7a 100644
> >> --- a/init/Kconfig
> >> +++ b/init/Kconfig
> >> @@ -261,6 +261,16 @@ config POSIX_MQUEUE_SYSCTL
> >>       depends on SYSCTL
> >>       default y
> >>
> >> +config CROSS_MEMORY_ATTACH
> >> +     bool "Enable process_vm_readv/writev syscalls"
> >> +     depends on MMU
> >> +     default y
> >> +     help
> >> +       Enabling this option adds the system calls process_vm_readv and
> >> +       process_vm_writev which allow a process with the correct privileges
> >> +       to directly read from or write to to another process's address space.
> >> +       See the man page for more details.
> >> +
> >> diff --git a/mm/Kconfig b/mm/Kconfig
> >> index 1b5a95f..2ec35d7 100644
> >> --- a/mm/Kconfig
> >> +++ b/mm/Kconfig
> >> @@ -430,16 +430,6 @@ choice
> >>         benefit.
> >>  endchoice
> >>
> >> -config CROSS_MEMORY_ATTACH
> >> -     bool "Cross Memory Support"
> >> -     depends on MMU
> >> -     default y
> >> -     help
> >> -       Enabling this option adds the system calls process_vm_readv and
> >> -       process_vm_writev which allow a process with the correct privileges
> >> -       to directly read from or write to to another process's address space.
> >> -       See the man page for more details.
> >> -
> >>  #
> >>  # UP and nommu archs use km based percpu allocator
> >>  #

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>