From: Hugh Dickins <hughd@google.com>
To: Michal Hocko <mhocko@suse.cz>
Cc: Johannes Weiner <hannes@cmpxchg.org>,
Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: [PATCH 1/3] mm/memcg: fix last_dead_count memory wastage
Date: Mon, 13 Jan 2014 17:50:49 -0800 (PST) [thread overview]
Message-ID: <alpine.LSU.2.11.1401131742370.2229@eggly.anvils> (raw)
Shorten mem_cgroup_reclaim_iter.last_dead_count from unsigned long to
int: it's assigned from an int and compared with an int, and adjacent
to an unsigned int: so there's no point to it being unsigned long,
which wasted 104 bytes in every mem_cgroup_per_zone.
Signed-off-by: Hugh Dickins <hughd@google.com>
---
Putting this one first as it should be nicely uncontroversial.
I'm assuming much too late for v3.13, so all 3 diffed against mmotm.
mm/memcontrol.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- mmotm/mm/memcontrol.c 2014-01-10 18:25:02.236448954 -0800
+++ linux/mm/memcontrol.c 2014-01-12 22:21:10.700570471 -0800
@@ -149,7 +149,7 @@ struct mem_cgroup_reclaim_iter {
* matches memcg->dead_count of the hierarchy root group.
*/
struct mem_cgroup *last_visited;
- unsigned long last_dead_count;
+ int last_dead_count;
/* scan generation, increased every round-trip */
unsigned int generation;
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next reply other threads:[~2014-01-14 1:51 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-14 1:50 Hugh Dickins [this message]
2014-01-14 1:52 ` [PATCH 2/3] mm/memcg: fix endless iteration in reclaim Hugh Dickins
2014-01-14 13:27 ` Michal Hocko
2014-01-14 13:34 ` Michal Hocko
2014-01-14 14:26 ` Michal Hocko
2014-01-14 20:42 ` Hugh Dickins
2014-01-15 9:58 ` Michal Hocko
2014-01-15 12:17 ` Michal Hocko
2014-01-15 21:24 ` Hugh Dickins
2014-01-16 8:17 ` Michal Hocko
2014-01-16 15:22 ` Michal Hocko
2014-01-16 19:15 ` Hugh Dickins
2014-01-17 15:41 ` Michal Hocko
2014-01-21 5:16 ` Hugh Dickins
2014-01-21 8:34 ` Michal Hocko
2014-01-21 10:45 ` [PATCH -mm 1/2] memcg: fix endless loop caused by mem_cgroup_iter Michal Hocko
2014-01-21 10:45 ` [PATCH -mm 2/2] memcg: fix css reference leak and endless loop in mem_cgroup_iter Michal Hocko
2014-01-21 19:42 ` Andrew Morton
2014-01-21 21:18 ` Hugh Dickins
2014-01-22 8:27 ` Michal Hocko
2014-01-23 10:42 ` Hugh Dickins
2014-01-23 11:09 ` Michal Hocko
2014-01-23 12:53 ` Hugh Dickins
2014-01-22 8:12 ` Michal Hocko
2014-01-14 1:54 ` [PATCH 3/3] mm/memcg: iteration skip memcgs not yet fully initialized Hugh Dickins
2014-01-14 13:30 ` Michal Hocko
2014-01-14 14:29 ` Tejun Heo
2014-01-15 8:20 ` Michal Hocko
2014-01-15 8:21 ` Michal Hocko
2014-01-14 13:03 ` [PATCH 1/3] mm/memcg: fix last_dead_count memory wastage Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LSU.2.11.1401131742370.2229@eggly.anvils \
--to=hughd@google.com \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox