From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx142.postini.com [74.125.245.142]) by kanga.kvack.org (Postfix) with SMTP id BD18B6B005A for ; Mon, 16 Jul 2012 03:43:21 -0400 (EDT) Received: by pbbrp2 with SMTP id rp2so11604983pbb.14 for ; Mon, 16 Jul 2012 00:43:21 -0700 (PDT) Date: Mon, 16 Jul 2012 00:42:37 -0700 (PDT) From: Hugh Dickins Subject: [PATCH mmotm] mm, oom: reduce dependency on tasklist_lock: fix In-Reply-To: <20120713143206.GA4511@tiehlicka.suse.cz> Message-ID: References: <20120713143206.GA4511@tiehlicka.suse.cz> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-linux-mm@kvack.org List-ID: To: Andrew Morton , David Rientjes Cc: KAMEZAWA Hiroyuki , Johannes Weiner , KOSAKI Motohiro , Minchan Kim , Oleg Nesterov , Michal Hocko , linux-mm@kvack.org, cgroups@vger.kernel.org Slab poisoning gave me a General Protection Fault on the atomic_dec(&__task_cred(p)->user->processes); line of release_task() called from wait_task_zombie(), every time my dd to USB testing generated a memcg OOM. oom_kill_process() now does the put_task_struct(), mem_cgroup_out_of_memory() should not repeat it. Signed-off-by: Hugh Dickins --- mm/memcontrol.c | 1 - 1 file changed, 1 deletion(-) --- mmotm/mm/memcontrol.c 2012-07-11 14:50:29.808349013 -0700 +++ linux/mm/memcontrol.c 2012-07-15 12:21:26.234289161 -0700 @@ -1533,7 +1533,6 @@ void mem_cgroup_out_of_memory(struct mem points = chosen_points * 1000 / totalpages; oom_kill_process(chosen, gfp_mask, order, points, totalpages, memcg, NULL, "Memory cgroup out of memory"); - put_task_struct(chosen); } static unsigned long mem_cgroup_reclaim(struct mem_cgroup *memcg, -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org