From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx156.postini.com [74.125.245.156]) by kanga.kvack.org (Postfix) with SMTP id 0F6A86B0062 for ; Wed, 11 Jul 2012 14:56:10 -0400 (EDT) Received: by yenr5 with SMTP id r5so1866044yen.14 for ; Wed, 11 Jul 2012 11:56:09 -0700 (PDT) Date: Wed, 11 Jul 2012 11:55:34 -0700 (PDT) From: Hugh Dickins Subject: Re: [PATCH 1/3] tmpfs: revert SEEK_DATA and SEEK_HOLE In-Reply-To: Message-ID: References: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-linux-mm@kvack.org List-ID: To: Cong Wang Cc: linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org On Wed, 11 Jul 2012, Cong Wang wrote: > On Mon, 09 Jul 2012 at 22:41 GMT, Hugh Dickins wrote: > > Revert 4fb5ef089b28 ("tmpfs: support SEEK_DATA and SEEK_HOLE"). > > I believe it's correct, and it's been nice to have from rc1 to rc6; > > but as the original commit said: > > > > I don't know who actually uses SEEK_DATA or SEEK_HOLE, and whether it > > would be of any use to them on tmpfs. This code adds 92 lines and 752 > > bytes on x86_64 - is that bloat or worthwhile? > > > I don't think 752 bytes matter much, especially for x86_64. > > > > > Nobody asked for it, so I conclude that it's bloat: let's revert tmpfs > > to the dumb generic support for v3.5. We can always reinstate it later > > if useful, and anyone needing it in a hurry can just get it out of git. > > > > If you don't have burden to maintain it, I'd prefer to leave as it is, > I don't think 752-bytes is the reason we revert it. Thank you, your vote has been counted ;) and I'll be glad if yours stimulates some agreement or disagreement. But your vote would count for a lot more if you know of some app which would really benefit from this functionality in tmpfs: I've heard of none. Hugh -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org