From: Hugh Dickins <hughd@google.com>
To: Kamezawa Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: Johannes Weiner <hannes@cmpxchg.org>,
linux-mm@kvack.org, cgroups@vger.kernel.org, mhocko@suse.cz,
akpm@linux-foundation.org
Subject: Re: [PATCH] rename MEM_CGROUP_STAT_SWAPOUT as MEM_CGROUP_STAT_NR_SWAP
Date: Fri, 1 Jun 2012 10:54:27 -0700 (PDT) [thread overview]
Message-ID: <alpine.LSU.2.00.1206011047430.9814@eggly.anvils> (raw)
In-Reply-To: <20120601165320.GA1761@cmpxchg.org>
On Fri, 1 Jun 2012, Johannes Weiner wrote:
> On Fri, Jun 01, 2012 at 07:39:00PM +0900, Kamezawa Hiroyuki wrote:
> > MEM_CGROUP_STAT_SWAPOUT represents the usage of swap rather than
> > the number of swap-out events. Rename it to be MEM_CGROUP_STAT_NR_SWAP.
> >
> > Signed-off-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
>
> Wouldn't MEM_CGROUP_STAT_SWAP be better? It's equally descriptive but
> matches the string. And we also don't have NR_ for cache, rss, mapped
> file etc.
That's just what I thought too.
You can attach Acked-by: Hugh Dickins <hughd@google.com>
to MEM_CGROUP_STAT_SWAP and MEM_CGROUP_CHARGE_TYPE_ANON.
Oh, and to a patch deleting MEM_CGROUP_CHARGE_TYPE_FORCE!
Hugh
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-06-01 17:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-01 10:39 Kamezawa Hiroyuki
2012-06-01 11:11 ` Michal Hocko
2012-06-01 16:53 ` Johannes Weiner
2012-06-01 17:54 ` Hugh Dickins [this message]
2012-06-04 0:24 ` Kamezawa Hiroyuki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LSU.2.00.1206011047430.9814@eggly.anvils \
--to=hughd@google.com \
--cc=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=hannes@cmpxchg.org \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox