From: Hugh Dickins <hughd@google.com>
To: Will Deacon <will.deacon@arm.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Nicolas Pitre <nico@linaro.org>
Subject: Re: [PATCH] Revert "proc: clear_refs: do not clear reserved pages"
Date: Thu, 12 Apr 2012 10:51:10 -0700 (PDT) [thread overview]
Message-ID: <alpine.LSU.2.00.1204121049120.2288@eggly.anvils> (raw)
In-Reply-To: <1334250034-29866-1-git-send-email-will.deacon@arm.com>
On Thu, 12 Apr 2012, Will Deacon wrote:
> This reverts commit 85e72aa5384b1a614563ad63257ded0e91d1a620, which was
> a quick fix suitable for -stable until ARM had been moved over to the
> gate_vma mechanism:
>
> https://lkml.org/lkml/2012/1/14/55
>
> With commit f9d4861f ("ARM: 7294/1: vectors: use gate_vma for vectors user
> mapping"), ARM does now use the gate_vma, so the PageReserved check can
> be removed from the proc code.
>
> Cc: Nicolas Pitre <nico@linaro.org>
> Signed-off-by: Will Deacon <will.deacon@arm.com>
Oh, great, I'm glad that worked out: thanks a lot for looking after it,
Will, and now cleaning up afterwards.
Acked-by: Hugh Dickins <hughd@google.com>
> ---
> fs/proc/task_mmu.c | 3 ---
> 1 files changed, 0 insertions(+), 3 deletions(-)
>
> diff --git a/fs/proc/task_mmu.c b/fs/proc/task_mmu.c
> index 2b9a760..2d60492 100644
> --- a/fs/proc/task_mmu.c
> +++ b/fs/proc/task_mmu.c
> @@ -597,9 +597,6 @@ static int clear_refs_pte_range(pmd_t *pmd, unsigned long addr,
> if (!page)
> continue;
>
> - if (PageReserved(page))
> - continue;
> -
> /* Clear accessed and referenced bits. */
> ptep_test_and_clear_young(vma, addr, pte);
> ClearPageReferenced(page);
> --
> 1.7.4.1
>
>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-04-12 17:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-12 17:00 Will Deacon
2012-04-12 17:51 ` Hugh Dickins [this message]
2012-04-13 9:22 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LSU.2.00.1204121049120.2288@eggly.anvils \
--to=hughd@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=nico@linaro.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox