From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx200.postini.com [74.125.245.200]) by kanga.kvack.org (Postfix) with SMTP id 25E8A6B0092 for ; Fri, 6 Apr 2012 19:10:33 -0400 (EDT) Received: by iajr24 with SMTP id r24so4970101iaj.14 for ; Fri, 06 Apr 2012 16:10:32 -0700 (PDT) Date: Fri, 6 Apr 2012 16:10:13 -0700 (PDT) From: Hugh Dickins Subject: Re: [PATCH v2] hugetlb: fix race condition in hugetlb_fault() In-Reply-To: <20120406152305.59408e35.akpm@linux-foundation.org> Message-ID: References: <201203302018.q2UKIFH5020745@farm-0012.internal.tilera.com> <201203311339.q2VDdJMD006254@farm-0012.internal.tilera.com> <4F7887A5.3060700@tilera.com> <20120406152305.59408e35.akpm@linux-foundation.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-linux-mm@kvack.org List-ID: To: Andrew Morton Cc: Chris Metcalf , Hillf Danton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Michal Hocko , KAMEZAWA Hiroyuki On Fri, 6 Apr 2012, Andrew Morton wrote: > On Sun, 1 Apr 2012 12:51:49 -0400 > Chris Metcalf wrote: > > > >> Cc: stable@kernel.org > > > Let Andrew do the stable work, ok? > > > > Fair point. I'm used to adding the Cc myself for things I push through the > > arch/tile tree. This of course does make more sense to go through Andrew, > > so I'll remove it. > > No, please do add the stable tag if you think it is needed. And ensure > that the changelog explains why a backport is needed, by describing > the user-visible effects of the bug. > > Tree-owners regularly forget to wonder if a patch should be backported > and we end up failing to backport patches which should have been > backported. If we have more people flagging backport patches, fewer > patches will fall through the cracks. The resulting patch is okay; but let's reassure Chris that his original patch was better, before he conceded to make the get_page and put_page unconditional, and added unnecessary detail of the race. Hugh -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org