From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx184.postini.com [74.125.245.184]) by kanga.kvack.org (Postfix) with SMTP id 379116B00E8 for ; Fri, 23 Mar 2012 17:15:27 -0400 (EDT) Received: by ghrr18 with SMTP id r18so3980138ghr.14 for ; Fri, 23 Mar 2012 14:15:26 -0700 (PDT) Date: Fri, 23 Mar 2012 14:14:54 -0700 (PDT) From: Hugh Dickins Subject: Re: [PATCH] mm for fs: add truncate_pagecache_range In-Reply-To: <20120323140120.11f95cd5.akpm@linux-foundation.org> Message-ID: References: <20120323140120.11f95cd5.akpm@linux-foundation.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-linux-mm@kvack.org List-ID: To: Andrew Morton Cc: Christoph Hellwig , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org On Fri, 23 Mar 2012, Andrew Morton wrote: > > --- a/mm/truncate.c~mm-for-fs-add-truncate_pagecache_range-fix > +++ a/mm/truncate.c > @@ -639,6 +639,9 @@ int vmtruncate_range(struct inode *inode > * with on-disk format, and the filesystem would not have to deal with > * situations such as writepage being called for a page that has already > * had its underlying blocks deallocated. > + * > + * Must be called with inode->i_mapping->i_mutex held. You catch me offguard: I forget whether that's an absolute requirement or just commonly the case. What do the other interfaces in truncate.c say ?-) > + * Takes inode->i_mapping->i_mmap_mutex. Yes, and inode->i_mapping->tree_lock. > */ > void truncate_pagecache_range(struct inode *inode, loff_t lstart, loff_t lend) > { > > yes? Probably! Hugh -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org