linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Hugh Dickins <hughd@google.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Johannes Weiner <hannes@cmpxchg.org>,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
	Konstantin Khlebnikov <khlebnikov@openvz.org>,
	Tejun Heo <tj@kernel.org>, Ying Han <yinghan@google.com>,
	Stanislaw Gruszka <sgruszka@redhat.com>,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH 3.3] memcg: free mem_cgroup by RCU to fix oops
Date: Fri, 9 Mar 2012 11:58:34 -0800 (PST)	[thread overview]
Message-ID: <alpine.LSU.2.00.1203091138260.19300@eggly.anvils> (raw)
In-Reply-To: <alpine.LSU.2.00.1203072155140.11048@eggly.anvils>

On Wed, 7 Mar 2012, Hugh Dickins wrote:
> 
> I'm posting this a little prematurely to get eyes on it, since it's
> more than a two-liner, but 3.3 time is running out.  If it is what's
> needed to fix my oopses, I won't really be sure before Friday morning.
> What's running now on the machine affected is using kfree_rcu(), but I
> did hack it earlier to check that the vfree_rcu() alternative works.

Yes, please do send that patch on to Linus for 3.3.

It did not get as much as the 36 hours of testing I had hoped for, only
25 hours so far.  12 hours while I was out yesterday got wasted by a
wireless driver interrupt spewing approximately one million messages:

iwl3945 0000:08:00.0: MAC is in deep sleep!. CSR_GP_CNTRL = 0xFFFFFFFF

which I've not suffered from before, and hope not again.  Having kdb
in, I did take a look what was going on with the memcg load when it was
interrupted: it appeared to be normal, and I've no reason to suppose that
my kfree_rcu() was in any way responsible for the wireless aberration.

Thanks,
Hugh

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  parent reply	other threads:[~2012-03-09 19:59 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-08  6:01 Hugh Dickins
2012-03-08  6:12 ` KAMEZAWA Hiroyuki
2012-03-08 20:45 ` Andrew Morton
2012-03-09 19:58 ` Hugh Dickins [this message]
2012-03-12 15:09   ` Stanislaw Gruszka
2012-03-12 18:43     ` Hugh Dickins
2012-03-13 17:53 ` Johannes Weiner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LSU.2.00.1203091138260.19300@eggly.anvils \
    --to=hughd@google.com \
    --cc=akpm@linux-foundation.org \
    --cc=hannes@cmpxchg.org \
    --cc=kamezawa.hiroyu@jp.fujitsu.com \
    --cc=khlebnikov@openvz.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=sgruszka@redhat.com \
    --cc=tj@kernel.org \
    --cc=yinghan@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox