From: Hugh Dickins <hughd@google.com>
To: KOSAKI Motohiro <kosaki.motohiro@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
David Rientjes <rientjes@google.com>,
Minchan Kim <minchan.kim@gmail.com>, Mel Gorman <mel@csn.ul.ie>,
Johannes Weiner <jweiner@redhat.com>
Subject: Re: [PATCH 1/2] mm,mlock: drain pagevecs asynchronously
Date: Wed, 4 Jan 2012 16:19:13 -0800 (PST) [thread overview]
Message-ID: <alpine.LSU.2.00.1201041549410.1267@eggly.anvils> (raw)
In-Reply-To: <4F04E1B8.10109@gmail.com>
On Wed, 4 Jan 2012, KOSAKI Motohiro wrote:
> (1/4/12 5:05 PM), Andrew Morton wrote:
> > On Sun, 1 Jan 2012 02:30:24 -0500
> > kosaki.motohiro@gmail.com wrote:
> >
> > > Because lru_add_drain_all() spent much time.
> >
> > Those LRU pagevecs are horrid things. They add high code and
> > conceptual complexity, they add pointless uniprocessor overhead and the
> > way in which they leave LRU pages floating around not on an LRU is
> > rather maddening.
Yes, we continue to have difficulties with not-quite-PageLRU-yet pages.
> >
> > So the best way to fix all of this as well as this problem we're
> > observing is, I hope, to completely remove them.
Nice aim, sounds like a dirty job. I wonder how far we could get using
lru_add_drain, avoiding lru_add_drain_all, and flushing pvec when pre-empted.
> ...
>
> got it. so, let's wait hugh's "mm: take pagevecs off reclaim stack" next spin
> and make the patches on top of it.
Don't wait on me, I wasn't intending another spin, with Andrew's last
word on it today:
> If we already have the latency problem at the isolate_lru_pages() stage
> then I suppose we can assume that nobody is noticing it, so we'll
> probably be OK.
>
> For a while. Someone will complain at some stage and we'll probably
> end up busting this work into chunks.
and mm-commits does presently have my
mm-rearrange-putback-inactive-pages.patch in on top of it.
Besides, these free_hot_cold_page_list() users are already avoiding
the lru add pagevecs which Andrew is nudging towards removing above,
so there shouldn't be much overlap.
Or maybe you're thinking of my observation that it could avoid the
!page_evictable putback_lru_page special case now: yes, I'd like to
make that change sometime, but moved away to other things for now.
Hugh
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-01-05 0:19 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-30 6:36 [PATCH] mm: do not drain pagevecs for mlock Tao Ma
2011-12-30 8:11 ` KOSAKI Motohiro
2011-12-30 8:48 ` Tao Ma
2011-12-30 9:31 ` KOSAKI Motohiro
2011-12-30 9:45 ` Tao Ma
2011-12-30 10:07 ` KOSAKI Motohiro
2012-01-01 7:30 ` [PATCH 1/2] mm,mlock: drain pagevecs asynchronously kosaki.motohiro
2012-01-04 1:17 ` Minchan Kim
2012-01-04 2:38 ` KOSAKI Motohiro
2012-01-10 8:53 ` Tao Ma
2012-01-04 2:56 ` Hugh Dickins
2012-01-04 22:05 ` Andrew Morton
2012-01-04 23:33 ` KOSAKI Motohiro
2012-01-05 0:19 ` Hugh Dickins [this message]
2012-01-01 7:30 ` [PATCH 2/2] sysvshm: SHM_LOCK use lru_add_drain_all_async() kosaki.motohiro
2012-01-04 1:51 ` Hugh Dickins
2012-01-04 2:19 ` KOSAKI Motohiro
2012-01-04 5:17 ` Hugh Dickins
2012-01-04 8:34 ` KOSAKI Motohiro
2012-01-06 6:13 ` [PATCH] mm: do not drain pagevecs for mlock Tao Ma
2012-01-06 6:18 ` KOSAKI Motohiro
2012-01-06 6:30 ` Tao Ma
2012-01-06 6:33 ` KOSAKI Motohiro
2012-01-06 6:46 ` Tao Ma
2012-01-09 23:58 ` KOSAKI Motohiro
2012-01-10 2:08 ` Tao Ma
2012-01-09 7:25 ` Tao Ma
2011-12-30 10:14 ` KOSAKI Motohiro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LSU.2.00.1201041549410.1267@eggly.anvils \
--to=hughd@google.com \
--cc=akpm@linux-foundation.org \
--cc=jweiner@redhat.com \
--cc=kosaki.motohiro@gmail.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mel@csn.ul.ie \
--cc=minchan.kim@gmail.com \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox