From: Hugh Dickins <hughd@google.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Michal Hocko <mhocko@suse.cz>,
linux-mm@kvack.org
Subject: [PATCH 3/4] memcg: fix page migration to reset_owner
Date: Wed, 28 Dec 2011 16:23:29 -0800 (PST) [thread overview]
Message-ID: <alpine.LSU.2.00.1112281622080.8257@eggly.anvils> (raw)
In-Reply-To: <alpine.LSU.2.00.1112281613550.8257@eggly.anvils>
Usually, migration pages coming to unmap_and_move()'s putback_lru_page()
have been charged and have pc->mem_cgroup set; but there are several ways
in which a freshly allocated uncharged page can get there, oopsing when
added to LRU. Call mem_cgroup_reset_owner() immediately after allocating.
Signed-off-by: Hugh Dickins <hughd@google.com>
---
Fix N to
memcg: clear pc->mem_cgorup if necessary.
mm/migrate.c | 2 ++
1 file changed, 2 insertions(+)
--- mmotm.orig/mm/migrate.c 2011-12-22 02:53:31.900041565 -0800
+++ mmotm/mm/migrate.c 2011-12-28 14:52:37.243034125 -0800
@@ -841,6 +841,8 @@ static int unmap_and_move(new_page_t get
if (!newpage)
return -ENOMEM;
+ mem_cgroup_reset_owner(newpage);
+
if (page_count(page) == 1) {
/* page was freed from under us. So we are done. */
goto out;
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-12-29 0:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-29 0:17 [PATCH 0/4] memcg: four fixes to current next Hugh Dickins
2011-12-29 0:20 ` [PATCH 1/4] memcg: fix split_huge_page_refcounts Hugh Dickins
2012-01-05 5:55 ` KAMEZAWA Hiroyuki
2011-12-29 0:21 ` [PATCH 2/4] memcg: fix NULL mem_cgroup_try_charge Hugh Dickins
2012-01-05 5:56 ` KAMEZAWA Hiroyuki
2011-12-29 0:23 ` Hugh Dickins [this message]
2012-01-05 6:00 ` [PATCH 3/4] memcg: fix page migration to reset_owner KAMEZAWA Hiroyuki
2011-12-29 0:26 ` [PATCH 4/4] memcg: fix mem_cgroup_print_bad_page Hugh Dickins
2012-01-05 6:01 ` KAMEZAWA Hiroyuki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LSU.2.00.1112281622080.8257@eggly.anvils \
--to=hughd@google.com \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox