From: Hugh Dickins <hughd@google.com>
To: Johannes Weiner <hannes@cmpxchg.org>
Cc: Minchan Kim <minchan.kim@gmail.com>,
Thomas Meyer <thomas@m3y3r.de>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-mm <linux-mm@kvack.org>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
Balbir Singh <balbir@linux.vnet.ibm.com>,
Andrew Morton <akpm@linux-foundation.org>,
Hugh Dickins <hughd@google.com>
Subject: Re: 2.6.37-rc7: NULL pointer dereference
Date: Wed, 29 Dec 2010 13:50:22 -0800 (PST) [thread overview]
Message-ID: <alpine.LSU.2.00.1012291344460.22803@sister.anvils> (raw)
In-Reply-To: <20101222164151.GA2048@cmpxchg.org>
[-- Attachment #1: Type: TEXT/PLAIN, Size: 1308 bytes --]
On Wed, 22 Dec 2010, Johannes Weiner wrote:
> On Thu, Dec 23, 2010 at 12:37:11AM +0900, Minchan Kim wrote:
> > On Wed, Dec 22, 2010 at 9:25 PM, Thomas Meyer <thomas@m3y3r.de> wrote:
> > > BUG: unable to handle kernel NULL pointer dereference at 00000008
> > > IP: [<c04eae14>] __mem_cgroup_try_charge+0x234/0x430
> > > Process swapoff (pid: 8058, ti=f2e70000 task=f3e55860 task.ti=f2e70000)
> > > Call Trace:
> > > [<c0456607>] ? ktime_get_ts+0x107/0x140
> > > [<c04ebb89>] ? mem_cgroup_try_charge_swapin+0x49/0xb0
> > > [<c04d9b4b>] ? unuse_mm+0x1db/0x300
> > > [<c04dad9a>] ? sys_swapoff+0x2aa/0x890
> > > [<c047cd58>] ? audit_syscall_entry+0x218/0x240
> > > [<c047d043>] ? audit_syscall_exit+0x1f3/0x220
> > > [<c0403013>] ? sysenter_do_call+0x12/0x22
>
> This could be explained by a kernel without VM_BUG_ON(), where
> !mm->owner goes uncaught until css_tryget() reads mem.css.flags (eight
> bytes member offset on 32-bit).
>
> Does
> http://marc.info/?l=linux-mm&m=128889198016021&w=2
> help?
I'm sure you're right, Hannes. Thanks for the prod. Sadly, Kame
and I both let the fix drift, expecting it to magick its way into
Linus's tree. We're now at rc8: I'd better change my Acked-by to
a Signed-off-by and try sending it in immediately: will do so now.
Hugh
next prev parent reply other threads:[~2010-12-29 21:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1293020757.1998.2.camel@localhost.localdomain>
2010-12-22 15:37 ` Minchan Kim
2010-12-22 16:41 ` Johannes Weiner
2010-12-29 21:50 ` Hugh Dickins [this message]
2010-12-29 22:07 ` [PATCH] memcg: fix wrong VM_BUG_ON() in try_charge()'s mm->owner check Hugh Dickins
2010-12-22 19:06 ` 2.6.37-rc7: NULL pointer dereference Balbir Singh
2010-12-23 13:21 ` Thomas Meyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LSU.2.00.1012291344460.22803@sister.anvils \
--to=hughd@google.com \
--cc=akpm@linux-foundation.org \
--cc=balbir@linux.vnet.ibm.com \
--cc=hannes@cmpxchg.org \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan.kim@gmail.com \
--cc=thomas@m3y3r.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox