From: Hugh Dickins <hugh.dickins@tiscali.co.uk>
To: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
kiran@scalex86.org, cl@linux-foundation.org,
lee.schermerhorn@hp.com, mel@csn.ul.ie, stable@kernel.org,
linux-mm <linux-mm@kvack.org>,
akpm@linux-foundation.org
Subject: Re: [PATCH 3/5] tmpfs: handle MPOL_LOCAL mount option properly
Date: Wed, 17 Mar 2010 16:26:41 +0000 (GMT) [thread overview]
Message-ID: <alpine.LSU.2.00.1003171619410.29003@sister.anvils> (raw)
In-Reply-To: <20100316145022.4C4E.A69D9226@jp.fujitsu.com>
On Tue, 16 Mar 2010, KOSAKI Motohiro wrote:
> commit 71fe804b6d5 (mempolicy: use struct mempolicy pointer in
> shmem_sb_info) added mpol=local mount option. but its feature is
> broken since it was born. because such code always return 1 (i.e.
> mount failure).
>
> This patch fixes it.
>
> Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
> Cc: Ravikiran Thirumalai <kiran@scalex86.org>
Thank you both for finding and fixing these mpol embarrassments.
But if this "mpol=local" feature was never documented (not even in the
commit log), has been broken since birth 20 months ago, and nobody has
noticed: wouldn't it be better to save a little bloat and just rip it out?
Hugh
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-03-17 16:27 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <201003122353.o2CNrC56015250@imap1.linux-foundation.org>
2010-03-16 5:47 ` + tmpfs-fix-oops-on-remounts-with-mpol=default.patch added to -mm tree KOSAKI Motohiro
2010-03-16 5:49 ` [PATCH 1/5] tmpfs: fix oops on mounts with mpol=default KOSAKI Motohiro
2010-03-17 14:16 ` Lee Schermerhorn
2010-03-16 5:50 ` [PATCH 2/5] tmpfs: mpol=bind:0 don't cause mount error KOSAKI Motohiro
2010-03-17 14:17 ` Lee Schermerhorn
2010-03-16 5:51 ` [PATCH 3/5] tmpfs: handle MPOL_LOCAL mount option properly KOSAKI Motohiro
2010-03-17 14:25 ` Lee Schermerhorn
2010-03-17 16:26 ` Hugh Dickins [this message]
2010-03-17 23:52 ` KOSAKI Motohiro
2010-03-18 1:55 ` Lee Schermerhorn
2010-03-18 21:21 ` Hugh Dickins
2010-03-16 5:52 ` [PATCH 4/5] tmpfs: cleanup mpol_parse_str() KOSAKI Motohiro
2010-03-17 14:25 ` Lee Schermerhorn
2010-03-16 5:53 ` [PATCH 5/5] doc: add the documentation for mpol=local KOSAKI Motohiro
2010-03-17 14:42 ` Lee Schermerhorn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LSU.2.00.1003171619410.29003@sister.anvils \
--to=hugh.dickins@tiscali.co.uk \
--cc=akpm@linux-foundation.org \
--cc=cl@linux-foundation.org \
--cc=kiran@scalex86.org \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=lee.schermerhorn@hp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mel@csn.ul.ie \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox