Re: [PATCH] kvm : remove redundant initialization of page->private

[Hugh Dickins <hugh.dickins@tiscali.co.uk>]

On Thu, 11 Mar 2010, Avi Kivity wrote:
> On 03/11/2010 10:51 AM, Jan Kiszka wrote:
> > >      
> > Thanks for pointing out! Since which kernel can we rely on the implicit
> > set_page_private?
> 
> Um, git blame shows it goes all the way back to 2.6.12.  So it was redundant
> all along.

Not that it matters at all, but no, that was just the dawning of the git age.
prep_new_page() started initializing page->private in 2.6.0-test3:

<akpm@osdl.org>
	[PATCH] initialise page->private
	
	From: Nathan Scott <nathans@sgi.com>
	
	XFS wants to use page->private as a bitmap of uptodate indicators for
	sub-page-sized blocks (which is one of the things ->provate was intended
	for).
	
	But someone needs to initialise ->private somewhere.  best to do it in the
	page allocator, so the zeroness of a new page's ->private becomes a
	system-wide thing.

Hugh

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>