From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47FE9C3A59C for ; Thu, 15 Aug 2019 19:21:52 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 15E5D2086C for ; Thu, 15 Aug 2019 19:21:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 15E5D2086C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=namei.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 974126B027A; Thu, 15 Aug 2019 15:21:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 925136B0281; Thu, 15 Aug 2019 15:21:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 813D66B0282; Thu, 15 Aug 2019 15:21:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0110.hostedemail.com [216.40.44.110]) by kanga.kvack.org (Postfix) with ESMTP id 5F2F26B027A for ; Thu, 15 Aug 2019 15:21:51 -0400 (EDT) Received: from smtpin21.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with SMTP id 14EE96406 for ; Thu, 15 Aug 2019 19:21:51 +0000 (UTC) X-FDA: 75825632022.21.land97_847f0c8a24239 X-HE-Tag: land97_847f0c8a24239 X-Filterd-Recvd-Size: 5549 Received: from namei.org (namei.org [65.99.196.166]) by imf12.hostedemail.com (Postfix) with ESMTP for ; Thu, 15 Aug 2019 19:21:50 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by namei.org (8.14.4/8.14.4) with ESMTP id x7FJKa6b013630; Thu, 15 Aug 2019 19:20:36 GMT Date: Fri, 16 Aug 2019 05:20:36 +1000 (AEST) From: James Morris To: Greg Kroah-Hartman cc: Mark Salyzyn , linux-kernel@vger.kernel.org, kernel-team@android.com, Stephen Smalley , linux-security-module@vger.kernel.org, stable@vger.kernel.org, Eric Van Hensbergen , Latchesar Ionkov , Dominique Martinet , David Howells , Chris Mason , Josef Bacik , David Sterba , Jeff Layton , Sage Weil , Ilya Dryomov , Steve French , Tyler Hicks , Jan Kara , "Theodore Ts'o" , Andreas Dilger , Jaegeuk Kim , Chao Yu , Miklos Szeredi , Bob Peterson , Andreas Gruenbacher , David Woodhouse , Richard Weinberger , Dave Kleikamp , Tejun Heo , Trond Myklebust , Anna Schumaker , Mark Fasheh , Joel Becker , Joseph Qi , Mike Marshall , Martin Brandenburg , Alexander Viro , Phillip Lougher , "Darrick J. Wong" , linux-xfs@vger.kernel.org, Hugh Dickins , "David S. Miller" , Serge Hallyn , Mimi Zohar , Paul Moore , Eric Paris , Casey Schaufler , Andrew Morton , Vyacheslav Dubeyko , =?ISO-8859-15?Q?Ernesto_A=2E_Fern=E1ndez?= , Mathieu Malaterre , v9fs-developer@lists.sourceforge.net, linux-afs@lists.infradead.org, linux-btrfs@vger.kernel.org, ceph-devel@vger.kernel.org, linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, ecryptfs@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-fsdevel@vger.kernel.org, cluster-devel@redhat.com, linux-mtd@lists.infradead.org, jfs-discussion@lists.sourceforge.net, linux-nfs@vger.kernel.org, ocfs2-devel@oss.oracle.com, devel@lists.orangefs.org, linux-unionfs@vger.kernel.org, reiserfs-devel@vger.kernel.org, linux-mm@kvack.org, netdev@vger.kernel.org, linux-integrity@vger.kernel.org, selinux@vger.kernel.org Subject: Re: [PATCH] Add flags option to get xattr method paired to __vfs_getxattr In-Reply-To: <20190813084801.GA972@kroah.com> Message-ID: References: <20190812193320.200472-1-salyzyn@android.com> <20190813084801.GA972@kroah.com> User-Agent: Alpine 2.21 (LRH 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 13 Aug 2019, Greg Kroah-Hartman wrote: > On Mon, Aug 12, 2019 at 12:32:49PM -0700, Mark Salyzyn wrote: > > --- a/include/linux/xattr.h > > +++ b/include/linux/xattr.h > > @@ -30,10 +30,10 @@ struct xattr_handler { > > const char *prefix; > > int flags; /* fs private flags */ > > bool (*list)(struct dentry *dentry); > > - int (*get)(const struct xattr_handler *, struct dentry *dentry, > > + int (*get)(const struct xattr_handler *handler, struct dentry *dentry, > > struct inode *inode, const char *name, void *buffer, > > - size_t size); > > - int (*set)(const struct xattr_handler *, struct dentry *dentry, > > + size_t size, int flags); > > + int (*set)(const struct xattr_handler *handler, struct dentry *dentry, > > struct inode *inode, const char *name, const void *buffer, > > size_t size, int flags); > > Wow, 7 arguments. Isn't there some nice rule of thumb that says once > you get more then 5, a function becomes impossible to understand? > > Surely this could be a structure passed in here somehow, that way when > you add the 8th argument in the future, you don't have to change > everything yet again? :) > > I don't have anything concrete to offer as a replacement fix for this, > but to me this just feels really wrong... How about something like: struct xattr_gs_args { struct dentry *dentry; struct inode *inode; const char *name; const void *buffer; size_t size; int flags; }; int (*get)(const struct xattr_handler *handler, struct xattr_gs_args *args); int (*set)(const struct xattr_handler *handler, struct xattr_gs_args *args); -- James Morris