From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk0-f198.google.com (mail-qk0-f198.google.com [209.85.220.198]) by kanga.kvack.org (Postfix) with ESMTP id 53FC96B0007 for ; Thu, 26 Apr 2018 10:28:52 -0400 (EDT) Received: by mail-qk0-f198.google.com with SMTP id h135so3890190qke.10 for ; Thu, 26 Apr 2018 07:28:52 -0700 (PDT) Received: from mx1.redhat.com (mx3-rdu2.redhat.com. [66.187.233.73]) by mx.google.com with ESMTPS id d5-v6si4530416qte.380.2018.04.26.07.28.51 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 26 Apr 2018 07:28:51 -0700 (PDT) Date: Thu, 26 Apr 2018 10:28:45 -0400 (EDT) From: Mikulas Patocka Subject: Re: [dm-devel] [PATCH v5] fault-injection: introduce kvmalloc fallback options In-Reply-To: <20180426125817.GO17484@dhcp22.suse.cz> Message-ID: References: <20180424170349.GQ17484@dhcp22.suse.cz> <20180424173836.GR17484@dhcp22.suse.cz> <1114eda5-9b1f-4db8-2090-556b4a37c532@infradead.org> <1524694663.4100.21.camel@HansenPartnership.com> <20180426125817.GO17484@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-linux-mm@kvack.org List-ID: To: Michal Hocko Cc: James Bottomley , David Rientjes , dm-devel@redhat.com, eric.dumazet@gmail.com, mst@redhat.com, netdev@vger.kernel.org, jasowang@redhat.com, Randy Dunlap , linux-kernel@vger.kernel.org, Matthew Wilcox , linux-mm@kvack.org, edumazet@google.com, Andrew Morton , virtualization@lists.linux-foundation.org, David Miller , Vlastimil Babka On Thu, 26 Apr 2018, Michal Hocko wrote: > On Wed 25-04-18 18:42:57, Mikulas Patocka wrote: > > > > > > On Wed, 25 Apr 2018, James Bottomley wrote: > [...] > > > Kconfig proliferation, conversely, is a bit of a nightmare from both > > > the user and the tester's point of view, so we're trying to avoid it > > > unless absolutely necessary. > > > > > > James > > > > I already offered that we don't need to introduce a new kernel option and > > we can bind this feature to any other kernel option, that is enabled in > > the debug kernel, for example CONFIG_DEBUG_SG. Michal said no and he said > > that he wants a new kernel option instead. > > Just for the record. I didn't say I _want_ a config option. Do not > misinterpret my words. I've said that a config option would be > acceptable if there is no way to deliver the functionality via kernel > package automatically. You haven't provided any argument that would > explain why the kernel package cannot add a boot option. Maybe there are > some but I do not see them right now. AFAIK Grub doesn't load per-kernel options from a per-kernel file. Even if we hacked grub scripts to add this option, other distributions won't. Mikulas